diff --git a/.agents/rules/news.md b/.agents/rules/news.md index ce8a844439..7946967ad4 100644 --- a/.agents/rules/news.md +++ b/.agents/rules/news.md @@ -1,14 +1,15 @@ --- -trigger: news/*.md +trigger: glob description: Apply when drafting news entries. +globs: "news/*.md" --- @CONTRIBUTING.md # News Entry Conventions -Before drafting any news entry, strictly adhere to the rules in `CONTRIBUTING.md` -above. +Before drafting any news entry, adhere strictly to the rules in +`CONTRIBUTING.md` above. ## Sphinx MyST Cross-Reference Syntax (`{obj}`) * Use `{obj}\`\`` in news entries for rules, macros, targets, providers, @@ -17,4 +18,9 @@ above. ## GitHub Issue Link Formatting * Append GitHub issue cross-references at the end of news entries in markdown - link format: `([#3283](https://github.com/bazel-contrib/rules_python/issues/3283))`. + link format: + `([#3283](https://github.com/bazel-contrib/rules_python/issues/3283))`. + +## Unreleased and Internal Changes +* Do not add news entries for internal refactoring or fixes to unreleased code. + News entries are only for released, user-visible behavior. diff --git a/.agents/rules/pr.md b/.agents/rules/pr.md index bc6f87f44b..6f211e0693 100644 --- a/.agents/rules/pr.md +++ b/.agents/rules/pr.md @@ -27,6 +27,8 @@ Before drafting any pull request description, strictly adhere to the rules in `fix(tests):`). * `agents:` / `agents():`: Agent rules, skills, and prompts (`.agents/`). +* `refactor:`: Internal refactoring and fixes for unreleased changes. Never use + `fix:` or `feat:` unless modifying released, user-visible behavior. ## PR Commit Workflow Invariant * Once a Pull Request is created, always make new commits or merge commits. diff --git a/.agents/rules/workspace.md b/.agents/rules/workspace.md index bc64d4779c..b3bb174514 100644 --- a/.agents/rules/workspace.md +++ b/.agents/rules/workspace.md @@ -17,4 +17,7 @@ basis: .agents/scripts/setup_triangle_branch.sh ``` * Never use `git push -u` or `--set-upstream` (it breaks upstream tracking). +* When pushing to a checked-out PR branch from an external fork, push + explicitly to that remote (`git push HEAD:`). Do not rely on + a bare `git push`.