Skip to content

Bigcommerce::Request: Do Not Modify Caller's Hash When Accessing Connection  #181

Description

@sshaw

Expected behavior

API request method calls do not modify the caller's references.

Actual behavior

Bigcommerce::Request#raw_request calls params.delete(:connection) removing :connection from caller

Steps to reproduce behavior

options = {
  :page => page,
  :limit  => 250,
  :connection => connection
}

customers = Bigcommerce::Customer.all(options)
# process
# get page 2

options[:page] = page + 1

# NoMethodError because :connection was remove by prior call
customers = Bigcommerce::Customer.all(options)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions