Executor Content View
Body paragraph with RELLINK inside it.
@@ -108,3 +122,29 @@ def test_read_markdown_notes_ride_the_executor_warning_channel( assert "output truncated" in result.stderr # ...and never into the markdown itself. assert "output truncated" not in result.stdout + + +def test_internal_views_use_an_isolated_world( + ext_ready, e2e_daemon, page_url, tmp_path, +): + """Page hooks cannot intercept internal views, and auxiliary CDP detach + leaves the executor's primary Playwright page usable.""" + result = run_skill( + f'page.goto({page_url!r})\n' + 'print(read_markdown(mode="full"))\n' + 'print(snapshot())\n' + 'aux = context.new_cdp_session(page)\n' + 'aux.detach()\n' + 'print(snapshot())\n' + 'import json\n' + 'print("ISOLATION:" + json.dumps(page.evaluate("() => ({reads: window.mainWorldDomReads, globals: Object.keys(window).filter(k => k.startsWith(\\\"__bw\\\") || k.startsWith(\\\"__browserwright\\\"))})")))', + backend="extension", runtime_dir=e2e_daemon.runtime_dir, timeout=120.0, + ) + artifact = Path(tmp_path) / "internal-views-isolation.json" + artifact.write_text(json.dumps({"stdout": result.stdout, + "stderr": result.stderr, + "returncode": result.returncode}, indent=2)) + assert result.returncode == 0, f"{artifact}: {result.stderr}" + evidence = json.loads(result.stdout.split("ISOLATION:", 1)[1].splitlines()[0]) + assert evidence == {"reads": 0, "globals": []}, f"{artifact}: {evidence}" + assert "Executor Content View" in result.stdout diff --git a/tests/daemon/e2e/test_l1_title_marker_no_freeze.py b/tests/daemon/e2e/test_l1_title_marker_no_freeze.py index edeb05d..6dd7575 100644 --- a/tests/daemon/e2e/test_l1_title_marker_no_freeze.py +++ b/tests/daemon/e2e/test_l1_title_marker_no_freeze.py @@ -1,219 +1,18 @@ -"""L1 -- the 👀 tab marker must reach a fixpoint, not spin the renderer. +"""Extension attachment must leave page title/accessors intact and responsive. -The reported symptom was a *random* freeze: an agent command goes out and -nothing ever comes back (`relay send failed: TimeoutError()`). The cause was -not in the daemon at all -- it was in the extension's cosmetic tab marker. - -`MARKER_INSTALL_SCRIPT` puts a `MutationObserver` on `document.head` whose -callback re-asserts the `"👀 "` prefix on `document.title`. The prefix carries a -trailing space, and the HTML spec's `document.title` getter *strips* trailing -ASCII whitespace -- so on a page whose title is empty the script writes `"👀 "`, -reads back `"👀"`, decides the title is still wrong, and writes again. Each -write mutates ``, which re-fires the observer as a microtask, which -writes again: an unbounded microtask loop that pins the renderer's main thread. -A pinned renderer never answers `chrome.debugger.sendCommand`, so the extension -never sends its `{type:"response"}`, so the relay's `asyncio.wait_for(fut, 10)` -expires. Only *empty-titled* pages trip it -- `about:blank`, `data:` URLs, pages -caught before their title is set -- which is exactly what made it look random. - -Two tests, deliberately at different levels: - -1. `test_marker_script_reaches_a_fixpoint` runs the **real** script text pulled - out of `chrome-extension/background.js` in a real renderer, with no daemon - and no extension in the way. It is the sharp one: it fails in seconds, it - names the fixpoint invariant directly, and it cannot pass by accident. -2. `test_empty_title_tab_answers_a_renderer_command` drives the whole stack the - way the user did -- session tab on `about:blank`, then a renderer-scoped CDP - command -- and gives it a wall-clock budget, in the spirit of - `tests/daemon/test_hang_budget.py`: *a result or an error, either is fine, - but within N seconds.* +The former title marker rewrote the DOM and could spin an empty-title renderer. +The browser UI indicator now belongs to the extension, so test the actual +extension-backed path rather than executing the retired marker snippets. """ from __future__ import annotations -import asyncio import json import time -from pathlib import Path - -import pytest from .helpers import run_skill -#: The marker converges in one or two writes. Anything past this is the loop. -FIXPOINT_BUDGET_S = 10.0 - -#: A renderer-scoped eval on a freshly-attached blank tab. The relay's own -#: per-command deadline is 10s; the budget covers tab creation + attach + eval -#: with room to spare, while still being far below "hung". RENDERER_BUDGET_S = 45.0 -EXT_SOURCE_DIR = Path(__file__).resolve().parents[3] / "chrome-extension" - -#: The marker section of background.js is pure JS -- constants and template -#: literals, no `chrome.*` -- so it can be evaluated verbatim in a page. Slicing -#: it by these anchors keeps the test pinned to the shipped source instead of a -#: copy that can silently drift. If either anchor moves, this test fails loudly -#: rather than testing a stale duplicate. -_REGION_START = "const TITLE_PREFIX" -_REGION_END = "const markedTabs" - - -def _marker_region() -> str: - src = (EXT_SOURCE_DIR / "background.js").read_text(encoding="utf-8") - try: - start = src.index(_REGION_START) - end = src.index(_REGION_END) - except ValueError as e: # pragma: no cover - structural drift - raise AssertionError( - f"could not slice the marker section out of background.js " - f"({_REGION_START!r} .. {_REGION_END!r}); the anchors moved" - ) from e - assert start < end - region = src[start:end] - assert "MARKER_INSTALL_SCRIPT" in region - # Comments in this region legitimately *discuss* chrome.debugger; only real - # code would stop it evaluating standalone. - code = "\n".join(ln for ln in region.splitlines() - if not ln.strip().startswith("//")) - assert "chrome." not in code, ( - "the marker region gained a chrome.* reference; it can no longer be " - "evaluated standalone in a page" - ) - return region - - -async def _fixpoint_probe(browser_binary: Path) -> dict: - """Install the real marker script on pages with hostile titles. - - Returns a report per scenario. Every step is wrapped in `asyncio.wait_for` - because the failure being pinned is a *wedged renderer*: without a deadline - `page.evaluate` simply never returns and the test hangs instead of failing. - - Driven with Chrome for Testing (the binary this suite already requires) - rather than Playwright's own bundled build, so the test needs no extra - download and exercises the same engine the rest of the e2e suite does. No - extension and no daemon are involved — only the script text. - """ - from playwright.async_api import async_playwright - - report: dict[str, dict] = {} - async with async_playwright() as p: - browser = await p.chromium.launch( - executable_path=str(browser_binary), headless=True) - try: - page = await browser.new_page() - await page.goto("about:blank") - scripts = await page.evaluate( - "(region) => new Function(region + '\\n" - "return {install: MARKER_INSTALL_SCRIPT," - " remove: MARKER_REMOVE_SCRIPT};')()", - _marker_region(), - ) - - scenarios = [ - # (label, page title before the marker is installed, expected - # title the page itself should still observe afterwards) - ("empty", "", ""), - ("normal", "Foo", "Foo"), - ] - for label, initial, expected_visible in scenarios: - page = await browser.new_page() - await page.goto("about:blank") - if initial: - await asyncio.wait_for( - page.evaluate("t => { document.title = t; }", initial), - FIXPOINT_BUDGET_S, - ) - # THE step that hangs today when `initial` is empty. - await asyncio.wait_for( - page.evaluate(scripts["install"]), FIXPOINT_BUDGET_S) - # The renderer must still be answering at all. - alive = await asyncio.wait_for( - page.evaluate("1 + 1"), FIXPOINT_BUDGET_S) - # Let any pending observer callbacks drain, then confirm the - # title has actually settled rather than merely being slow. - await asyncio.sleep(0.25) - first = await asyncio.wait_for( - page.evaluate( - "document.querySelector('title')" - " ? document.querySelector('title').textContent : null"), - FIXPOINT_BUDGET_S) - await asyncio.sleep(0.25) - second = await asyncio.wait_for( - page.evaluate( - "document.querySelector('title')" - " ? document.querySelector('title').textContent : null"), - FIXPOINT_BUDGET_S) - visible = await asyncio.wait_for( - page.evaluate("document.title"), FIXPOINT_BUDGET_S) - # The page setting its own empty title must not restart the loop. - await asyncio.wait_for( - page.evaluate("document.title = ''"), FIXPOINT_BUDGET_S) - await asyncio.sleep(0.25) - after_self_clear = await asyncio.wait_for( - page.evaluate("1 + 1"), FIXPOINT_BUDGET_S) - report[label] = { - "alive": alive, - "raw_first": first, - "raw_second": second, - "visible": visible, - "expected_visible": expected_visible, - "after_self_clear": after_self_clear, - } - await page.close() - finally: - await browser.close() - return report - - -def test_marker_script_reaches_a_fixpoint(cft_binary): - """The marker must be a fixpoint under the DOM's own title normalization. - - Write the marked title, read it back through the native getter, and the two - must agree -- otherwise the observer rewrites forever. Asserted on the real - script text from `chrome-extension/background.js`, in a real renderer. - """ - try: - import playwright.async_api # noqa: F401 - except ImportError: # pragma: no cover - pytest.skip("playwright not installed") - - try: - report = asyncio.run(_fixpoint_probe(cft_binary)) - except asyncio.TimeoutError as e: # pragma: no cover - this IS the bug - raise AssertionError( - "the renderer stopped answering after the tab marker was " - "installed — this is the title-rewrite loop, i.e. the freeze" - ) from e - - for label, r in report.items(): - assert r["alive"] == 2, f"[{label}] renderer not responsive: {r}" - assert r["after_self_clear"] == 2, ( - f"[{label}] renderer wedged after the page set an empty title " - f"through the marker's own setter: {r}" - ) - assert r["raw_first"] == r["raw_second"], ( - f"[{label}] the rawChanged
{child}".encode() + self.send_response(200) + self.send_header("Content-Type", "text/html") + self.send_header("Content-Length", str(len(body))) + self.end_headers() + self.wfile.write(body) + + def log_message(self, *args): + pass + + server = ThreadingHTTPServer(("127.0.0.1", 0), Handler) + thread = threading.Thread(target=server.serve_forever, daemon=True) + thread.start() + try: + yield f"http://127.0.0.1:{server.server_port}" + finally: + server.shutdown() + server.server_close() + thread.join(timeout=2) + + +def test_console_subscription_is_opt_in_and_contexts_survive_navigation( + e2e_daemon, ext_ready, e2e_artifacts_dir, context_site, +): + pytest.importorskip("playwright.sync_api") + sid = f"e2e-console-{uuid.uuid4().hex}" + seed_ledger_session(bs_home("extension"), sid, backend="extension", name="console") + artifact = e2e_artifacts_dir / "runtime-console-cost.json" + artifact.unlink(missing_ok=True) + script = f"artifact_path = {str(artifact)!r}\nsite = {context_site!r}\n" + ''' +import json +from pathlib import Path +page.goto(site) +page.evaluate('window.fixtureValue = 41') +assert page.evaluate('fixtureValue + 1') == 42 +measure = """() => { + const rows = Array.from({length: 30000}, (_, i) => ({a:i, b:i+1, c:i+2, d:i+3})); + const samples = []; + for (let i=0; i<3; i++) { + const start = performance.now(); + console.table(rows); + samples.push(performance.now() - start); + } + return samples.sort((a,b) => a-b)[1]; +}""" +result = {'default_ms': page.evaluate(measure)} +cdp = context.new_cdp_session(page) +cdp.send('Runtime.disable') +result['disabled_ms'] = page.evaluate(measure) +cdp.send('Runtime.enable') +result['enabled_ms'] = page.evaluate(measure) +cdp.send('Runtime.disable') +cdp.detach() +Path(artifact_path).write_text(json.dumps(result, indent=2) + '\\n') +page.goto(site + '/next') +result['after_navigation'] = page.evaluate('({title:document.title, previous:typeof fixtureValue})') +page.set_content('setcontent works
') +result['set_content'] = page.locator('body').inner_text() +assert result['set_content'] == 'setcontent works', result +page.goto(site + '/frame') +frame = page.frames[1] +frame.wait_for_load_state() +result['child_context'] = frame.evaluate('document.body.innerText') +assert result['child_context'] == 'Child context' +assert page.get_by_text('Changed', exact=True).count() == 1 +Path(artifact_path).write_text(json.dumps(result, indent=2) + '\\n') +print('CONSOLE_CONTEXTS_OK') +''' + try: + execution = run_skill(script, backend="extension", runtime_dir=e2e_daemon.runtime_dir, + extra_env={"BD_SESSION": sid}, timeout=90) + evidence = {"returncode": execution.returncode, "stdout": execution.stdout, + "stderr": execution.stderr} + if artifact.exists(): + evidence["observations"] = json.loads(artifact.read_text()) + artifact.write_text(json.dumps(evidence, indent=2) + "\n") + assert execution.returncode == 0, evidence + result = evidence["observations"] + assert result["after_navigation"] == {"title": "Next context", "previous": "undefined"} + assert result["default_ms"] <= result["disabled_ms"] * 3 + 12, result + assert result["enabled_ms"] > result["disabled_ms"] + 5, result + reset_result = run_skill("reset()", backend="extension", runtime_dir=e2e_daemon.runtime_dir, + extra_env={"BD_SESSION": sid}, timeout=30) + assert reset_result.returncode == 0, reset_result.stderr + rebound = run_skill("assert page.frames[1].evaluate('document.body.innerText') == 'Child context'\n" + "assert page.evaluate('typeof fixtureValue') == 'undefined'\nprint('REBOUND_OK')", + backend="extension", runtime_dir=e2e_daemon.runtime_dir, + extra_env={"BD_SESSION": sid}, timeout=45) + evidence["rebind"] = {"returncode": rebound.returncode, "stdout": rebound.stdout, + "stderr": rebound.stderr} + artifact.write_text(json.dumps(evidence, indent=2) + "\n") + assert rebound.returncode == 0, evidence + finally: + drop_ledger_session(bs_home("extension"), sid) diff --git a/tests/daemon/e2e/test_screenshot_caret.py b/tests/daemon/e2e/test_screenshot_caret.py new file mode 100644 index 0000000..66bd3d2 --- /dev/null +++ b/tests/daemon/e2e/test_screenshot_caret.py @@ -0,0 +1,126 @@ +"""Screenshot defaults preserve page caret styling, observed by page code. + +Repeat with ``uv run pytest tests/daemon/e2e/test_screenshot_caret.py -v``. +The JSON artifact records shared-DOM mutations and the PNG/JPEG files verify +the native screenshot return value, path handling, and clipping behavior. +""" +from __future__ import annotations + +import json +import textwrap +import uuid + +import pytest + +from .helpers import bs_home, drop_ledger_session, run_skill, seed_ledger_session + + +@pytest.fixture +def e2e_chrome(extension_only_chrome): + return extension_only_chrome + + +@pytest.mark.parametrize("extension_only_chrome", ["headless"], indirect=True) +def test_screenshot_defaults_preserve_caret_and_explicit_options( + e2e_daemon, e2e_chrome, ext_ready, e2e_artifacts_dir, +): + pytest.importorskip("playwright.sync_api") + assert not (e2e_chrome.profile_path / "DevToolsActivePort").exists() + sid = f"e2e-caret-{uuid.uuid4().hex}" + seed_ledger_session(bs_home("extension"), sid, backend="extension", name="caret") + artifact = e2e_artifacts_dir / "screenshot-caret.json" + artifact.unlink(missing_ok=True) + script = f"artifact_dir = {str(e2e_artifacts_dir)!r}\n" + textwrap.dedent(''' + import json + import struct + from pathlib import Path + page.set_content(""" + + + +Editable
+
+
+ """)
+ initial = page.evaluate('readCaretStyles()')
+ result = {'initial': initial, 'cases': {}}
+ def capture(name, take):
+ page.evaluate('styleMutations.splice(0)')
+ data = take()
+ page.wait_for_timeout(50)
+ result['cases'][name] = {
+ 'styles': page.evaluate('readCaretStyles()'),
+ 'mutations': page.evaluate('styleMutations.splice(0)'),
+ 'bytes': len(data), 'png': data.startswith(b'\\x89PNG\\r\\n\\x1a\\n'),
+ }
+ return data
+ directory = Path(artifact_dir)
+ page_path = directory / 'caret-page.png'
+ data = capture('page_default', lambda: page.screenshot(path=page_path))
+ result['page_file_equals_return'] = page_path.read_bytes() == data
+ capture('page_none', lambda: page.screenshot(caret=None))
+ capture('locator_default', lambda: page.locator('#field').screenshot())
+ handle = page.locator('#field').element_handle()
+ capture('handle_default', lambda: handle.screenshot())
+ handle.dispose()
+ clip = capture('page_clip_initial', lambda: page.screenshot(
+ caret='initial', clip={'x':0, 'y':0, 'width':160, 'height':100}, scale='css'))
+ result['clip_dimensions'] = list(struct.unpack('>II', clip[16:24]))
+ jpeg_path = directory / 'caret-page.jpg'
+ jpeg = capture('page_jpeg_initial', lambda: page.screenshot(
+ path=jpeg_path, caret='initial', quality=65))
+ result['jpeg_magic'] = jpeg.startswith(b'\\xff\\xd8\\xff')
+ result['jpeg_file_equals_return'] = jpeg_path.read_bytes() == jpeg
+ capture('page_explicit_hide', lambda: page.screenshot(caret='hide'))
+ capture('locator_explicit_hide', lambda: page.locator('#field').screenshot(caret='hide'))
+ (directory / 'screenshot-caret.json').write_text(json.dumps(result, indent=2) + '\\n')
+ print('SCREENSHOT_CARET_OK')
+ ''')
+ try:
+ execution = run_skill(script, backend="extension", runtime_dir=e2e_daemon.runtime_dir,
+ extra_env={"BD_SESSION": sid}, timeout=90)
+ evidence = {"returncode": execution.returncode, "stdout": execution.stdout,
+ "stderr": execution.stderr}
+ if artifact.exists():
+ evidence["observations"] = json.loads(artifact.read_text())
+ artifact.write_text(json.dumps(evidence, indent=2) + "\n")
+ assert execution.returncode == 0, evidence
+ result = evidence["observations"]
+ for name in ("page_default", "page_none", "locator_default", "handle_default",
+ "page_clip_initial", "page_jpeg_initial"):
+ case = result["cases"][name]
+ assert case["mutations"] == [], (name, case)
+ assert case["styles"] == result["initial"], (name, case)
+ assert case["bytes"] > 100, (name, case)
+ if name != "page_jpeg_initial":
+ assert case["png"] is True, (name, case)
+ for name in ("page_explicit_hide", "locator_explicit_hide"):
+ case = result["cases"][name]
+ assert any("transparent" in (mutation["before"] or "")
+ for mutation in case["mutations"]), (name, case)
+ # Native CSSOM restoration normalizes inline declaration spacing.
+ # Its explicit hiding must restore the original computed colors.
+ assert [style['computed'] for style in case['styles']] == [
+ style['computed'] for style in result['initial']], (name, case)
+ assert result["page_file_equals_return"] is True, result
+ assert result["jpeg_file_equals_return"] is True, result
+ assert result["jpeg_magic"] is True, result
+ assert result["clip_dimensions"] == [160, 100], result
+ finally:
+ drop_ledger_session(bs_home("extension"), sid)
diff --git a/tests/daemon/test_extension_debugger_timeout_unit.py b/tests/daemon/test_extension_debugger_timeout_unit.py
index 8b6d84f..d9b7731 100644
--- a/tests/daemon/test_extension_debugger_timeout_unit.py
+++ b/tests/daemon/test_extension_debugger_timeout_unit.py
@@ -216,7 +216,7 @@ def _run_attach_timeout_probe(payload: dict[str, str], *,
const PROTOCOL_VERSION = "1.3";
const attachedTabs = new Set();
function stripMarker(t) { return t || ""; }
- async function unmarkTabBeforeDetach() {}
+ async function updateTabAttachmentIndicator() {}
async function postAttachCosmetics() {}
async function announceAttached() {}
${wrapper}
@@ -297,7 +297,7 @@ def _run_detach_timeout_probe(payload: dict[str, str]) -> dict[str, object]:
vm.runInContext(`
const PROTOCOL_VERSION = "1.3";
const attachedTabs = new Set([17]);
- async function unmarkTabBeforeDetach() {}
+ async function updateTabAttachmentIndicator() {}
${wrapper}
${input.detachTab}
${input.doDetach}
@@ -433,7 +433,7 @@ def _run_epoch_abandon_probe(payload: dict[str, str]) -> dict[str, object]:
vm.runInContext(`
const PROTOCOL_VERSION = "1.3";
const attachedTabs = new Set();
- async function unmarkTabBeforeDetach() {}
+ async function updateTabAttachmentIndicator() {}
async function announceAttached(tabId) { announced.push(tabId); }
${wrapper}
${input.attachTab}
diff --git a/tests/daemon/test_extension_title_marker_unit.py b/tests/daemon/test_extension_title_marker_unit.py
deleted file mode 100644
index 47c9ada..0000000
--- a/tests/daemon/test_extension_title_marker_unit.py
+++ /dev/null
@@ -1,1060 +0,0 @@
-"""Unit checks for the extension title marker snippets.
-
-The tests extract only the marker helpers/scripts from
-``chrome-extension/background.js`` and run them in Node with a tiny DOM stub.
-They do not load the extension runtime or launch Chrome.
-"""
-from __future__ import annotations
-
-import json
-import re
-import subprocess
-from pathlib import Path
-
-
-ROOT = Path(__file__).resolve().parents[2]
-BACKGROUND_JS = ROOT / "chrome-extension" / "background.js"
-PREFIX = "\U0001f440 "
-
-
-def _template_const(source: str, name: str) -> str:
- # The marker scripts are assembled from shared source fragments
- # (MARKER_STRIP_PREFIX_SRC / MARKER_RAW_TITLE_SRC in background.js), so
- # evaluate the whole const region in Node instead of regex-slicing a
- # single template literal.
- start = source.index("const MARKER_STRIP_PREFIX_SRC")
- end = source.index("const markedTabs")
- snippet = source[start:end]
- proc = subprocess.run(
- ["node"],
- input=f"{snippet}\nprocess.stdout.write(JSON.stringify({name}));",
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _function_decl(source: str, name: str) -> str:
- match = re.search(
- rf"function {name}\([^)]*\) \{{(?P.*?)\n\}}",
- source,
- re.DOTALL,
- )
- assert match is not None, f"{name} function not found"
- return match.group(0)
-
-
-def _marker_sources() -> dict[str, str]:
- source = BACKGROUND_JS.read_text(encoding="utf-8")
- return {
- "installScript": _template_const(source, "MARKER_INSTALL_SCRIPT"),
- "removeScript": _template_const(source, "MARKER_REMOVE_SCRIPT"),
- "stripMarker": _function_decl(source, "stripMarker"),
- }
-
-
-def _service_worker_marker_sources() -> dict[str, str]:
- """Extract the real SW marker lifecycle without loading the extension."""
- source = BACKGROUND_JS.read_text(encoding="utf-8")
- marker_start = source.index("const markedTabs")
- marker_end = source.index("// ---- chrome.debugger event fan-out", marker_start)
- detach_start = source.index("async function detachTab(")
- detach_end = source.index("\n\nasync function doAttach(", detach_start)
- handler_start = source.index("async function handleDaemonMessage(")
- handler_end = source.index("// Shared attach sequence", handler_start)
- close_start = source.index("async function doCloseTab(")
- close_end = source.index("\n\nasync function doDetach(", close_start)
- # The bounded chrome.debugger wrapper region (issue #31): detachTab and
- # doCloseTab route their chrome.debugger calls through it, so the probes
- # that run those handlers need it injected too.
- wrapper_start = source.index("// ---- bounded chrome.debugger calls")
- wrapper_end = source.index("// Shared attach sequence:", wrapper_start)
- return {
- **_marker_sources(),
- "wrapperRegion": source[wrapper_start:wrapper_end],
- "workerMarkerRegion": source[marker_start:marker_end],
- "detachTab": source[detach_start:detach_end],
- "handleDaemonMessage": source[handler_start:handler_end],
- "doCloseTab": source[close_start:close_end],
- }
-
-
-def _run_marker_detach_budget_probe(
- payload: dict[str, str], hang_stage: str,
-) -> dict[str, object]:
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const calls = [];
-const chrome = {
- debugger: {
- async sendCommand(target, method, params) {
- calls.push({ kind: "command", method, params });
- const stage = method === "Runtime.evaluate"
- ? (params.expression === input.installScript ? "installEvaluate" : "removeEvaluate")
- : method;
- if (stage === input.hangStage) return await new Promise(() => {});
- if (method === "Page.addScriptToEvaluateOnNewDocument") {
- return { identifier: "marker-script" };
- }
- return {};
- },
- async detach(target) {
- calls.push({ kind: "detach", tabId: target.tabId });
- },
- },
-};
-const realm = vm.createContext({
- chrome,
- sleep: (ms) => new Promise((resolve) => setTimeout(resolve, ms)),
- setTimeout,
- clearTimeout,
- console: { info() {}, warn() {}, error: console.error },
-});
-const markerRegion = input.workerMarkerRegion
- .replace("const MARKER_INSTALL_TIMEOUT_MS = 1500;",
- "const MARKER_INSTALL_TIMEOUT_MS = 10;")
- .replace("const MARKER_REMOVE_TIMEOUT_MS = 1000;",
- "const MARKER_REMOVE_TIMEOUT_MS = 10;");
-vm.runInContext(`
- const TITLE_PREFIX = "\\u{1F440} ";
- const MARKER_INSTALL_SCRIPT = ${JSON.stringify(input.installScript)};
- const MARKER_REMOVE_SCRIPT = ${JSON.stringify(input.removeScript)};
- const PROTOCOL_VERSION = "1.3";
- const attachedTabs = new Set([17]);
- function safeSend() {}
- ${input.wrapperRegion}
- ${markerRegion}
- ${input.detachTab}
-`, realm);
-
-(async () => {
- if (["Page.enable", "Page.addScriptToEvaluateOnNewDocument", "installEvaluate"]
- .includes(input.hangStage)) {
- vm.runInContext("markTabAttached(17)", realm);
- while (calls.length === 0 ||
- (input.hangStage === "Page.addScriptToEvaluateOnNewDocument" && calls.length < 2) ||
- (input.hangStage === "installEvaluate" && calls.length < 3)) {
- await new Promise((resolve) => setTimeout(resolve, 0));
- }
- } else {
- vm.runInContext('markedTabs.set(17, "marker-script")', realm);
- }
- const completed = await Promise.race([
- vm.runInContext("detachTab(17)", realm).then(() => true),
- new Promise((resolve) => setTimeout(() => resolve(false), 100)),
- ]);
- process.stdout.write(JSON.stringify({
- completed,
- attached: vm.runInContext("attachedTabs.has(17)", realm),
- calls,
- }));
-})().catch((error) => {
- console.error(error);
- process.exitCode = 1;
-});
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps({**payload, "hangStage": hang_stage}),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _run_marker_late_completion_probe(
- payload: dict[str, str], late_stage: str,
-) -> dict[str, object]:
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const calls = [];
-let releaseLate;
-const lateGate = new Promise((resolve) => { releaseLate = resolve; });
-let commandQueue = Promise.resolve();
-let pageMarked = false;
-
-function stageFor(method, params) {
- if (method !== "Runtime.evaluate") return method;
- return params.expression === input.installScript
- ? "installEvaluate" : "removeEvaluate";
-}
-
-const chrome = {
- debugger: {
- sendCommand(target, method, params) {
- const stage = stageFor(method, params);
- calls.push({ kind: "command", stage, method });
- const run = async () => {
- if (stage === input.lateStage) await lateGate;
- if (stage === "installEvaluate") pageMarked = true;
- if (stage === "removeEvaluate") pageMarked = false;
- if (method === "Page.addScriptToEvaluateOnNewDocument") {
- return { identifier: "marker-script" };
- }
- return {};
- };
- const result = commandQueue.then(run);
- commandQueue = result.catch(() => {});
- return result;
- },
- async detach(target) {
- calls.push({ kind: "detach", tabId: target.tabId });
- },
- },
-};
-const realm = vm.createContext({
- chrome,
- sleep: (ms) => new Promise((resolve) => setTimeout(resolve, ms)),
- setTimeout,
- clearTimeout,
- console: { info() {}, warn() {}, error: console.error },
-});
-const markerRegion = input.workerMarkerRegion
- .replace("const MARKER_INSTALL_TIMEOUT_MS = 1500;",
- "const MARKER_INSTALL_TIMEOUT_MS = 100;")
- .replace("const MARKER_REMOVE_TIMEOUT_MS = 1000;",
- "const MARKER_REMOVE_TIMEOUT_MS = 10;");
-vm.runInContext(`
- const TITLE_PREFIX = "\\u{1F440} ";
- const MARKER_INSTALL_SCRIPT = ${JSON.stringify(input.installScript)};
- const MARKER_REMOVE_SCRIPT = ${JSON.stringify(input.removeScript)};
- const PROTOCOL_VERSION = "1.3";
- const attachedTabs = new Set([17]);
- function safeSend() {}
- ${input.wrapperRegion}
- ${markerRegion}
- ${input.detachTab}
-`, realm);
-
-(async () => {
- const marking = vm.runInContext("markTabAttached(17)", realm);
- while (!calls.some((call) => call.stage === input.lateStage)) {
- await new Promise((resolve) => setTimeout(resolve, 0));
- }
- const detached = await vm.runInContext("detachTab(17)", realm);
- const detachIndex = calls.findIndex((call) => call.kind === "detach");
- releaseLate();
- await Promise.allSettled([marking, commandQueue]);
- await new Promise((resolve) => setTimeout(resolve, 0));
- await commandQueue;
- process.stdout.write(JSON.stringify({
- calls,
- detachIndex,
- pageMarked,
- marked: vm.runInContext("markedTabs.has(17)", realm),
- marking: vm.runInContext("markingTabs.has(17)", realm),
- }));
-})().catch((error) => {
- console.error(error);
- process.exitCode = 1;
-});
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps({**payload, "lateStage": late_stage}),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _run_failed_close_marker_probe(payload: dict[str, str]) -> dict[str, object]:
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const calls = [];
-const attachedTabs = new Set([17]);
-const markedTabs = new Map([[17, "marker-script"]]);
-const chrome = {
- debugger: {
- async detach() { calls.push({ kind: "detach" }); },
- },
- tabs: {
- async remove() { calls.push({ kind: "remove" }); throw new Error("close denied"); },
- },
- storage: {
- session: {
- async get() { return {}; },
- async set(value) { calls.push({ kind: "storageSet", value }); },
- },
- },
-};
-function errMessage(error) { return String(error.message || error); }
-function safeSend(message) { calls.push({ kind: "response", message }); }
-const realm = vm.createContext({
- chrome, console, errMessage, safeSend,
- attachedTabs, markedTabs,
-});
-vm.runInContext(input.wrapperRegion, realm);
-vm.runInContext(input.doCloseTab, realm);
-(async () => {
- await vm.runInContext("doCloseTab(9, 17)", realm);
- process.stdout.write(JSON.stringify({
- attached: attachedTabs.has(17),
- marked: markedTabs.has(17),
- calls,
- }));
-})().catch((error) => {
- console.error(error);
- process.exitCode = 1;
-});
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps(payload),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _run_service_worker_realm_rebuild_probe(payload: dict[str, str]) -> dict:
- """Mark in one SW realm, then detach through a fresh realm.
-
- The page sandbox deliberately survives the service-worker sandbox. This is
- the upgrade/reload shape: extension globals are rebuilt while the old tab's
- injected accessor, observer, and visible title marker remain live.
- """
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const EYE = "\u{1F440}";
-
-class Document {}
-Object.defineProperty(Document.prototype, "title", {
- configurable: true,
- enumerable: true,
- get() { return this._rawTitle || ""; },
- set(value) { this._rawTitle = String(value); },
-});
-class MutationObserver {
- constructor(callback) {
- this.callback = callback;
- this.disconnected = false;
- }
- observe() { this.callback(); }
- disconnect() { this.disconnected = true; }
-}
-
-const document = new Document();
-document._rawTitle = `${EYE} Legacy`;
-document.head = { appendChild() {} };
-document.querySelector = () => null;
-document.createElement = () => ({ textContent: "" });
-document.addEventListener = () => {};
-const page = vm.createContext({
- window: {}, document, Document, HTMLDocument: Document, MutationObserver,
-});
-
-const calls = [];
-const chrome = {
- debugger: {
- async sendCommand(target, method, params) {
- calls.push({ kind: "command", method, params });
- if (method === "Page.addScriptToEvaluateOnNewDocument") {
- return { identifier: "old-realm-script" };
- }
- if (method === "Runtime.evaluate") {
- vm.runInContext(params.expression, page);
- }
- return {};
- },
- async detach(target) {
- calls.push({ kind: "detach", tabId: target.tabId });
- },
- },
-};
-
-function newWorkerRealm(attached) {
- const realm = vm.createContext({
- chrome, console, setTimeout, clearTimeout, sleep: async () => {},
- });
- vm.runInContext(`
- const TITLE_PREFIX = "\\u{1F440} ";
- const MARKER_INSTALL_SCRIPT = ${JSON.stringify(input.installScript)};
- const MARKER_REMOVE_SCRIPT = ${JSON.stringify(input.removeScript)};
- const PROTOCOL_VERSION = "1.3";
- ${input.wrapperRegion}
- ${input.workerMarkerRegion}
- const attachedTabs = new Set(${attached ? "[17]" : "[]"});
- function safeSend() {}
- ${input.detachTab}
- `, realm);
- return realm;
-}
-
-(async () => {
- const firstRealm = newWorkerRealm(true);
- await vm.runInContext("markTabAttached(17)", firstRealm);
- const titleAfterMark = document._rawTitle;
-
- // A service-worker update/reload rebuilds all extension globals. The page
- // and its injected marker survive, but markedTabs is now an empty Map.
- const secondRealm = newWorkerRealm(false);
- await vm.runInContext("detachTab(17)", secondRealm);
-
- process.stdout.write(JSON.stringify({
- titleAfterMark,
- titleAfterDetach: document._rawTitle,
- markerAfterDetach: !!page.window.__bdTitleMarker,
- callsAfterRealmRebuild: calls.slice(3),
- }));
-})().catch((error) => {
- console.error(error);
- process.exitCode = 1;
-});
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps(payload),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _run_controlled_reload_probe(payload: dict[str, object]) -> list[dict]:
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const calls = [];
-const chrome = {
- debugger: {
- async sendCommand(target, method, params) {
- calls.push({ kind: "command", tabId: target.tabId, method, params });
- if (method === "Page.addScriptToEvaluateOnNewDocument") {
- if (input.markInFlight) {
- await new Promise((resolve) => setTimeout(resolve, 0));
- }
- return { identifier: "known-script" };
- }
- if (input.failRemove &&
- method === "Page.removeScriptToEvaluateOnNewDocument") {
- throw new Error("registration already gone");
- }
- if (input.hangRemove && method === "Runtime.evaluate" &&
- params.expression === input.removeScript) {
- return await new Promise(() => {});
- }
- return {};
- },
- },
- runtime: {
- reload() { calls.push({ kind: "reload" }); },
- },
-};
-const realm = vm.createContext({
- chrome,
- sleep: (ms) => new Promise((resolve) => setTimeout(resolve, ms)),
- setTimeout,
- clearTimeout,
- console: { info() {}, warn() {}, error: console.error },
-});
-vm.runInContext(`
- const daemonVersion = "test";
- const TITLE_PREFIX = "\\u{1F440} ";
- const MARKER_INSTALL_SCRIPT = ${JSON.stringify(input.installScript)};
- const MARKER_REMOVE_SCRIPT = ${JSON.stringify(input.removeScript)};
- const attachedTabs = new Set([17]);
- ${input.workerMarkerRegion.replace(
- "const MARKER_RELOAD_CLEANUP_TIMEOUT_MS = 1500;",
- "const MARKER_RELOAD_CLEANUP_TIMEOUT_MS = 10;",
- )}
- ${input.handleDaemonMessage}
-`, realm);
-(async () => {
- let marking = null;
- if (input.markInFlight) {
- marking = vm.runInContext("markTabAttached(17)", realm);
- } else {
- vm.runInContext('markedTabs.set(17, "known-script")', realm);
- }
- await vm.runInContext(
- 'handleDaemonMessage({type: "reloadExtension", reason: "test"})',
- realm,
- );
- if (marking) await marking;
- process.stdout.write(JSON.stringify(calls));
-})().catch((error) => {
- console.error(error);
- process.exitCode = 1;
-});
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps(payload),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-def _run_node_probe(payload: dict[str, str]) -> dict[str, object]:
- probe = r"""
-const vm = require("node:vm");
-const input = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
-const PREFIX = "\u{1F440} ";
-const EYE = "\u{1F440}";
-const NBSP = "\u00A0";
-const NARROW_NBSP = "\u202F";
-
-function runMarkerScript(script, initialTitle) {
- class Document {}
- Object.defineProperty(Document.prototype, "title", {
- configurable: true,
- enumerable: true,
- get() {
- return this._rawTitle || "";
- },
- set(value) {
- this._rawTitle = String(value);
- },
- });
-
- class MutationObserver {
- constructor(callback) {
- this.callback = callback;
- this.disconnected = false;
- }
- observe() {
- this.callback();
- }
- disconnect() {
- this.disconnected = true;
- }
- }
-
- const document = new Document();
- document._rawTitle = initialTitle;
- document.head = { appendChild() {} };
- document.querySelector = () => null;
- document.createElement = () => ({ textContent: "" });
- document.addEventListener = () => {};
-
- const sandbox = {
- window: {},
- document,
- Document,
- HTMLDocument: Document,
- MutationObserver,
- };
- vm.runInNewContext(script, sandbox);
- return { sandbox, document };
-}
-
-vm.runInThisContext(
- `const TITLE_PREFIX = ${JSON.stringify(PREFIX)};\n${input.stripMarker}`,
-);
-
-const duplicateInstall = runMarkerScript(
- input.installScript,
- `${PREFIX}${PREFIX}Example`,
-);
-const cleanInstall = runMarkerScript(input.installScript, "Example");
-const bareEyeInstall = runMarkerScript(input.installScript, `${EYE}Hello`);
-const nbspEyeInstall = runMarkerScript(input.installScript, `${EYE}${NBSP}Hello`);
-const narrowEyeInstall = runMarkerScript(
- input.installScript,
- `${EYE}${NARROW_NBSP}Hello`,
-);
-const setterProbe = runMarkerScript(input.installScript, "Example");
-setterProbe.document.title = `${PREFIX}${PREFIX}Next`;
-const bareEyeSetter = runMarkerScript(input.installScript, "Example");
-bareEyeSetter.document.title = `${EYE}World`;
-const nonStringSetter = runMarkerScript(input.installScript, "Example");
-nonStringSetter.document.title = 42;
-const duplicateRemove = runMarkerScript(
- input.removeScript,
- `${PREFIX}${PREFIX}${PREFIX}Example`,
-);
-const bareEyeRemove = runMarkerScript(input.removeScript, `${EYE}Hello`);
-const nbspEyeRemove = runMarkerScript(input.removeScript, `${EYE}${NBSP}Hello`);
-const lifecycle = runMarkerScript(input.installScript, `${PREFIX}${PREFIX}Example`);
-lifecycle.document.title = `${EYE}${NBSP}Mid`;
-vm.runInNewContext(input.removeScript, lifecycle.sandbox);
-lifecycle.document.title = "After";
-
-process.stdout.write(JSON.stringify({
- stripSamples: [
- stripMarker(`${PREFIX}${PREFIX}Example`),
- stripMarker(`${PREFIX}${PREFIX}${PREFIX}`),
- stripMarker("Plain"),
- stripMarker(null),
- stripMarker(`${EYE}Hello`),
- stripMarker(`${EYE} Hello`),
- stripMarker(`${EYE}${NBSP}Hello`),
- stripMarker(`${EYE}${NARROW_NBSP}Hello`),
- stripMarker(`${EYE}${EYE}Hello`),
- stripMarker(`${PREFIX}${EYE}Hello`),
- stripMarker(42),
- stripMarker(undefined),
- stripMarker(true),
- ],
- duplicateInstallTitle: {
- rawTitle: duplicateInstall.document._rawTitle,
- pageTitle: duplicateInstall.document.title,
- },
- cleanInstallTitle: {
- rawTitle: cleanInstall.document._rawTitle,
- pageTitle: cleanInstall.document.title,
- },
- bareEyeInstallTitle: {
- rawTitle: bareEyeInstall.document._rawTitle,
- pageTitle: bareEyeInstall.document.title,
- },
- nbspEyeInstallTitle: {
- rawTitle: nbspEyeInstall.document._rawTitle,
- pageTitle: nbspEyeInstall.document.title,
- },
- narrowEyeInstallTitle: {
- rawTitle: narrowEyeInstall.document._rawTitle,
- pageTitle: narrowEyeInstall.document.title,
- },
- setterTitle: {
- rawTitle: setterProbe.document._rawTitle,
- pageTitle: setterProbe.document.title,
- },
- bareEyeSetterTitle: {
- rawTitle: bareEyeSetter.document._rawTitle,
- pageTitle: bareEyeSetter.document.title,
- },
- nonStringSetterTitle: {
- rawTitle: nonStringSetter.document._rawTitle,
- pageTitle: nonStringSetter.document.title,
- stripped: stripMarker(nonStringSetter.document._rawTitle),
- },
- duplicateRemoveTitle: {
- rawTitle: duplicateRemove.document._rawTitle,
- pageTitle: duplicateRemove.document.title,
- },
- bareEyeRemoveTitle: {
- rawTitle: bareEyeRemove.document._rawTitle,
- pageTitle: bareEyeRemove.document.title,
- },
- nbspEyeRemoveTitle: {
- rawTitle: nbspEyeRemove.document._rawTitle,
- pageTitle: nbspEyeRemove.document.title,
- },
- lifecycleTitle: {
- rawTitle: lifecycle.document._rawTitle,
- pageTitle: lifecycle.document.title,
- },
-}));
-"""
- proc = subprocess.run(
- ["node", "-e", probe],
- input=json.dumps(payload),
- text=True,
- capture_output=True,
- check=True,
- timeout=5,
- cwd=ROOT,
- )
- return json.loads(proc.stdout)
-
-
-#: How many raw title writes the marker is allowed before we call it a loop.
-#: Settling costs one write; a second is slack for a normalization round-trip.
-WRITE_BUDGET = 4
-
-#: How many observer callbacks may be delivered before we call it a loop.
-CALLBACK_BUDGET = 20
-
-
-def _run_fixpoint_probe(payload: dict[str, str]) -> dict[str, object]:
- """Re-run the install script against a *spec-accurate* `document.title`.
-
- The DOM stub used by the probe above returns whatever was written, which is
- not what a browser does: per HTML, the `document.title` getter strips
- leading/trailing ASCII whitespace and collapses internal runs. That
- difference is the entire bug. The marker's prefix ends in a space, so on a
- page with an empty title it wrote `"