From e34ab0105a5272242f72605d808bf429a76bd013 Mon Sep 17 00:00:00 2001 From: dachrisch Date: Wed, 11 Nov 2026 22:04:17 +0100 Subject: [PATCH 1/2] fix(typecheck): keep the Remotion video project out of the root tsc run `video/field-notes-ai-agent-os` owns its package.json, package-lock and tsconfig (include: src, remotion.config.ts) and is deliberately not part of the Astro build. The root tsconfig never excluded it, so `tsc --noEmit` walked into it and reported 19 x TS2307 "Cannot find module 'remotion'" on any PR that triggers the test workflow, because those deps are only installed inside video/. The last src-touching PR predates the video commit, so the breakage stayed invisible until now. Excluding video/ (and dist/, node_modules/) restores `npm run typecheck` to clean without installing a second dependency tree in CI. --- tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/tsconfig.json b/tsconfig.json index d61ec2c9..8ebf88de 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,5 +1,6 @@ { "extends": "astro/tsconfigs/strict", + "exclude": ["video", "dist", "node_modules"], "contentMappers": [ { "package": "@astrojs/ts-content-mapper", From cfdbf2e14095c7b91815667ba5a297b250fc03de Mon Sep 17 00:00:00 2001 From: dachrisch Date: Wed, 11 Nov 2026 22:08:57 +0100 Subject: [PATCH 2/2] ci(build): run the build on tsconfig.json changes The type-check step is only trustworthy if a tsconfig change is actually exercised. tsconfig.json was missing from both path filters, so a PR that touched nothing else got no checks at all and could not satisfy the required status check. --- .github/workflows/astro-build-deploy.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/astro-build-deploy.yml b/.github/workflows/astro-build-deploy.yml index e32eca91..749fbd27 100644 --- a/.github/workflows/astro-build-deploy.yml +++ b/.github/workflows/astro-build-deploy.yml @@ -11,6 +11,7 @@ on: - 'public/**' - 'package*.json' - 'astro.config.mjs' + - 'tsconfig.json' - 'Dockerfile' - 'nginx.conf' - '.github/workflows/*.yml' @@ -22,6 +23,7 @@ on: - 'public/**' - 'package*.json' - 'astro.config.mjs' + - 'tsconfig.json' - 'Dockerfile' - 'nginx.conf' - '.github/workflows/*.yml'