Two test gaps: unverified prebuild `Info.plist` and a missing `.node` fixture in the Babel plugin tests

[kraenhansen]

Two TODOs marking tests that assert less than they appear to.

verify-prebuilds skips the Info.plist it just found

The verifier walks each framework in the XCFramework and `continue`s past `Info.plist` without reading it. That file is written by `writeFrameworkInfoPlist` in `packages/host/src/node/prebuilds/apple.ts` from the library name and bundle identifier, and a wrong `CFBundleExecutable` or `CFBundleIdentifier` is exactly the kind of failure that passes every build step and then fails at load time on device. Parsing it and asserting the executable name matches the library, and the identifier matches what was requested, is a handful of lines given `@expo/plist` is already a dependency.

## "does not touch required JS files" doesn't prove what it claims

The test fixture has my-addon.js and asserts the plugin does not emit requireNodeAddon. But with no my-addon.node in the fixture there is nothing for the plugin to have found in the first place — the assertion passes for the wrong reason, and would keep passing even if the plugin's precedence between a .js and a sibling addon were broken. Adding a ./my-addon.node alongside it, as the TODO says, is what makes the test meaningful: with both present, require('./my-addon') must still resolve to the JS file.

---

Current status (as of 2026-08-29)

Both gaps above are still present on next/main (the line ranges linked above are unchanged) — five attempts have been made, one still open:

• Close two test gaps: unverified prebuild Info.plist and a missing .node fixture #448, fix: verify prebuild Info.plist and prove the Babel plugin's .js/.node precedence (#424) #449 — independent first attempts, both closed in favor of Fix .js/.node precedence in isNodeApiModule; dedupe Info.plist checks (builds on #426) #450.
• Fix .js/.node precedence in isNodeApiModule; dedupe Info.plist checks (builds on #426) #450 — closed (superseded by pushing its refinements onto fix: verify native prebuild fixtures #426 directly instead).
• Verify prebuild metadata and JS addon precedence #455 — closed by its own author on 2026-08-28, in favor of fix: verify native prebuild fixtures #426 (confirmed fix: verify native prebuild fixtures #426 already covers the shared isNodeApiModule precedence fix, targets next, is mergeable, and has maintainer approval). Its standalone verifyFrameworkInfoPlist unit-test work remains available on commit 4bd6ab5e as a possible focused follow-up after fix: verify native prebuild fixtures #426 lands.
• fix: verify native prebuild fixtures #426 (open) — the only open PR left. Adds the .node fixture and fixes the real .js/.node precedence bug in the shared isNodeApiModule utility (also used by findNodeAddonForBindings, not just the Babel plugin's plain require() handling), plus zod-validated Info.plist verification reusing escapeBundleIdentifier. Targets next, mergeable state is clean, has maintainer approval and, as of its latest push (24 Aug), the maintainer's own follow-up refinements plus a tightened .js/.json-only shadowing rule (regression-tested against sibling .cjs/.mjs files).

Given the above, #426 is the path to closing this issue — it just needs a final maintainer review/merge; no competing implementation work is needed.

[huytdps13400]

Fix PR is open: #455.

Completing the Babel fixture exposed an actual precedence bug: require("./my-addon") was transformed to requireNodeAddon(...) even with my-addon.js beside my-addon.node. The PR now preserves Node JS/JSON resolution before addon rewriting.

It also parses generated framework plists, verifies executable and bundle ID, and adds three portable verifier tests to the root test gate. Local evidence: 10/10 focused Babel tests, 3/3 plist verifier tests, and 88/88 across the root test command.