endTracking() fails

[fsebbah]

Hi,
I have at the point 3.2 When the exercices are finished, in the workout-history-tracker.services, the function endTracking() fails because : this.currentWorkoutLog is null

If I log the finish function : there are a record:
finish this.currentWorkoutLog {"startedOn":"2018-07-11T12:23:11.776Z","completed":false,"exercicesDone":12,"lastExercise":"Side Plank"}

After te router [finish] is called but it seems the startExerciseTimeTracking is called again a second times on the window.setInterval and now the this.currentWorkoutLog = null

And it's not possible to get the route /finish.
To resolve this problem, I add if(this.currentWorkoutLog === null) return false.
And it works.
Thanks,
Franck

[chandermani]

HI Frank, I will check and confirm.

[chandermani]

I believe this happened because you pressed the browser back button and the code is not destroying the setInterval object in ngDestroy. Can you update the ngDestroy function to

ngOnDestroy() {
    if (this.exerciseTrackingInterval) clearInterval(this.exerciseTrackingInterval);
    this.tracker.endTracking(false);
  }

And try

[chandermani]

Added this check to repo too 0f0a130.

[Bigbhardwaj]

Even after applying ngDestroy() it still persists :

[bartduisters]

endTracking(completed: boolean) {
    if (this.currentWorkoutLog) {
      this.currentWorkoutLog.completed = completed;
      this.currentWorkoutLog.endedOn = new Date();
      this.currentWorkoutLog = null;
    }
    this.workoutTracked = false;
  }

The above code is a workaround so you can move on with the code/book. It seems that the endTracking gets called twice, the second time this.currentWorkoutLog is null -> throws the error.