From 5e08be5a79f15459fd18eb16d2acbbf6710640cc Mon Sep 17 00:00:00 2001 From: Christian Bager Bach Houmann Date: Wed, 14 Oct 2026 06:28:09 +0200 Subject: [PATCH 1/5] fix(ui): give the full player's keys to the PodNotes view's own scope The full player pushed a key scope above Obsidian's workspace scope, so while it was open a note never got Enter or Escape, as in its find bar. The player now registers Escape and Space on the PodNotes view's own scope. Obsidian hands a view's scope the keys typed while that view's leaf is active, which focus or a press in the view makes it. A menu or modal over the player still takes Escape first, and a queue drag still cancels on Escape. size: 98,781 gzip (-146 vs master 35461cd 98,927) --- src/ui/PodcastView/Player.svelte | 61 +++++-------------- .../PodcastView.integration.test.ts | 1 + src/ui/PodcastView/PodcastView.shell.test.ts | 49 +++++++++------ src/ui/PodcastView/context.ts | 4 +- src/ui/PodcastView/index.ts | 3 +- tests/e2e/journey-player.test.ts | 49 ++++++++++++++- tests/mocks/obsidian.ts | 13 +++- tests/mocks/services.ts | 6 +- 8 files changed, 113 insertions(+), 73 deletions(-) diff --git a/src/ui/PodcastView/Player.svelte b/src/ui/PodcastView/Player.svelte index 536db736..2d6d1d04 100644 --- a/src/ui/PodcastView/Player.svelte +++ b/src/ui/PodcastView/Player.svelte @@ -1,5 +1,4 @@