From 4627d37dfcaef586947fb3f13378180ef4af935f Mon Sep 17 00:00:00 2001 From: Noah Date: Sat, 7 Nov 2026 07:44:06 +0100 Subject: [PATCH 1/2] Fail CI on svelte-check warnings like the local build scripts/build.sh runs svelte-check with --fail-on-warnings, CI didn't, so a pull request could pass CI and then fail the release build. The CI header no longer claims it builds the whole binary. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yml | 6 +++--- AGENT.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c4c453e..2d930f2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ -# Every pull request: the server's tests and lints, the webui's checks, -# and a build of the whole binary. Not on pushes to main, there are many. +# Every pull request: the server's tests and lints, the webui's checks +# and its build. Not on pushes to main, there are many. name: ci on: @@ -27,7 +27,7 @@ jobs: run: | npm ci npx prettier --check src - npx svelte-check + npx svelte-check --fail-on-warnings npm run build - name: server working-directory: server diff --git a/AGENT.md b/AGENT.md index b057c44..237693f 100644 --- a/AGENT.md +++ b/AGENT.md @@ -47,5 +47,5 @@ Instructions for anyone (human or coding agent) changing this repository. - Nothing goes to `main` directly: every change is a branch and a pull request, reviewed (code and security) before it is squash merged. - The full checks, as CI runs them: in `webui/` `npm ci`, `npx prettier - --check src`, `npx svelte-check`, `npm run build`; in `server/` `cargo + --check src`, `npx svelte-check --fail-on-warnings`, `npm run build`; in `server/` `cargo fmt --check`, `cargo clippy -- -D warnings`, `cargo test`. From 654db2c8afcc5766f6274e6108c65c6f73412b0c Mon Sep 17 00:00:00 2001 From: Noah Date: Sat, 7 Nov 2026 07:46:47 +0100 Subject: [PATCH 2/2] Fail npm run check on warnings like CI Rewrap the checks line in AGENT.md, and add --fail-on-warnings to the webui check script so it rejects the same warnings as CI and build.sh. Co-Authored-By: Claude Opus 5.5 --- AGENT.md | 4 ++-- webui/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/AGENT.md b/AGENT.md index 237693f..6f9aaac 100644 --- a/AGENT.md +++ b/AGENT.md @@ -47,5 +47,5 @@ Instructions for anyone (human or coding agent) changing this repository. - Nothing goes to `main` directly: every change is a branch and a pull request, reviewed (code and security) before it is squash merged. - The full checks, as CI runs them: in `webui/` `npm ci`, `npx prettier - --check src`, `npx svelte-check --fail-on-warnings`, `npm run build`; in `server/` `cargo - fmt --check`, `cargo clippy -- -D warnings`, `cargo test`. + --check src`, `npx svelte-check --fail-on-warnings`, `npm run build`; in + `server/` `cargo fmt --check`, `cargo clippy -- -D warnings`, `cargo test`. diff --git a/webui/package.json b/webui/package.json index e4a91df..0e6aa57 100644 --- a/webui/package.json +++ b/webui/package.json @@ -7,7 +7,7 @@ "scripts": { "dev": "vite", "build": "vite build", - "check": "svelte-check --tsconfig ./tsconfig.json" + "check": "svelte-check --tsconfig ./tsconfig.json --fail-on-warnings" }, "devDependencies": { "@sveltejs/vite-plugin-svelte": "^5.0.0",