Repository navigation
fix(mosaic): keep sheet steady when moving between fields with the keyboard open - #10349
Draft
alexcarpenter wants to merge 4 commits into
Draft
alexcarpenter wants to merge 4 commits into
alexcarpenter wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 398b20c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
alexcarpenter
force-pushed
the
carp/mosaic-sheet-inputs
branch
2 times, most recently
from
October 22, 2026 12:08
35fe30b to
3b41144
Compare
…e scroll while it is up
maxyinger
approved these changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS, a Mosaic dialog shown as a bottom sheet jittered when moving between fields with the on-screen keyboard open. iOS runs its own "reveal" scroll on focus, which pans the page under the fixed sheet.
Following React Aria's
usePreventScroll, the dialog track now:preventScrollwhen focus moves between fields while the keyboard is up (taps and the keyboard's ▲▼ arrows), so iOS does not pan the pageBoth only act while a keyboard inset is measured, so desktop focus behavior is unchanged.
Also: when iOS pans the visual viewport down while the keyboard is up, the top of the sheet was left above the screen with nothing to scroll and the drag blocked. The pan is now published as
--_cl-keyboard-offsetand the track pads its top by it, so the whole dialog stays inside the visible band and scrolls within it.Two more fixes for content that grows while the keyboard is up (e.g. the password strength hint):
documentElement.clientHeight. On iOS that box is likely taller (not confirmed on device), which would make the inset too small and leave the actions behind the keyboard.DrawerVirtualKeyboardProvider), because WebKit's reveal scroll can move the page even while the scroll lock hides overflow.Tested manually on an iPhone (Safari) against swingset: moving between fields is noticeably steadier. Not yet confirmed on device: the keyboard ▲▼ arrows specifically, autofocus on open leaving Save reachable, the two fixes above, and Chrome on iOS.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change