Repository navigation
[Sandbox] Pin package versions and align wording - #34570
Closed
ghostwriternr wants to merge 4 commits into
Closed
ghostwriternr wants to merge 4 commits into
ghostwriternr wants to merge 4 commits into
Conversation
The line that copies sandbox-shim from the cloudflare/sandbox image is too wide for a code block on 14 pages, so readers scroll sideways to see the destination path. Break each COPY after the source image and indent the two paths, on every page at once so the line reads the same everywhere.
Pages outside Sandbox lifetime called each running container an instance and defined it at length as a Linux virtual machine that runs your image, which readers who know containers do not need. Say container, keep instance only on Sandbox lifetime where it tells one run from the next, and leave the virtual machine to the security concept and the local-versus-deployed note in get-started.
Six install steps added @cloudflare/sandbox without a version while the same pages copy sandbox-shim from the 1.0.1 image. The package and the helper must come from the same release, and an older helper rejects commands that a newer package sends, so the next release would break those pages. Install @cloudflare/sandbox@1.0.1 everywhere, matching the image, and say on the package reference why the version is exact and that both versions change together.
Three migration pages tell readers to copy step 1 of Run a server in the background into a file that already defines INACTIVITY_TIMEOUT_MS from Replace the Sandbox class, so the Worker failed to build with a redeclared constant. Tell readers to leave that constant out, as the background process page does.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://sandbox-audit-mechanical.previews.developers.cloudflare.com (commit f93d8f2)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
Contributor
|
@ghostwriternr This draft pull request has had no activity for 3 days. It will close after 7 days of inactivity. Transition to ready for review if ready. A codeowner can comment |
Contributor
|
@ghostwriternr Closing this draft pull request after 7 days of inactivity. Re-open at a later date and transition to ready for review when you are ready if you seek review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version pins and wording had drifted across the Sandbox pages.
@cloudflare/sandboxwithout a version, while the same pages copysandbox-shimfrom thecloudflare/sandbox:1.0.1image. The package and the helper must come from the same release, and an older helper rejects commands that a newer package sends. Every install step now pins@cloudflare/sandbox@1.0.1, and the package reference says why.INACTIVITY_TIMEOUT_MSa second time, so the Worker failed to compile. They now say to leave the constant out.sandbox-shimCOPYline is wrapped on all 14 pages.Documentation checklist