From d4e355f7c7ba75448fce5a7ce8c883a84ab1566a Mon Sep 17 00:00:00 2001 From: Arturo Reuschenbach Puncernau Date: Wed, 30 Sep 2026 21:49:13 +0200 Subject: [PATCH] chore(deps): upgrade js-yaml from 4.3.2 to 5.4.2 Signed-off-by: Arturo Reuschenbach Puncernau --- .changeset/upgrade-js-yaml.md | 10 ++++++++++ apps/greenhouse/package.json | 3 +-- .../components/admin/common/YamlViewer.tsx | 4 ++-- pnpm-lock.yaml | 20 +++++++++---------- 4 files changed, 23 insertions(+), 14 deletions(-) create mode 100644 .changeset/upgrade-js-yaml.md diff --git a/.changeset/upgrade-js-yaml.md b/.changeset/upgrade-js-yaml.md new file mode 100644 index 0000000000..244746be74 --- /dev/null +++ b/.changeset/upgrade-js-yaml.md @@ -0,0 +1,10 @@ +--- +"@cloudoperators/juno-app-greenhouse": patch +--- + +chore(deps): upgrade js-yaml from 4.3.2 to 5.4.2 + +- Upgrade js-yaml to v5.4.2 which includes built-in TypeScript types +- Remove @types/js-yaml dependency (no longer needed) +- Update import to use named export (dump) instead of default import +- All tests and type checks pass diff --git a/apps/greenhouse/package.json b/apps/greenhouse/package.json index 3b6c50a811..edbd2ee009 100644 --- a/apps/greenhouse/package.json +++ b/apps/greenhouse/package.json @@ -15,7 +15,6 @@ "@testing-library/jest-dom": "7.0.1", "@testing-library/react": "16.3.3", "@testing-library/user-event": "14.6.7", - "@types/js-yaml": "4.0.9", "@types/react": "19.3.0", "@types/react-dom": "19.3.0", "@vitejs/plugin-react": "6.1.1", @@ -57,7 +56,7 @@ "@codemirror/view": "6.43.13", "@tanstack/react-query": "5.103.2", "@tanstack/react-router": "1.170.38", - "js-yaml": "4.3.2", + "js-yaml": "5.4.2", "zod": "4.6.5" } } diff --git a/apps/greenhouse/src/components/admin/common/YamlViewer.tsx b/apps/greenhouse/src/components/admin/common/YamlViewer.tsx index b393da74be..f8c39b1f67 100644 --- a/apps/greenhouse/src/components/admin/common/YamlViewer.tsx +++ b/apps/greenhouse/src/components/admin/common/YamlViewer.tsx @@ -9,7 +9,7 @@ import { EditorState } from "@codemirror/state" import { yaml } from "@codemirror/lang-yaml" import { foldGutter, foldKeymap } from "@codemirror/language" import { oneDark } from "@codemirror/theme-one-dark" -import yamlParser from "js-yaml" +import { dump } from "js-yaml" import { ErrorMessage } from "../common/ErrorBoundary/ErrorMessage" interface YamlViewerProps extends Omit, "value"> { @@ -53,7 +53,7 @@ export default function YamlViewer({ value, className = "", ...props }: YamlView const { yamlContent, error } = useMemo(() => { try { - const yamlString = yamlParser.dump(value, { + const yamlString = dump(value, { indent: 2, lineWidth: -1, noRefs: true, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0d182db5e0..72d0918a69 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -482,8 +482,8 @@ importers: specifier: 1.170.38 version: 1.170.38(react-dom@19.3.0(react@19.3.0))(react@19.3.0) js-yaml: - specifier: 4.3.2 - version: 4.3.2 + specifier: 5.4.2 + version: 5.4.2 zod: specifier: 4.6.5 version: 4.6.5 @@ -506,9 +506,6 @@ importers: '@testing-library/user-event': specifier: 14.6.7 version: 14.6.7(@testing-library/dom@10.4.2) - '@types/js-yaml': - specifier: 4.0.9 - version: 4.0.9 '@types/react': specifier: 19.3.0 version: 19.3.0 @@ -3249,9 +3246,6 @@ packages: '@types/hast@3.0.5': resolution: {integrity: sha512-rp/ezSWaD1m44dPKICGhiskI13nVr7qTloFwDa/IYkhhf5nzwP+zIQcIJh3WIFSBOy/H1PzB40jPjMDksN4F+g==} - '@types/js-yaml@4.0.9': - resolution: {integrity: sha512-k4MGaQl5TGo/iipqb2UDG2UwjXziSWkh0uysQelTlJpX1qGlpUZYm8PnO4DxG1qBomtJUdYJ6qR6xdIah10JLg==} - '@types/json-schema@7.0.15': resolution: {integrity: sha512-5+fP8P8MFNC+AyZCDxrB2pkZFPGzqQWUzpSeuuVLvm8VMcorNYavBqoFcxK8bQz4Qsbn4oUEEem4wDLfcysGHA==} @@ -4839,6 +4833,10 @@ packages: resolution: {integrity: sha512-SFNOvSJ+Dgf/9An904Yx+CgSlIPCkIpao4qo51lpee25TIRejdH3rhR4EZMGoNx3/TP3O+wzWuiTFl4sqbltzA==} hasBin: true + js-yaml@5.4.2: + resolution: {integrity: sha512-m+aqu+LwO1O6sIopafj8HUVl5aawITwZQe/yHpMCKjaWBaA/d07B/QdMb3529REftiU+RMMHL3Vlsw3hON7vWg==} + hasBin: true + jsdom@30.1.0: resolution: {integrity: sha512-h/Q+H+KmlGf49ITw3TrykSVbg04S75S2O7ZtJc9gMGOWBrQRZmx5AJIKLtJ01e6Kszl+/tpFthCVqxNifxhoqg==} engines: {node: ^22.22.2 || ^24.15.0 || >=26.0.0} @@ -8957,8 +8955,6 @@ snapshots: dependencies: '@types/unist': 3.0.3 - '@types/js-yaml@4.0.9': {} - '@types/json-schema@7.0.15': {} '@types/mdast@4.0.4': @@ -10798,6 +10794,10 @@ snapshots: dependencies: argparse: 2.0.1 + js-yaml@5.4.2: + dependencies: + argparse: 2.0.1 + jsdom@30.1.0: dependencies: '@asamuzakjp/css-color': 7.0.1