Skip to content

Commit cfee313

Browse files
committed
Adopt go-makefile-maker's dependencyDashboard object form
go-makefile-maker (sapcc/go-makefile-maker#673, merged 2026-11-13) now emits the dependencyDashboard options as an object, following Renovate's migration of the Dependency Dashboard configuration into that object (renovatebot/renovate#47732), and its workflow template sets up Node.js before installing the Renovate config validator. Without that Node.js step, npm resolves the unpinned `npm install --global renovate` to 42.99.0 on the runner's default Node (the newest release whose engines still allow Node 22), and 42.99.0 predates the object form, so it fails the "Run go-makefile-maker" check on every open PR: Configuration option `dependencyDashboard` should be boolean. Found: {"osvVulnerabilitySummary":"all"} (object) Adopt the regenerated renovate.json5 and workflow so the check validates again with a current Renovate (verified locally with renovate 44.238.0). Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
1 parent 8ab01ed commit cfee313

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎.github/renovate.json5‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
"constraints": {
2020
"go": "1.27"
2121
},
22-
"dependencyDashboardOSVVulnerabilitySummary": "all",
22+
"dependencyDashboard": {
23+
"osvVulnerabilitySummary": "all"
24+
},
2325
"osvVulnerabilityAlerts": true,
2426
"postUpdateOptions": [
2527
"gomodTidy",

‎.github/workflows/run-go-makefile-maker.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ jobs:
4040
env:
4141
DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
4242
run: git symbolic-ref refs/remotes/origin/HEAD "refs/remotes/origin/$DEFAULT_BRANCH"
43+
- name: Set up Node.js
44+
uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7
45+
with:
46+
node-version: "26"
4347
- name: Install Renovate config validator
4448
run: npm install --global renovate
4549
- name: Run go-makefile-maker

0 commit comments

Comments
 (0)