Skip to content

Commit ea7e5dc

Browse files
committed
migrate to new action api
1 parent 6d8bf57 commit ea7e5dc

10 files changed

Lines changed: 58 additions & 37 deletions

File tree

‎python-impl/src/main/java/com/jetbrains/pyqt/CompileQrcAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import consulo.ui.annotation.RequiredUIAccess;
2828
import consulo.ui.ex.action.AnAction;
2929
import consulo.ui.ex.action.AnActionEvent;
30+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
3031
import consulo.ui.ex.awt.DialogWrapper;
3132
import consulo.ui.ex.awt.Messages;
3233
import consulo.ui.ex.awt.TextFieldWithBrowseButton;
@@ -38,7 +39,7 @@
3839
/**
3940
* @author yole
4041
*/
41-
public class CompileQrcAction extends AnAction {
42+
public class CompileQrcAction extends AnAction implements AnActionWithSyncUpdate {
4243
@Override
4344
@RequiredUIAccess
4445
public void actionPerformed(AnActionEvent e) {

‎python-impl/src/main/java/com/jetbrains/python/impl/actions/CleanPycAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import consulo.ui.annotation.RequiredUIAccess;
2626
import consulo.ui.ex.action.AnAction;
2727
import consulo.ui.ex.action.AnActionEvent;
28+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
2829
import consulo.util.io.FileUtil;
2930
import org.jspecify.annotations.Nullable;
3031

@@ -35,7 +36,7 @@
3536
/**
3637
* @author yole
3738
*/
38-
public class CleanPycAction extends AnAction {
39+
public class CleanPycAction extends AnAction implements AnActionWithSyncUpdate {
3940
private static void collectPycFiles(File directory, List<File> pycFiles) {
4041
FileUtil.processFilesRecursively(
4142
directory,

‎python-impl/src/main/java/com/jetbrains/python/impl/actions/CreatePackageAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import consulo.python.module.extension.PyModuleExtension;
3535
import consulo.ui.annotation.RequiredUIAccess;
3636
import consulo.ui.ex.action.AnActionEvent;
37+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
3738
import consulo.ui.ex.action.DumbAwareAction;
3839
import consulo.ui.ex.awt.Messages;
3940
import consulo.ui.ex.awt.UIUtil;
@@ -43,7 +44,7 @@
4344
/**
4445
* @author yole
4546
*/
46-
public class CreatePackageAction extends DumbAwareAction {
47+
public class CreatePackageAction extends DumbAwareAction implements AnActionWithSyncUpdate {
4748
private static final Logger LOG = Logger.getInstance(CreatePackageAction.class);
4849

4950
@Override
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
package com.jetbrains.python.impl.console;
2+
3+
import consulo.ui.ex.action.*;
4+
import consulo.util.concurrent.coroutine.Coroutine;
5+
import consulo.util.concurrent.coroutine.step.CodeExecution;
6+
7+
/**
8+
* @author VISTALL
9+
* @since 2026-07-03
10+
*/
11+
public abstract class PyDelegateConsoleAction extends DumbAwareAction implements AnActionWithAsyncUpdate {
12+
private final AnAction myDelegate;
13+
14+
public PyDelegateConsoleAction(AnAction delegate) {
15+
myDelegate = delegate;
16+
}
17+
18+
@Override
19+
public Coroutine<?, ?> updateAsync(AnActionEvent e) {
20+
if (myDelegate instanceof AnActionWithAsyncUpdate asyncUpdate) {
21+
return asyncUpdate.updateAsync(e);
22+
}
23+
24+
if (myDelegate instanceof AnActionWithSyncUpdate syncUpdate) {
25+
return CodeExecution.run(() -> syncUpdate.update(e)).toCoroutine();
26+
}
27+
28+
return CodeExecution.run(() -> {
29+
}).toCoroutine();
30+
}
31+
}

‎python-impl/src/main/java/com/jetbrains/python/impl/console/PyOpenDebugConsoleAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,15 @@
2626
import consulo.ui.annotation.RequiredUIAccess;
2727
import consulo.ui.ex.action.AnAction;
2828
import consulo.ui.ex.action.AnActionEvent;
29+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
2930

3031
import java.util.Collection;
3132
import java.util.function.Consumer;
3233

3334
/**
3435
* @author traff
3536
*/
36-
public class PyOpenDebugConsoleAction extends AnAction implements DumbAware {
37+
public class PyOpenDebugConsoleAction extends AnAction implements DumbAware, AnActionWithSyncUpdate {
3738
public PyOpenDebugConsoleAction() {
3839
super();
3940
getTemplatePresentation().setIcon(ExecutionIconGroup.console());

‎python-impl/src/main/java/com/jetbrains/python/impl/console/PydevConsoleRunnerImpl.java‎

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@
9797
import consulo.util.lang.StringUtil;
9898
import consulo.util.lang.TimeoutUtil;
9999
import consulo.virtualFileSystem.VirtualFile;
100-
import org.jspecify.annotations.Nullable;
101100
import org.apache.xmlrpc.XmlRpcException;
101+
import org.jspecify.annotations.Nullable;
102102

103103
import javax.swing.*;
104104
import java.awt.*;
@@ -523,7 +523,7 @@ protected AnAction createRerunAction() {
523523
}
524524

525525
private AnAction createInterruptAction() {
526-
AnAction anAction = new AnAction() {
526+
AnAction anAction = new LegacyAnAction() {
527527
@Override
528528
@RequiredUIAccess
529529
public void actionPerformed(AnActionEvent e) {
@@ -542,7 +542,6 @@ public void actionPerformed(AnActionEvent e) {
542542
}
543543

544544
@Override
545-
@RequiredUIAccess
546545
public void update(AnActionEvent e) {
547546
EditorEx consoleEditor = myConsoleView.getConsoleEditor();
548547
boolean enabled =
@@ -556,7 +555,7 @@ public void update(AnActionEvent e) {
556555
}
557556

558557
private AnAction createTabCompletionAction() {
559-
AnAction runCompletions = new AnAction() {
558+
AnAction runCompletions = new LegacyAnAction() {
560559
@RequiredUIAccess
561560
@Override
562561
public void actionPerformed(AnActionEvent e) {
@@ -574,7 +573,6 @@ public void actionPerformed(AnActionEvent e) {
574573
ActionImplUtil.performActionDumbAware(completionAction, e);
575574
}
576575

577-
@RequiredUIAccess
578576
@Override
579577
public void update(AnActionEvent e) {
580578
Editor editor = myConsoleView.getConsoleEditor();
@@ -633,12 +631,7 @@ private boolean handshake() {
633631

634632
private AnAction createStopAction() {
635633
AnAction generalStopAction = ActionManager.getInstance().getAction(IdeActions.ACTION_STOP_PROGRAM);
636-
AnAction stopAction = new DumbAwareAction() {
637-
@Override
638-
public void update(AnActionEvent e) {
639-
generalStopAction.update(e);
640-
}
641-
634+
PyDelegateConsoleAction stopAction = new PyDelegateConsoleAction(generalStopAction) {
642635
@Override
643636
@RequiredUIAccess
644637
public void actionPerformed(AnActionEvent e) {
@@ -654,12 +647,7 @@ public void actionPerformed(AnActionEvent e) {
654647
private AnAction createCloseAction(final RunContentDescriptor descriptor) {
655648
final AnAction generalCloseAction = new CloseAction(getExecutor(), descriptor, myProject);
656649

657-
AnAction stopAction = new DumbAwareAction() {
658-
@Override
659-
public void update(AnActionEvent e) {
660-
generalCloseAction.update(e);
661-
}
662-
650+
PyDelegateConsoleAction stopAction = new PyDelegateConsoleAction(generalCloseAction) {
663651
@Override
664652
@RequiredUIAccess
665653
public void actionPerformed(AnActionEvent e) {
@@ -877,11 +865,6 @@ public NewConsoleAction() {
877865
);
878866
}
879867

880-
@Override
881-
public void update(AnActionEvent e) {
882-
e.getPresentation().setEnabled(true);
883-
}
884-
885868
@Override
886869
@RequiredUIAccess
887870
public void actionPerformed(AnActionEvent e) {

‎python-impl/src/main/java/com/jetbrains/python/impl/console/RunPythonConsoleAction.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@
2222
import consulo.application.dumb.DumbAware;
2323
import consulo.project.Project;
2424
import consulo.content.bundle.Sdk;
25+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
2526
import consulo.util.lang.Pair;
2627
import consulo.ui.annotation.RequiredUIAccess;
2728

2829

2930
/**
3031
* @author oleg
3132
*/
32-
public class RunPythonConsoleAction extends AnAction implements DumbAware {
33+
public class RunPythonConsoleAction extends AnAction implements DumbAware, AnActionWithSyncUpdate {
3334
public RunPythonConsoleAction() {
3435
super();
3536
getTemplatePresentation().setIcon(PythonImplIconGroup.pythonPythonconsole());
3637
}
3738

3839
@Override
39-
@RequiredUIAccess
4040
public void update(AnActionEvent e) {
4141
e.getPresentation().setVisible(true);
4242
e.getPresentation().setEnabled(false);

‎python-impl/src/main/java/com/jetbrains/python/impl/packaging/PyManagePackagesAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@
2121
import consulo.module.Module;
2222
import consulo.content.bundle.Sdk;
2323
import com.jetbrains.python.impl.sdk.PythonSdkType;
24+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
2425

2526
/**
2627
* @author yole
2728
*/
28-
public class PyManagePackagesAction extends AnAction {
29+
public class PyManagePackagesAction extends AnAction implements AnActionWithSyncUpdate {
2930
@Override
3031
@RequiredUIAccess
3132
public void actionPerformed(AnActionEvent e) {

‎python-impl/src/main/java/com/jetbrains/python/impl/packaging/setupPy/SetupTaskChooserAction.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import consulo.ui.annotation.RequiredUIAccess;
3232
import consulo.ui.ex.action.AnAction;
3333
import consulo.ui.ex.action.AnActionEvent;
34+
import consulo.ui.ex.action.AnActionWithSyncUpdate;
3435
import consulo.ui.ex.awt.Messages;
3536
import consulo.virtualFileSystem.LocalFileSystem;
3637
import consulo.virtualFileSystem.VirtualFile;
@@ -41,7 +42,7 @@
4142
/**
4243
* @author yole
4344
*/
44-
public class SetupTaskChooserAction extends AnAction {
45+
public class SetupTaskChooserAction extends AnAction implements AnActionWithSyncUpdate {
4546
public SetupTaskChooserAction() {
4647
super(LocalizeValue.localizeTODO("Run setup.py Task..."));
4748
}

‎python-rest/src/main/java/com/jetbrains/python/rest/sphinx/RunSphinxQuickStartAction.java‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,24 @@
2626
import consulo.module.ModuleManager;
2727
import consulo.project.Project;
2828
import consulo.ui.annotation.RequiredUIAccess;
29-
import consulo.ui.ex.action.AnAction;
30-
import consulo.ui.ex.action.AnActionEvent;
31-
import consulo.ui.ex.action.Presentation;
29+
import consulo.ui.ex.action.*;
30+
import consulo.ui.ex.action.coroutine.ActionSafeReadLock;
31+
import consulo.util.concurrent.coroutine.Coroutine;
3232

3333
/**
3434
* @author catherine
3535
*/
3636
@ActionImpl(id = "RunSphinxQuickStartAction", parents = @ActionParentRef(@ActionRef(id = "ToolsMenu")))
37-
public class RunSphinxQuickStartAction extends AnAction implements DumbAware {
37+
public class RunSphinxQuickStartAction extends AnAction implements DumbAware, AnActionWithAsyncUpdate {
3838
public RunSphinxQuickStartAction() {
3939
super(LocalizeValue.localizeTODO("Sphinx quickstart"), LocalizeValue.localizeTODO("Allows to run sphinx quick-start action"));
4040
}
4141

4242
@Override
43-
public void update(AnActionEvent event) {
44-
super.update(event);
45-
RestPythonUtil.updateSphinxQuickStartRequiredAction(event);
43+
public Coroutine<?, ?> updateAsync(AnActionEvent e) {
44+
return ActionSafeReadLock.run(e, presentation -> {
45+
RestPythonUtil.updateSphinxQuickStartRequiredAction(e);
46+
}).toCoroutine();
4647
}
4748

4849
@Override

0 commit comments

Comments
 (0)