From 3c85fce30560238e88c510da9a3bbd64a346a88a Mon Sep 17 00:00:00 2001 From: Sidharth Menon Date: Wed, 18 Nov 2026 14:39:37 -0800 Subject: [PATCH] Scroll a tour to the clicked code when its stop shows several Agent-Session: 9467d5af-98ed-4da0-b22e-b96feb43df0f Agent-Session: 8475fa2e-5cfe-4cf5-adb4-c03e8441117d --- packages/review/app/src/CodePeek.tsx | 2 + .../app/src/animation/animation-block.tsx | 20 +++-- packages/review/app/src/diagram-tour.tsx | 3 + packages/review/app/src/review-components.tsx | 19 ++++- packages/review/app/src/review-panel-model.ts | 7 +- packages/review/app/src/review-panel-store.ts | 19 +++-- .../app/src/review-panel.browser.test.tsx | 79 +++++++++++++++++++ 7 files changed, 136 insertions(+), 13 deletions(-) diff --git a/packages/review/app/src/CodePeek.tsx b/packages/review/app/src/CodePeek.tsx index 331d00bdb2..75c9e5a6dd 100644 --- a/packages/review/app/src/CodePeek.tsx +++ b/packages/review/app/src/CodePeek.tsx @@ -200,6 +200,7 @@ export function CodePeekCard({ xstyle, )} role="status" + data-code-peek-key={key} > {outcome === "failed" ? "Code unavailable" : "Loading code…"} @@ -215,6 +216,7 @@ export function CodePeekCard({ xstyle, )} data-code-rendering="inline-editor" + data-code-peek-key={key} > onPhase(), [motion]); - const openTour = () => { + const openTour = (revealCode?: string) => { if (!tour || !frameAnchor) return; if (!tourOpen) { @@ -639,7 +640,11 @@ function StageBlock({ setExpanded(false); panelStore .getState() - .openOverlayTour({ tourId: node.id, kind: "animation" }, frameAnchor); + .openOverlayTour( + { tourId: node.id, kind: "animation" }, + frameAnchor, + revealCode, + ); }; // A drawn element's code opens beside the board with the tour, at the @@ -660,9 +665,12 @@ function StageBlock({ content: { kind: "source", source: anchor.peek }, }); - if (tourOpen) return moveOverlayTour(tourStop.anchor.id, { reveal: true }); + const code = selectionKey(anchor.peek); + + if (tourOpen) + return moveOverlayTour(tourStop.anchor.id, { reveal: true, code }); - if (expanded || diagramFullscreenOnClick) return openTour(); + if (expanded || diagramFullscreenOnClick) return openTour(code); openPeek({ kind: "peek", @@ -671,6 +679,7 @@ function StageBlock({ tour: { definition: tour, revealRequest: (active?.tour?.revealRequest ?? 0) + 1, + revealCode: code, }, }); }; @@ -1391,7 +1400,7 @@ function StageBlock({ openTour()} /> ) : (