diff --git a/dart/rules/defs.bzl b/dart/rules/defs.bzl index 2ad2ce91b..c79182995 100644 --- a/dart/rules/defs.bzl +++ b/dart/rules/defs.bzl @@ -110,7 +110,7 @@ def dart_test(name, *, main = None, srcs = None, visibility = None, **kwargs): kwargs = dx_language_kwargs(kwargs, DART_DEFERRED_SKIP_TAGS, DART_COMPATIBLE_WITH) dx_wrap_test(name, _dart_test, _dart_forward_test, srcs, visibility = visibility, upstream_kwargs = dict(kwargs, main = main), quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs) -def dart_bench(name, main = None, srcs = None, deps = None, tags = None, **kwargs): +def dart_bench(name, *, main = None, srcs = None, deps = None, tags = None, **kwargs): """A dart_test run by dx bench: `main` calls runBenchmarks from package:dx_bench with BenchmarkBase objects, which writes dx-bench.json.""" dart_test( name = name, diff --git a/elixir/rules/defs.bzl b/elixir/rules/defs.bzl index 880558c9b..cf88f97cd 100644 --- a/elixir/rules/defs.bzl +++ b/elixir/rules/defs.bzl @@ -177,7 +177,7 @@ def elixir_test(name, *, srcs = None, visibility = None, **kwargs): apps = {"apps": kwargs["deps"]} if kwargs.get("deps") else None dx_wrap_test(name, _ex_unit_test, _ex_unit_forward_test, helper_first(srcs), visibility = visibility, upstream_kwargs = upstream, extra_forward_kwargs = apps, **kwargs) -def elixir_bench(name, srcs, tags = None, deps = None, **kwargs): +def elixir_bench(name, *, srcs, tags = None, deps = None, **kwargs): """elixir_test run by dx bench: DxBench.run in srcs runs Benchee and writes dx-bench.json.""" elixir_test( name = name, diff --git a/perl/rules/defs.bzl b/perl/rules/defs.bzl index dad1c2c67..b2a626b3b 100644 --- a/perl/rules/defs.bzl +++ b/perl/rules/defs.bzl @@ -113,7 +113,7 @@ def perl_test(name, *, srcs = None, main = None, visibility = None, **kwargs): upstream = dict(kwargs, main = main) dx_wrap_test(name, _perl_test, _perl_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, extra_forward_kwargs = {"deps": kwargs.get("deps", [])}, quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs) -def perl_bench(name, srcs = None, main = None, deps = None, tags = None, **kwargs): +def perl_bench(name, *, srcs = None, main = None, deps = None, tags = None, **kwargs): """A perl_test run by dx bench: scripts call DxBench::run_benchmarks, which times them with core Benchmark and writes dx-bench.json.""" perl_test( name = name, diff --git a/php/rules/defs.bzl b/php/rules/defs.bzl index 051edd3e0..96723956c 100644 --- a/php/rules/defs.bzl +++ b/php/rules/defs.bzl @@ -68,7 +68,7 @@ def php_test(name, *, srcs = None, visibility = None, **kwargs): kwargs = dx_language_kwargs(kwargs, PHP_DEFERRED_SKIP_TAGS, PHP_COMPATIBLE_WITH) dx_wrap_test(name, _php_test, _php_forward_test, srcs, visibility = visibility, quality_srcs = dx_entry_quality_srcs(None, srcs), **kwargs) -def php_bench(name, benches, data = None, env = None, tags = None, **kwargs): +def php_bench(name, *, benches, data = None, env = None, tags = None, **kwargs): """A php_test run by dx bench: phpbench runs the `benches` files, one class per file named like the file, and the result is written as dx-bench.json.""" phar = Label("@dx_phpbench//:phpbench.phar") php_test( diff --git a/ruby/rules/defs.bzl b/ruby/rules/defs.bzl index 8a1ebc9b0..71d86e85d 100644 --- a/ruby/rules/defs.bzl +++ b/ruby/rules/defs.bzl @@ -109,7 +109,7 @@ def ruby_test(name, *, srcs = None, main = None, visibility = None, **kwargs): upstream = dict(kwargs, main = main) if main != None else kwargs dx_wrap_test(name, _rb_test, _ruby_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs) -def ruby_bench(name, main, srcs = None, data = None, env = None, tags = None, **kwargs): +def ruby_bench(name, *, main, srcs = None, data = None, env = None, tags = None, **kwargs): """A ruby_test run by dx bench: `main` calls DxBench.run with a benchmark-ips block, which writes dx-bench.json.""" ips = Label("@dx_ruby_bench_gems//:benchmark-ips-2.14.0/lib/benchmark/ips.rb") ruby_test( diff --git a/zig/rules/defs.bzl b/zig/rules/defs.bzl index c145a9a8f..419cefee2 100644 --- a/zig/rules/defs.bzl +++ b/zig/rules/defs.bzl @@ -131,7 +131,7 @@ def zig_test(name, *, main = None, srcs = None, visibility = None, **kwargs): })) dx_wrap_test(name, _zig_test, _zig_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, quality_srcs = dx_entry_quality_srcs(main, srcs), main = main, extra_forward_kwargs = {"deps": kwargs.get("deps", [])}, coverage_collector = ZIG_COVERAGE_COLLECTOR, **kwargs) -def zig_bench(name, main = None, srcs = None, visibility = None, tags = None, **kwargs): +def zig_bench(name, *, main = None, srcs = None, visibility = None, tags = None, **kwargs): """A ReleaseFast zig_binary plus a `` runner that writes dx-bench.json for `dx bench`.""" binary = name + "_bin" build, run = split_test_kwargs(kwargs)