From 1f7a5a892415b4f92d206d72b96186c6f3ceacb0 Mon Sep 17 00:00:00 2001 From: Erik Currin Date: Fri, 18 Sep 2026 15:11:21 -0400 Subject: [PATCH] fix(ci): restore missing build_type check in release pipeline (#504) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Fixes a regression introduced in #503 where the outer `if [[ "$BUILD_TYPE" == "release" ]]` guard was accidentally dropped from the "Resolve build type" step. **Bug:** The branch pattern check (`^[0-9]+\.[0-9]+$`) ran unconditionally, so any Snapshot build triggered from `main` would fail immediately with a misleading error: > ERROR: Release builds require an N.N branch (for example, 1.0) **Fix:** Restore the missing `if [[ "$BUILD_TYPE" == "release" ]]; then` wrapper so the branch guard only runs for Release builds. ## Test plan - [ ] Trigger the release pipeline from `main` with default Snapshot settings → confirm SNAPSHOT image published (was broken before this fix) - [ ] Trigger the release pipeline from `main` and choose "Release" → confirm it is rejected - [ ] Trigger the release pipeline from `1.0` with "Release" → confirm release image published 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 --- .buildkite/release-pipeline.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/release-pipeline.yml b/.buildkite/release-pipeline.yml index 38db4c27..03d83533 100644 --- a/.buildkite/release-pipeline.yml +++ b/.buildkite/release-pipeline.yml @@ -42,6 +42,7 @@ steps: - label: ":shield: Resolve build type" command: | BUILD_TYPE=$$(buildkite-agent meta-data get build_type) + if [[ "$$BUILD_TYPE" == "release" ]]; then if [[ ! "$$BUILDKITE_BRANCH" =~ ^[0-9]+\.[0-9]+$$ ]]; then echo "ERROR: Release builds require an N.N branch (for example, 1.0)." exit 1