diff --git a/ggml/cmake/ggml-config.cmake.in b/ggml/cmake/ggml-config.cmake.in index f8862896f..b3d0cfc07 100644 --- a/ggml/cmake/ggml-config.cmake.in +++ b/ggml/cmake/ggml-config.cmake.in @@ -188,7 +188,7 @@ if(NOT TARGET ggml::ggml) if (TARGET ggml::${_ggml_backend}) list(APPEND _ggml_all_targets ggml::${_ggml_backend}) endif() -endforeach() +endif() # Synthetic ggml::all aggregating every available backend — matches the # upstream contract used by examples/simple-cmake-pkg and any external diff --git a/src/llama-model.cpp b/src/llama-model.cpp index 949fe1184..3d7cac87f 100644 --- a/src/llama-model.cpp +++ b/src/llama-model.cpp @@ -2428,6 +2428,7 @@ llama_rope_type llama_model_rope_type(const llama_model * model) { switch (model->arch) { // these models do not use RoPE case LLM_ARCH_CLIP: + case LLM_ARCH_KOKORO: case LLM_ARCH_GPT2: case LLM_ARCH_GPTJ: case LLM_ARCH_MPT: diff --git a/tests/test-llama-archs.cpp b/tests/test-llama-archs.cpp index 30a65e6d4..e79814b5a 100644 --- a/tests/test-llama-archs.cpp +++ b/tests/test-llama-archs.cpp @@ -341,7 +341,7 @@ static std::vector get_logits( } if (target_ctx) { llama_memory_clear(llama_get_memory(target_source), true); - llama_set_embeddings_pre_norm(target_source, true); + llama_set_embeddings_nextn(target_source, true, false); get_logits(llama_get_model(target_source), target_source, tokens); if (target_source != target_ctx) { std::vector state(llama_state_get_size(target_source)); @@ -366,10 +366,10 @@ static std::vector get_logits( batch.token = static_cast(std::malloc(n_ctx * sizeof(llama_token))); GGML_ASSERT(batch.token); // Match MTP prefill: first row has no prior state; later rows consume - // the real target's preceding pre-normalization hidden state. + // the real target's preceding NextN hidden state. std::memset(batch.embd, 0, n_embd * sizeof(float)); for (uint32_t i = 1; i < n_tokens; ++i) { - const float * hidden = llama_get_embeddings_pre_norm_ith(target_source, i - 1); + const float * hidden = llama_get_embeddings_nextn_ith(target_source, i - 1); GGML_ASSERT(hidden); std::memcpy(batch.embd + i * n_embd, hidden, n_embd * sizeof(float)); }