From 54e381b9494a21716f0979a2689b7c78a5ee7ae4 Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 04:15:02 +0000 Subject: [PATCH 1/6] refactor(runtime): adopt Bycorf storage backend facade --- bycorf | 2 +- docs/architecture/01-overview.md | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/bycorf b/bycorf index a430b323b..3f1577fc4 160000 --- a/bycorf +++ b/bycorf @@ -1 +1 @@ -Subproject commit a430b323b65c61467a552d0f908aca0790e1cb99 +Subproject commit 3f1577fc4f5a3da414fae9621725352f01afc631 diff --git a/docs/architecture/01-overview.md b/docs/architecture/01-overview.md index b41e80fd8..b3f7466a0 100644 --- a/docs/architecture/01-overview.md +++ b/docs/architecture/01-overview.md @@ -36,7 +36,10 @@ start. The default build includes only Linux TCP and io_uring. The opt-in `LAVIK_KERNEL_BYPASS` build includes DPDK and SPDK together; it does not activate them. Startup defaults remain Linux TCP and io_uring, including for the Meta control plane. Each worker owns one io_uring shared by kernel -network/storage I/O, timers and wakeups; the DPDK adapter borrows that ring. +network/storage I/O, timers and wakeups. Its `NetBackend` and `StorageBackend` +adapters borrow that ring and independently encapsulate network and storage +backend selection; the DPDK adapter also borrows it. The worker initializes the +ring before the adapters and stops both adapters before shutting down the ring. The optional DPDK network backend serves plaintext IPv4 TCP through Bycorf's private FreeBSD stack while preserving the same RESP stream interface and worker ownership. Software packet forwarding From 866497a899ee998d9bf7c92287378ec38938b88a Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 04:20:06 +0000 Subject: [PATCH 2/6] chore(bycorf): update renamed SPDK backend --- bycorf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bycorf b/bycorf index 3f1577fc4..138a5222a 160000 --- a/bycorf +++ b/bycorf @@ -1 +1 @@ -Subproject commit 3f1577fc4f5a3da414fae9621725352f01afc631 +Subproject commit 138a5222a02c8fef8d639d4f7febbda3f1ca478c From 79db3f29ab858c1c254f5c94aeb802d6813be346 Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 04:52:15 +0000 Subject: [PATCH 3/6] chore(bycorf): update shared-ring CRTP facades --- bycorf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bycorf b/bycorf index 138a5222a..8cf9378e9 160000 --- a/bycorf +++ b/bycorf @@ -1 +1 @@ -Subproject commit 138a5222a02c8fef8d639d4f7febbda3f1ca478c +Subproject commit 8cf9378e9acf4d633497bf2f95e78d089aa9bfd3 From 9a0c5c1bafcbaa1dbb305ec42fe7e20786e729a3 Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 05:08:15 +0000 Subject: [PATCH 4/6] fix(build): include SPDK path declarations in server The backend refactor stopped transitively exposing spdk_storage.h through Worker when kernel bypass is disabled. Include the declaring header directly for IsSpdkStoragePath in replacement-RDB validation. This fixes the Clang CI failure without changing runtime behavior. --- src/redis/server.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/redis/server.cpp b/src/redis/server.cpp index 92f0ca028..5e12e271b 100644 --- a/src/redis/server.cpp +++ b/src/redis/server.cpp @@ -57,6 +57,7 @@ #if BYCORF_KERNEL_BYPASS #include "bycorf/io/dpdk_backend.h" #endif +#include "bycorf/io/spdk_storage.h" #include "bycorf/net/server.h" #include "bycorf/net/tcp_service.h" #include "bycorf/net/tcp_stream.h" From 5a09d574279abc44a1400b16430ace8c3c590fe6 Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 05:08:16 +0000 Subject: [PATCH 5/6] fix(build): keep release command and Lua code warning-clean Mark the insertion position used only by assertions as maybe_unused and explicitly default the Lua error-count collection to empty. This preserves behavior while resolving unused-parameter and missing-field-initializers diagnostics under Werror. --- include/lavik/command_args.h | 3 ++- src/redis/lua_eval.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/lavik/command_args.h b/include/lavik/command_args.h index 705d01e59..a0fc2be97 100644 --- a/include/lavik/command_args.h +++ b/include/lavik/command_args.h @@ -399,7 +399,8 @@ class CommandArgsHandle { Get().assign(first, last); } template - void insert(CommandArgsView::Iterator pos, Iterator first, Iterator last) { + void insert([[maybe_unused]] CommandArgsView::Iterator pos, Iterator first, + Iterator last) { // Synthesis only appends; arbitrary insertion would invalidate offsets and // borrow semantics. Rewriters build an independent command instead. assert(pos == end()); diff --git a/src/redis/lua_eval.h b/src/redis/lua_eval.h index 8930714f2..577592a93 100644 --- a/src/redis/lua_eval.h +++ b/src/redis/lua_eval.h @@ -75,7 +75,7 @@ struct LuaExecutionStep { std::string reply_; CommandOutcome outcome_{}; // Newly constructed errors only; forwarded child errors were already counted. - std::vector errors_; + std::vector errors_{}; bool scheduler_yield_ = false; }; From e99e359e8454f1c785b70aa98c067ccfde96516e Mon Sep 17 00:00:00 2001 From: Jerry Zhao Date: Tue, 3 Nov 2026 05:09:59 +0000 Subject: [PATCH 6/6] chore(bycorf): pin merged storage backend refactor --- bycorf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bycorf b/bycorf index 8cf9378e9..4b10a34e8 160000 --- a/bycorf +++ b/bycorf @@ -1 +1 @@ -Subproject commit 8cf9378e9acf4d633497bf2f95e78d089aa9bfd3 +Subproject commit 4b10a34e8eff7d991018454a682019773e3a112e