From 32c3ca436b1472ac6c9210f8bde96455e1aee172 Mon Sep 17 00:00:00 2001 From: Eric Dahl Date: Sat, 14 Nov 2026 16:02:02 -0500 Subject: [PATCH] Show clean-up: Select mode for everyone (#1217) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Eric tried it on an iPhone from TestFlight 1.2.13 (64.1) on 2026-11-14: Select, Select empty, Free Up Space…, plus the delete changes (#1216), all good. ShowCleanupAvailability moves from Debug + TestFlight to everyone. Assisted-by: Claude Code:claude-opus-5-5 --- .../Recording/ShowCleanupAvailability.swift | 6 ++-- .../ShowCleanupAvailabilityTests.swift | 30 +++++-------------- 2 files changed, 11 insertions(+), 25 deletions(-) diff --git a/Packages/ShowRecorderKit/Sources/Recording/ShowCleanupAvailability.swift b/Packages/ShowRecorderKit/Sources/Recording/ShowCleanupAvailability.swift index 1f8125a9..d6fc7f86 100644 --- a/Packages/ShowRecorderKit/Sources/Recording/ShowCleanupAvailability.swift +++ b/Packages/ShowRecorderKit/Sources/Recording/ShowCleanupAvailability.swift @@ -1,8 +1,8 @@ -/// Where the Shows list's Select mode, which deletes several Shows at once (#1217), is offered: Debug and TestFlight -/// builds until Eric has tried it on a device. +/// Where the Shows list's Select mode, which deletes several Shows at once (#1217), is offered: everyone, since Eric +/// tried it on an iPhone from TestFlight 1.2.13 (2026-11-14). public enum ShowCleanupAvailability { /// Where it is offered; moving it up a level is this one line. - public static let level: AvailabilityLevel = .debugAndTestFlight + public static let level: AvailabilityLevel = .everyone /// `environment` is nil until StoreKit has answered; only a sandbox (TestFlight) answer offers it in a Release build. public static func isAvailable(isDebugBuild: Bool, environment: DistributionEnvironment?) -> Bool { diff --git a/Packages/ShowRecorderKit/Tests/RecordingTests/ShowCleanupAvailabilityTests.swift b/Packages/ShowRecorderKit/Tests/RecordingTests/ShowCleanupAvailabilityTests.swift index 2dab34ff..5fe2cb10 100644 --- a/Packages/ShowRecorderKit/Tests/RecordingTests/ShowCleanupAvailabilityTests.swift +++ b/Packages/ShowRecorderKit/Tests/RecordingTests/ShowCleanupAvailabilityTests.swift @@ -1,30 +1,16 @@ @testable import Recording import Testing -/// Selecting several Shows and deleting them at once (#1217) is offered in Debug and TestFlight builds until Eric has -/// tried it on a device. Opening it up is this one rule. +/// Selecting several Shows and deleting them at once (#1217) is offered in every build, App Store included (Eric, +/// 2026-11-14), after he tried it on an iPhone from TestFlight build 1.2.13 (64.1). @Suite("Show clean-up availability") struct ShowCleanupAvailabilityTests { - @Test("Debug builds offer it whatever the environment, even before it is known") - func debugBuild() { - for environment: DistributionEnvironment? in [nil, .unknown, .sandbox, .production] { - #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: true, environment: environment)) - } - } - - @Test("TestFlight (sandbox) builds offer it") - func testFlightBuild() { + @Test("Offered everywhere: Debug, TestFlight, the App Store, and before StoreKit has answered") + func everyone() { + #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: true, environment: nil)) #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: .sandbox)) - } - - @Test("The App Store (production) build does not") - func appStoreBuild() { - #expect(!ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: .production)) - } - - @Test("A Release build whose environment is unknown or not yet answered does not") - func unknownEnvironment() { - #expect(!ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: nil)) - #expect(!ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: .unknown)) + #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: .production)) + #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: .unknown)) + #expect(ShowCleanupAvailability.isAvailable(isDebugBuild: false, environment: nil)) } }