From beddf968a2935d488c5f83b635dfa3398fda7730 Mon Sep 17 00:00:00 2001 From: danielvogler Date: Thu, 19 Nov 2026 16:45:53 +0100 Subject: [PATCH] fix(board): say a repeated loop id in one short sentence - The loop page's warning explained signing keys and helpers, which a person answering a question cannot act on; it now names the other repository and asks to check the right loop is being answered. - The overview's line no longer points to the loop page for more. --- src/loopcaptain/board/templates/loop.html | 2 +- src/loopcaptain/board/templates/overview.html | 2 +- tests/test_repeated_ids.py | 9 +++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/loopcaptain/board/templates/loop.html b/src/loopcaptain/board/templates/loop.html index ea4410c..382c039 100644 --- a/src/loopcaptain/board/templates/loop.html +++ b/src/loopcaptain/board/templates/loop.html @@ -21,7 +21,7 @@

{{ view.title }}

{{ state.status }}{{ 'went quiet between rounds, past the time it said it would be back' if state.status == 'stalled' and state.rounds and not state.rounds[-1].running else status_text[state.status] }}{% if state.last_event %}last line {{ state.last_event|ago }}{% endif %}{% if branch %}branch {{ branch }}{% endif %}{% if view.repo.others %}written from {{ view.repo.path|place }}, the latest of {{ view.repo.others|length + 1 }} worktrees{% endif %}{% if manifest.pace %}{{ manifest.pace }}{% endif %}{% if state.status == 'sleeping' and state.expected %}back at {{ state.expected|stamp }}{% endif %}{% if state.ended %}ended between rounds: {{ state.ended.stop_reason|replace('_', ' ') }}{% if state.ended.summary %}, {{ state.ended.summary }}{% endif %}{% endif %}

{% if note %}

{{ note }}

{% endif %} {% if error %}{% endif %} -{% if same_id %}

Another watched repository has a loop with this id: {% for key in same_id %}{{ key }}{{ ', ' if not loop.last }}{% endfor %}. Check that this is the loop you mean to answer. The board signs each answer for this folder alone, but a loop that still runs an earlier helper also takes lines signed with the key every loop shares: paste the current helper into both.

{% endif %} +{% if same_id %}

{% for key in same_id %}{{ key }}{{ ', ' if not loop.last }}{% endfor %} also has a loop with this id. Check you are answering the right one.

{% endif %} {% if state.question %} {% set q = state.question %} diff --git a/src/loopcaptain/board/templates/overview.html b/src/loopcaptain/board/templates/overview.html index fe7051d..d3a7b10 100644 --- a/src/loopcaptain/board/templates/overview.html +++ b/src/loopcaptain/board/templates/overview.html @@ -30,7 +30,7 @@

{{ 'Waiting for you' if tab == 'waiting' else 'Loops' }}

{% if note %}

{{ note }}

{% endif %} {% if error %}{% endif %} -{% if repeated %}

Two watched repositories have a loop with the same id: {% for loop_id, keys in repeated.items() %}{{ loop_id }} in {{ keys[:-1]|join(', ') }} and {{ keys[-1] }}{{ '; ' if not loop.last }}{% endfor %}. Check the repository before you answer; the loop's page says more.

{% endif %} +{% if repeated %}

Two watched repositories have a loop with the same id: {% for loop_id, keys in repeated.items() %}{{ loop_id }} in {{ keys[:-1]|join(', ') }} and {{ keys[-1] }}{{ '; ' if not loop.last }}{% endfor %}. Check you are answering the right one.

{% endif %} {% if unreadable %}