Skip to content

Commit 0edfdb1

Browse files
committed
Accept missing test results due to missing guards for && and ||
1 parent 64ac667 commit 0edfdb1

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎go/ql/test/experimental/CWE-942/CorsMisconfiguration.expected‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
| CorsMisconfiguration.go:53:4:53:44 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
88
| CorsMisconfiguration.go:60:4:60:56 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
99
| CorsMisconfiguration.go:67:5:67:57 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
10+
| CorsMisconfiguration.go:130:7:130:63 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
11+
| CorsMisconfiguration.go:143:5:143:57 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
12+
| CorsMisconfiguration.go:158:5:158:57 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
13+
| CorsMisconfiguration.go:173:6:173:58 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
1014
| CorsMisconfiguration.go:224:5:224:57 | call to Set | access-control-allow-origin header is set to a user-defined value, and access-control-allow-credentials is set to `true` |
1115
| RsCors.go:11:21:11:59 | slice literal | access-control-allow-origin header is set to `null`, and access-control-allow-credentials is set to `true` |
1216
| RsCors.go:31:23:31:61 | slice literal | access-control-allow-origin header is set to `null`, and access-control-allow-credentials is set to `true` |

‎go/ql/test/experimental/CWE-942/CorsMisconfiguration.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func main() {
127127
if origin != "" && origin != "null" {
128128
if len(AccessControlAllowOrigins) == 0 ||
129129
AccessControlAllowOrigins[origin] {
130-
responseHeader.Set("Access-Control-Allow-Origin", origin)
130+
responseHeader.Set("Access-Control-Allow-Origin", origin) // $ SPURIOUS: Alert
131131
responseHeader.Set("Access-Control-Allow-Credentials", "true")
132132
}
133133
} else {
@@ -140,7 +140,7 @@ func main() {
140140
// OK-ish: the input origin header is validated against a suffix.
141141
origin := req.Header.Get("Origin")
142142
if origin != "" && (originSuffix == "" || strings.HasSuffix(origin, originSuffix)) {
143-
w.Header().Set("Access-Control-Allow-Origin", origin)
143+
w.Header().Set("Access-Control-Allow-Origin", origin) // $ SPURIOUS: Alert
144144
w.Header().Set("Access-Control-Allow-Credentials", "true")
145145
w.Header().Set("Access-Control-Allow-Headers", "Content-Type, x-requested-by, *")
146146
w.Header().Set("Access-Control-Allow-Methods", "GET, PUT, POST, DELETE, OPTIONS")
@@ -155,7 +155,7 @@ func main() {
155155
// OK-ish: the input origin header is validated against a whitelist.
156156
origin := req.Header.Get("Origin")
157157
if origin != "" && (originSuffix == "" || AccessControlAllowOrigins[origin]) {
158-
w.Header().Set("Access-Control-Allow-Origin", origin)
158+
w.Header().Set("Access-Control-Allow-Origin", origin) // $ SPURIOUS: Alert
159159
w.Header().Set("Access-Control-Allow-Credentials", "true")
160160
w.Header().Set("Access-Control-Allow-Headers", "Content-Type, x-requested-by, *")
161161
w.Header().Set("Access-Control-Allow-Methods", "GET, PUT, POST, DELETE, OPTIONS")
@@ -170,7 +170,7 @@ func main() {
170170
origin := req.Header.Get("origin")
171171
if origin != "" && origin != "null" {
172172
if len(AccessControlAllowOrigins) == 0 || AccessControlAllowOrigins[origin] {
173-
w.Header().Set("Access-Control-Allow-Origin", origin)
173+
w.Header().Set("Access-Control-Allow-Origin", origin) // $ SPURIOUS: Alert
174174
w.Header().Set("Access-Control-Allow-Credentials", "true")
175175
}
176176
} else {

0 commit comments

Comments
 (0)