Rust: Test deterministic dependency configuration selection

Add tests for extraction of dependency files with different features
enabled in different manifest files.

Author: paldepind

rust/extractor/src/configuration.rs

@@ -126,20 +126,19 @@ mod tests {
             }
             cfg
         };
-        let root = crate::cwd().unwrap();
-        let manifest = |path| ProjectManifest::from_manifest_file(root.join(path)).unwrap();
         let candidates = [
-            (manifest("z/Cargo.toml"), cfg(&["z"])),
-            (manifest("a/Cargo.toml"), cfg(&["a", "b"])),
-            (manifest("b/Cargo.toml"), cfg(&["a", "b"])),
+            ("z", cfg(&["z"])),
+            ("a", cfg(&["a", "b"])),
+            ("b", cfg(&["a", "b"])),
         ];
         for order in [[0, 1, 2], [2, 1, 0]] {
             let mut plan = DependencyFiles::default();
-            for (manifest, cfg) in order.map(|index| &candidates[index]) {
-                plan.add_candidate(Path::new("lib.rs"), Some(cfg.clone()), manifest);
+            for index in order {
+                let (workspace, cfg) = &candidates[index];
+                plan.add_candidate(Path::new("lib.rs"), Some(cfg.clone()), Path::new(workspace));
             }
-            let expected = HashMap::from([(&candidates[2].0, vec![PathBuf::from("lib.rs")])]);
-            assert_eq!(plan.by_manifests(), expected);
+            let expected = HashMap::from([(Path::new("b"), vec![PathBuf::from("lib.rs")])]);
+            assert_eq!(plan.by_workspaces(), expected);
         }
     }
 }

rust/extractor/src/diagnostics.rs

@@ -292,7 +292,7 @@ mod tests {
     use super::*;
 
     #[test]
-    fn counts_unique_manifests() {
+    fn counts_unique_manifests_but_includes_reload_duration() {
         let steps: Vec<_> = ["a/Cargo.toml", "b/Cargo.toml", "a/Cargo.toml"]
             .into_iter()
             .map(|path| ExtractionStep {

rust/ql/integration-tests/dependency-features/.cargo/config.toml

@@ -0,0 +1,7 @@
+# Add a source definition backed by the directories in "dependencies"
+[source.test-dependencies]
+directory = "dependencies"
+
+# Map crates.io to our local source definition
+[source.crates-io]
+replace-with = "test-dependencies"

rust/ql/integration-tests/dependency-features/dependencies/alpha/.cargo-checksum.json

@@ -0,0 +1 @@
+{"files": {}, "package": null}

rust/ql/integration-tests/dependency-features/dependencies/alpha/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+name = "alpha"
+version = "0.1.0"
+edition = "2024"
+
+[features]
+a = []
+b = []

rust/ql/integration-tests/dependency-features/dependencies/alpha/src/lib.rs

@@ -0,0 +1,21 @@
+#[cfg(feature = "a")]
+pub fn a() {}
+
+#[cfg(feature = "b")]
+pub fn b() {}
+
+#[cfg(feature = "b")]
+#[macro_export]
+macro_rules! invoke {
+    () => {
+        $crate::b()
+    };
+}
+
+#[cfg(not(feature = "b"))]
+#[macro_export]
+macro_rules! invoke {
+    () => {
+        $crate::a()
+    };
+}

rust/ql/integration-tests/dependency-features/dependencies/beta/.cargo-checksum.json

@@ -0,0 +1 @@
+{"files": {}, "package": null}

rust/ql/integration-tests/dependency-features/dependencies/beta/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+name = "beta"
+version = "0.1.0"
+edition = "2024"
+
+[features]
+a = []
+b = []

rust/ql/integration-tests/dependency-features/dependencies/beta/src/lib.rs

@@ -0,0 +1,21 @@
+#[cfg(feature = "a")]
+pub fn a() {}
+
+#[cfg(feature = "b")]
+pub fn b() {}
+
+#[cfg(feature = "b")]
+#[macro_export]
+macro_rules! invoke {
+    () => {
+        $crate::b()
+    };
+}
+
+#[cfg(not(feature = "b"))]
+#[macro_export]
+macro_rules! invoke {
+    () => {
+        $crate::a()
+    };
+}

rust/ql/integration-tests/dependency-features/functions.ql

@@ -0,0 +1,13 @@
+import rust
+
+from Call c, string target
+where
+  c.getFile().getRelativePath() in [
+      "first/src/lib.rs", "second/src/lib.rs", "src/lib.rs", "build.rs"
+    ] and
+  (
+    target = c.getStaticTarget().getCanonicalPath()
+    or
+    not exists(c.getStaticTarget()) and target = "<unresolved>"
+  )
+select c, target