Keep Kotlin warning mode scoped to Kotlin compilation

Avoid propagating Kotlin warn=error to javac in rules_kotlin 2.4. Preserve Java warnings as warnings instead of suppressing the JDK 25 options category, and remove the local javac lint override.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jketema

java/kotlin-extractor/BUILD.bazel

@@ -91,8 +91,6 @@ _component_registrar_service = (
 kt_javac_options(
     name = "javac-options",
     release = "8",
-    # JDK 25 reports Java 8 option warnings; keep them from becoming errors via Kotlin's warn = "error".
-    x_lint = ["-options"],
 )
 
 [

misc/bazel/registry/modules/rules_kotlin/2.4.21-codeql.1/patches/codeql_do_not_propagate_kotlin_warning_mode_to_javac.patch

@@ -0,0 +1,26 @@
+Keep Kotlin warning settings scoped to Kotlin compilation. In particular, do not
+turn javac warnings into errors when Kotlin's warn = "error".
+--- a/kotlin/internal/jvm/compile.bzl
++++ b/kotlin/internal/jvm/compile.bzl
+@@ -1162,21 +1162,6 @@
+             for flag in javac_options_to_flags(plugin[JavacOptions])
+         ])
+ 
+-        # Compile the Java half with the same warning mode as the kotlin part, unless the javac
+-        # options (or a plugin's) already set one: a single `warn` value governs the whole target.
+-        # A per-diagnostic level in `x_warning_level` limits the derivation, because javac has no
+-        # equivalent of `-Xwarning-level`. A diagnostic kept at `warning` or `disabled` under
+-        # `warn = "error"` must not turn every javac warning into an error, and a diagnostic raised
+-        # to `warning` or `error` under `warn = "off"` must not silence every javac warning.
+-        if "-nowarn" not in javac_opts and "-Werror" not in javac_opts:
+-            kotlinc_warn = getattr(kotlinc_options, "warn", None) if kotlinc_options else None
+-            warning_levels = (getattr(kotlinc_options, "x_warning_level", None) if kotlinc_options else None) or {}
+-            levels = warning_levels.values()
+-            if kotlinc_warn == "off" and "error" not in levels and "warning" not in levels:
+-                javac_opts.append("-nowarn")
+-            elif kotlinc_warn == "error" and "warning" not in levels and "disabled" not in levels:
+-                javac_opts.append("-Werror")
+-
+         java_info = java_common.compile(
+             ctx,
+             source_files = srcs.java,

misc/bazel/registry/modules/rules_kotlin/2.4.21-codeql.1/source.json

@@ -3,7 +3,8 @@
     "url": "https://github.com/bazel-contrib/rules_kotlin/releases/download/v2.4.21/rules_kotlin-v2.4.21.tar.gz",
     "patches": {
         "codeql_add_language_version_option.patch": "sha256-ml0fzhPwNozMi6yKtEn9YLM8LSQE4BWiimdwYzennCo=",
-        "codeql_do_not_emit_jdeps.patch": "sha256-yoBFnSWJyeF+gyhX+03TMTnRxUQJjup/f/KORdxVsAE="
+        "codeql_do_not_emit_jdeps.patch": "sha256-yoBFnSWJyeF+gyhX+03TMTnRxUQJjup/f/KORdxVsAE=",
+        "codeql_do_not_propagate_kotlin_warning_mode_to_javac.patch": "sha256-IWR4wEbHNEcaAAwFnZA2uHy99kviyuLr5mjzc1TOTMs="
     },
     "patch_strip": 1
 }