Skip to content

ClientEntraceFactory. GetClientEntrance incorrect #1

Description

@jaksonlin

in ClientEntraceFactory. GetClientEntrance
it new the ClientEntrace for each call, which is incorrect because the container will be created multiple times.

Fix is to use signleton to hold the ClientEntrance, but we need to find a reliable way for user to inject other ITokenProvider later.

For now if the user uses the IClientEntrance created by the first time calling of GetClientEntrance all the way down - it should be fine. (call it only once and provide the ITokenProvider containing all things user needs)
Otherwise it will break the singletons maintained by the container.

These singletons are defined in FsBaseExecSvc/Registry/RPCClientRegistry.cs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions