From ecbe2b2e826f61ad70c134ad53ec1fa80faea9a5 Mon Sep 17 00:00:00 2001 From: kenzycodex Date: Wed, 11 Nov 2026 08:58:25 +0000 Subject: [PATCH 1/2] Set up the sandbox bank even when the demo key is invalid --- api/services/forge_seed.py | 10 +++++++--- api/tests/test_forge_seed.py | 13 +++++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/api/services/forge_seed.py b/api/services/forge_seed.py index d0e306e..ae69d06 100644 --- a/api/services/forge_seed.py +++ b/api/services/forge_seed.py @@ -104,9 +104,13 @@ def ensure_from_env() -> bool: did = False raw = os.getenv("FORGE_DEMO_API_KEY", "").strip() if raw: - ensure_demo(raw) - logger.info("The Forge demo institution is ready.") - did = True + # Its own try, so a bad demo key never stops the bank below being set up. + try: + ensure_demo(raw) + logger.info("The Forge demo institution is ready.") + did = True + except ValueError as exc: + logger.warning("Skipped the Forge demo institution: %s", exc) bank = os.getenv("FORGE_BRIDGE_INSTITUTION", "").strip() email = os.getenv("FORGE_CONSOLE_EMAIL", "").strip() password = os.getenv("FORGE_CONSOLE_PASSWORD", "") diff --git a/api/tests/test_forge_seed.py b/api/tests/test_forge_seed.py index 14e38cd..96d17c3 100644 --- a/api/tests/test_forge_seed.py +++ b/api/tests/test_forge_seed.py @@ -83,3 +83,16 @@ def test_a_random_key_is_issued_once_when_none_is_configured(): out = forge_seed.ensure_demo(None) assert out["issued_key"] and out["issued_key"].startswith("fbl_live_") assert forge_seed.ensure_demo(None)["issued_key"] is None + + +def test_a_bad_demo_key_does_not_stop_the_bank_being_set_up(monkeypatch): + from services import forge_seed + + calls = [] + monkeypatch.setenv("FORGE_DEMO_API_KEY", "not-a-valid-key") + monkeypatch.setenv("FORGE_BRIDGE_INSTITUTION", "xtradot") + monkeypatch.setenv("FORGE_CONSOLE_EMAIL", "team11@fable.ng") + monkeypatch.setenv("FORGE_CONSOLE_PASSWORD", "long-enough-password") + monkeypatch.setattr(forge_seed, "ensure_bank", lambda *a: calls.append(a) or {"customers": 5, "history": 0}) + assert forge_seed.ensure_from_env() is True + assert calls == [("xtradot", "team11@fable.ng", "long-enough-password")] From 301df6f8ca4e41bc941f7453951d70101e9db045 Mon Sep 17 00:00:00 2001 From: kenzycodex Date: Wed, 11 Nov 2026 08:58:25 +0000 Subject: [PATCH 2/2] Log why the Forge setup failed at startup --- api/main.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/main.py b/api/main.py index 5402837..03f4c85 100644 --- a/api/main.py +++ b/api/main.py @@ -88,7 +88,9 @@ async def lifespan(_app: FastAPI): forge_seed.ensure_from_env() # the Forge demo puts itself back after a restart except Exception as exc: # noqa: BLE001 - never block startup on this - logger.warning("Could not set up the Forge demo at startup: %s", type(exc).__name__) + # A ValueError carries a fixed setup message (never a secret), so show it. + reason = str(exc) if isinstance(exc, ValueError) else type(exc).__name__ + logger.warning("Could not set up the Forge demo at startup: %s", reason) from services import scheduler register_jobs()