dash/src/test/governance_validators_tests.cpp at develop · knst/dash · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
// Copyright (c) 2014-2025 The Dash Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <governance/object.h>
#include <util/strencodings.h>

#include <test/data/proposals_invalid.json.h>
#include <test/data/proposals_valid.json.h>

#include <test/util/json.h>
#include <test/util/setup_common.h>

#include <limits>
#include <string>

#include <boost/test/unit_test.hpp>

#include <univalue.h>

BOOST_FIXTURE_TEST_SUITE(governance_validators_tests, BasicTestingSetup)

static std::string CreateEncodedProposalObject(const UniValue& objJSON)
{
    UniValue innerArray(UniValue::VARR);
    innerArray.push_back(UniValue("proposal"));
    innerArray.push_back(objJSON);

    UniValue outerArray(UniValue::VARR);
    outerArray.push_back(innerArray);

    std::string strData = outerArray.write();
    std::string strHex = HexStr(strData);
    return strHex;
}

BOOST_AUTO_TEST_CASE(valid_proposals_test)
{
    // all proposals are valid but expired
    UniValue tests = read_json(std::string(json_tests::proposals_valid, json_tests::proposals_valid + sizeof(json_tests::proposals_valid)));

    BOOST_CHECK_MESSAGE(tests.size(), "Empty `tests`");
    for(size_t i = 0; i < tests.size(); ++i) {
        const UniValue& objProposal = tests[i][0];
        bool fAllowScript = tests[i][1].get_bool();

        // legacy format
        std::string strHexData1 = CreateEncodedProposalObject(objProposal);
        std::string strErrorMessages;
        BOOST_CHECK(!governance::ValidateProposal(strHexData1, strErrorMessages, /*fCheckExpiration=*/true, fAllowScript));
        BOOST_CHECK_EQUAL(strErrorMessages, "Proposal must be a JSON object;JSON parsing error;");

        // current format
        std::string strHexData2 = HexStr(objProposal.write());
        std::string strErrorMessages2;
        BOOST_CHECK_MESSAGE(governance::ValidateProposal(strHexData2, strErrorMessages2, /*fCheckExpiration=*/false,
                                                         fAllowScript),
                            strErrorMessages2);
        std::string strErrorMessages3;
        BOOST_CHECK_MESSAGE(!governance::ValidateProposal(strHexData2, strErrorMessages3, /*fCheckExpiration=*/true,
                                                          fAllowScript),
                            strErrorMessages3);
    }
}

BOOST_AUTO_TEST_CASE(invalid_proposals_test)
{
    // all proposals are invalid regardless of being expired or not
    // (i.e. we don't even check for expiration here)
    UniValue tests = read_json(std::string(json_tests::proposals_invalid, json_tests::proposals_invalid + sizeof(json_tests::proposals_invalid)));

    BOOST_CHECK_MESSAGE(tests.size(), "Empty `tests`");
    for(size_t i = 0; i < tests.size(); ++i) {
        const UniValue& objProposal = tests[i];

        // legacy format
        std::string strHexData1 = CreateEncodedProposalObject(objProposal);
        std::string strErrorMessages1;
        BOOST_CHECK(!governance::ValidateProposal(strHexData1, strErrorMessages1, /*fCheckExpiration=*/true,
                                                  /*fAllowScript=*/false));
        std::string strErrorMessages1b;
        BOOST_CHECK_MESSAGE(!governance::ValidateProposal(strHexData1, strErrorMessages1b, /*fCheckExpiration=*/false,
                                                          /*fAllowScript=*/false),
                            strErrorMessages1b);

        // current format
        std::string strHexData2 = HexStr(objProposal.write());
        std::string strErrorMessages2;
        BOOST_CHECK_MESSAGE(!governance::ValidateProposal(strHexData2, strErrorMessages2, /*fCheckExpiration=*/false,
                                                          /*fAllowScript=*/false),
                            strErrorMessages2);
    }
}

BOOST_AUTO_TEST_CASE(extreme_end_epoch_is_not_expired)
{
    UniValue proposal{UniValue::VOBJ};
    proposal.pushKV("end_epoch", std::numeric_limits<int64_t>::max());
    proposal.pushKV("name", "extreme-end-epoch");
    proposal.pushKV("payment_address", "XpG61qAVhdyN7AqVZQsHfJL7AEk4dPVinc");
    proposal.pushKV("payment_amount", 1.0);
    proposal.pushKV("start_epoch", std::numeric_limits<int64_t>::max() - 1);
    proposal.pushKV("type", 1);
    proposal.pushKV("url", "https://example.com");

    std::string error;
    BOOST_CHECK_MESSAGE(governance::ValidateProposal(HexStr(proposal.write()), error,
                                                     /*fCheckExpiration=*/true, /*fAllowScript=*/false),
                        error);
}

BOOST_AUTO_TEST_SUITE_END()