From bf59863dc932e6f16015cb814410c37d9f3b0154 Mon Sep 17 00:00:00 2001 From: Nickolas Dimitrakas Date: Mon, 16 Nov 2026 23:45:22 -0500 Subject: [PATCH 1/2] ci: run the release draft in a release environment --- .github/workflows/release-draft.yml | 1 + .github/workflows/trunk-upgrade.yml | 25 ------------------------- 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/.github/workflows/release-draft.yml b/.github/workflows/release-draft.yml index cbf3c99..ccf90c5 100644 --- a/.github/workflows/release-draft.yml +++ b/.github/workflows/release-draft.yml @@ -19,6 +19,7 @@ jobs: create-release-pr: name: Create Release PR runs-on: ubuntu-latest + environment: release steps: # A major bump off main would publish the next major from maintenance code. - name: Block major bump outside main diff --git a/.github/workflows/trunk-upgrade.yml b/.github/workflows/trunk-upgrade.yml index 6a50209..db7dd64 100644 --- a/.github/workflows/trunk-upgrade.yml +++ b/.github/workflows/trunk-upgrade.yml @@ -2,11 +2,6 @@ name: Run trunk upgrade on: workflow_call: - secrets: - SDK_RELEASE_GITHUB_CLIENT_ID: - required: true - SDK_RELEASE_GITHUB_APP_PRIVATE_KEY: - required: true schedule: - cron: 0 0 1 * * workflow_dispatch: @@ -15,29 +10,9 @@ permissions: contents: read jobs: - generate-and-call-upgrade: - runs-on: ubuntu-latest - outputs: - generated-token: ${{ steps.generate-token.outputs.token }} - steps: - - name: Generate a token - id: generate-token - uses: actions/create-github-app-token@64ab729a6294000f5aa4a4bc0b73d1f32bc45510 # v3.3.0 - with: - client-id: ${{ secrets.SDK_RELEASE_GITHUB_CLIENT_ID }} - private-key: ${{ secrets.SDK_RELEASE_GITHUB_APP_PRIVATE_KEY }} - owner: ${{ github.repository_owner }} - repositories: | - react-native-mparticle - permission-contents: write - permission-pull-requests: write - trunk-upgrade: - needs: generate-and-call-upgrade name: Run trunk upgrade permissions: contents: write pull-requests: write uses: ROKT/rokt-workflows/.github/workflows/trunk-upgrade.yml@da0c5fd5d38e9cf113a24ec9aaea079cc7d0bc40 # main - with: - token: ${{ needs.generate-and-call-upgrade.outputs.generated-token }} From 0622cd88a91a3f0071c9411b32bceeba07a41010 Mon Sep 17 00:00:00 2001 From: Nickolas Dimitrakas Date: Tue, 17 Nov 2026 13:06:39 -0500 Subject: [PATCH 2/2] ci: drop the token input left behind by the main merge Merging main brought back Trunk Upgrade's `with: token:`, which reads an output of the token job this pull request removes. actionlint rejects the reference, and the shared workflow already falls back to `github.token`. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/trunk-upgrade.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/trunk-upgrade.yml b/.github/workflows/trunk-upgrade.yml index c6ecb8d..edda7ac 100644 --- a/.github/workflows/trunk-upgrade.yml +++ b/.github/workflows/trunk-upgrade.yml @@ -16,5 +16,3 @@ jobs: contents: write pull-requests: write uses: ROKT/rokt-workflows/.github/workflows/trunk-upgrade.yml@da0c5fd5d38e9cf113a24ec9aaea079cc7d0bc40 - with: - token: ${{ needs.generate-and-call-upgrade.outputs.generated-token }}