diff --git a/numpy_questions.py b/numpy_questions.py index 21fcec4b..dacff164 100644 --- a/numpy_questions.py +++ b/numpy_questions.py @@ -37,12 +37,13 @@ def max_index(X): If the input is not a numpy array or if the shape is not 2D. """ - i = 0 - j = 0 - - # TODO - - return i, j + if not isinstance(X, np.ndarray): + raise ValueError('The input must be a numpy array') + elif X.ndim != 2: + raise ValueError('The shape of the array must be 2D') + else: + i, j = np.unravel_index(np.argmax(X), X.shape) + return int(i), int(j) def wallis_product(n_terms): @@ -62,6 +63,9 @@ def wallis_product(n_terms): pi : float The approximation of order `n_terms` of pi using the Wallis product. """ - # XXX : The n_terms is an int that corresponds to the number of - # terms in the product. For example 10000. - return 0. + if n_terms == 0: + pi = 1 + else: + pi = 2 * np.prod([(4*n**2)/(4*n**2-1) for n + in range(1, (n_terms + 1))]) + return float(pi) diff --git a/sklearn_questions.py b/sklearn_questions.py index 948c2e54..1533f1d4 100644 --- a/sklearn_questions.py +++ b/sklearn_questions.py @@ -23,53 +23,85 @@ from sklearn.base import BaseEstimator from sklearn.base import ClassifierMixin from sklearn.utils.validation import check_X_y -from sklearn.utils.validation import check_array from sklearn.utils.validation import check_is_fitted from sklearn.utils.validation import validate_data from sklearn.utils.multiclass import check_classification_targets class OneNearestNeighbor(ClassifierMixin, BaseEstimator): - "OneNearestNeighbor classifier." + """OneNearestNeighbor classifier.""" def __init__(self): # noqa: D107 pass def fit(self, X, y): - """Write docstring. - - And describe parameters + """Fit the nearest neighbor classifier on the training data. + + Parameters + ---------- + X : ndarray of shape (n_samples, n_features) + The training samples + y : ndarray of shape (n_samples,) + The target labels of the training samples + + Returns + ------- + self : object + The fitted estimator """ - X, y = check_X_y(X, y) + X, y = validate_data(self, X, y) check_classification_targets(y) self.classes_ = np.unique(y) self.n_features_in_ = X.shape[1] - # XXX fix + self.X_train_ = X + self.y_train_ = y return self def predict(self, X): - """Write docstring. - - And describe parameters + """Predict the labels of the input samples. + + Parameters + ---------- + X : ndarray of shape (n_samples, n_features) + The samples to classify + + Returns + ------- + y_pred : ndarray of shape (n_samples,) + The predicted label of each sample, i.e. the label of its + nearest training sample """ check_is_fitted(self) - X = check_array(X) + X = validate_data(self, X, reset=False) y_pred = np.full( shape=len(X), fill_value=self.classes_[0], dtype=self.classes_.dtype ) - # XXX fix + for i in range(len(X)): + dist = np.sqrt(np.sum((X[i] - self.X_train_)**2, axis=1)) + idx_min = np.argmin(dist) + y_pred[i] = self.y_train_[idx_min] return y_pred def score(self, X, y): - """Write docstring. - - And describe parameters + """Return the accuracy of the classifier on the given data. + + Parameters + ---------- + X : ndarray of shape (n_samples, n_features) + The test samples + y : ndarray of shape (n_samples,) + The true labels of the test samples + + Returns + ------- + score : float + The fraction of correctly classified samples """ X, y = check_X_y(X, y) y_pred = self.predict(X) - # XXX fix - return y_pred.sum() + accur = np.mean(y_pred == y) + return accur