Merge pull request #7 from ni/users/pthong/remove_cli_env_var

Removed NITLSCONFIG_CLI_ENV_VAR

Author: pkthong

README.md

@@ -8,7 +8,7 @@ Installed and imported as `nitlsconfig`; developed at
 
 ## Runtime dependencies
 
-- nitlsconfig executable, discoverable, or explicit path to NITLSCONFIG_CLI
+- nitlsconfig executable, discoverable.
 
 ## Install
 

src/nitlsconfig/cli.py

@@ -4,9 +4,6 @@
 
 import argparse
 import json
-import os
-import pathlib
-import platform
 import subprocess  # nosec B404 - required to invoke the trusted nitlsconfig CLI
 import sys
 from dataclasses import dataclass, field
@@ -15,8 +12,6 @@
 
 ALLOWED_SCOPES: Tuple[str, ...] = ("client", "server")
 
-NITLSCONFIG_CLI_ENV_VAR = "NITLSCONFIG_CLI"
-
 # Expected JSON root keys from nitlsconfig output.
 ROLE_TO_JSON_ROOT_KEY = {
     "client": "client",
@@ -334,30 +329,9 @@ def run_nitlsconfig_command(
             timeout=30,
         )  # nosec B603 - argv is passed shell-free and executable selection is controlled
     except FileNotFoundError as ex:
-        fallback_root = os.environ.get(NITLSCONFIG_CLI_ENV_VAR)
-        if fallback_root and fallback_root != executable:
-            suffix = ".exe" if platform.system().lower() == "windows" else ""
-            fallback_executable = pathlib.Path(fallback_root) / f"nitlsconfig{suffix}"
-            fallback_executable_str = str(fallback_executable)
-            fallback_argv = [fallback_executable_str, *command_args]
-            try:
-                completed = subprocess.run(
-                    fallback_argv,
-                    capture_output=True,
-                    text=True,
-                    check=False,
-                    timeout=30,
-                )  # nosec B603 - argv is passed shell-free and fallback executable is explicit
-                argv = fallback_argv
-            except FileNotFoundError as fallback_ex:
-                raise ExecutableNotFoundError(
-                    "Unable to find nitlsconfig executable. "
-                    f"Tried {executable!r} and {NITLSCONFIG_CLI_ENV_VAR}={fallback_root!r}."
-                ) from fallback_ex
-        else:
-            raise ExecutableNotFoundError(
-                "Unable to find nitlsconfig executable. " f"Tried {executable!r}."
-            ) from ex
+        raise ExecutableNotFoundError(
+            "Unable to find nitlsconfig executable. " f"Tried {executable!r}."
+        ) from ex
 
     if completed.returncode != 0:
         command_display = " ".join(argv)