Skip to content

Tracing configuration shows up in diagnostics #4450

Description

@reinkrul

Tracing config shows up in /status/diagnostics:

tracing:
    tracing:
        enabled: true
        endpoint: aspire-stable:4318
        insecure: true
        service_name: node-stable

Why this is a bad idea:

The node's diagnostics are semi-public, some parties expose it to the public internet. We always recommended to keep internal, but never explicitly required parties to do so. The tracing info exposes internal details of the vendor's network.

Also, as it's also just mimicking config, there's no need to return this - it's not runtime information.

Fix

Remove it from diagnostics.

Backports

Backport to v6.2 (in which it was introduced).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions