Skip to content

Change in the manner the parameter 'time' is being computed for 2D Barchan dune case: Intentional or bug? #224

Description

@niketagrawal

Error description

Tests fail from the commit b63a8f0 on wards because the array values of the parameter 'time' computed by the code for the 2D Barchan dune case is not the same as the reference it's being compared against.

Root cause

Code changes in the commit b63a8f0 that could be the reason for this.

How to reproduce the issue?

This error can't be reproduced in the main branch because of the presence of another issue #221. A pull request has already been created to fix it. Until the pull request is merged, you can reproduce the issue by adding the fix of pull request #221 locally in your branch, delete the directory aeolis/tests/regression_tests/inputs/1D, and run the tests again.

Fix

Are the code changes in the commit b63a8f0 that changes the way 'time' is computed for the 2D Barchan dune case intentional?
If yes, then the netcdf file used as a reference output in the tests for the 1D cases must be replaced with a netcdf generated with the new changes. Otherwise, the changes must be reverted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions