From f6e07efd784d90692cbecb5b2938556f29b5fb3e Mon Sep 17 00:00:00 2001 From: Mike Zeller Date: Fri, 30 Oct 2026 19:38:15 +0000 Subject: [PATCH] vsock test flake in credit_update_sent_after_flushing_half_buffer Pull Request: https://github.com/oxidecomputer/propolis/pull/1242 --- lib/propolis/src/vsock/poller.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/propolis/src/vsock/poller.rs b/lib/propolis/src/vsock/poller.rs index d3d18513f..0646d9766 100644 --- a/lib/propolis/src/vsock/poller.rs +++ b/lib/propolis/src/vsock/poller.rs @@ -1516,7 +1516,9 @@ mod test { accepted.read_exact(&mut buf).unwrap(); assert!(buf.iter().all(|&b| b == 0xAB)); - // Look for a CREDIT_UPDATE in the RX used entries + // Look for a CREDIT_UPDATE in the RX used entries. + // NB: It arrives asynchronously so we attempt to wait on the condition. + wait_for_condition(|| harness.rx_used_idx() >= 2, 5000); let rx_used = harness.rx_used_idx(); assert!(rx_used >= 2, "expected at least RESPONSE + CREDIT_UPDATE");