From 4e0119ce48556c22a640b4912b82b8efaa2aac29 Mon Sep 17 00:00:00 2001
From: User7142 <5984280+User7142@users.noreply.github.com>
Date: Tue, 20 Oct 2026 16:53:48 +0200
Subject: [PATCH] test: cover parallel group-filtered runs whose workers end on
 fully filtered files

A worker's serialized TestResult only carries the `numberOfTests` of the
last file it executed. When that file has all of its tests excluded by
`--group`/`--exclude-group`, the merged result used to claim the suite was
empty and the run exited 1 despite a green summary (PHPUnit enables
`failOnEmptyTestSuite` implicitly for explicit test selections).

942d6aea fixed this in `WrapperRunner::numberOfTestsSeenByWorker()`; these
tests pin the behaviour:

- with `--processes=1` the single worker deterministically ends on
  ZTest.php, whose only test is outside the filtered group, so the run
  must exit 0 (fails when the fix is reverted)
- a selection that matches no tests at all must still exit non-zero

Refs #1483
---
 .../ParallelGroupFilteredLastFile/ATest.php   |  5 ++++
 .../ParallelGroupFilteredLastFile/ZTest.php   |  5 ++++
 tests/Visual/Parallel.php                     | 25 +++++++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ATest.php
 create mode 100644 tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ZTest.php

diff --git a/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ATest.php b/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ATest.php
new file mode 100644
index 000000000..16b1f5b3f
--- /dev/null
+++ b/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ATest.php
@@ -0,0 +1,5 @@
+<?php
+
+it('belongs to the filtered group', function () {
+    expect(true)->toBeTrue();
+})->group('filtered');
diff --git a/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ZTest.php b/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ZTest.php
new file mode 100644
index 000000000..126c80243
--- /dev/null
+++ b/tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ZTest.php
@@ -0,0 +1,5 @@
+<?php
+
+it('does not belong to the filtered group', function () {
+    expect(true)->toBeTrue();
+});
diff --git a/tests/Visual/Parallel.php b/tests/Visual/Parallel.php
index a775c9926..ada2fa1ce 100644
--- a/tests/Visual/Parallel.php
+++ b/tests/Visual/Parallel.php
@@ -56,3 +56,28 @@
         ->toContain('Tests:    2 passed (2 assertions)')
         ->toContain('Parallel: 3 processes');
 })->skipOnWindows();
+
+test('parallel group-filtered run is not considered empty when a worker ends on a fully filtered file', function (): void {
+    $process = new Process(
+        ['php', 'bin/pest', '--parallel', '--processes=1', '--group=filtered', 'tests/Fixtures/Suites/ParallelGroupFilteredLastFile'],
+        dirname(__DIR__, 2),
+        ['COLLISION_PRINTER' => 'DefaultPrinter', 'COLLISION_IGNORE_DURATION' => 'true', 'PAO_DISABLE' => '1'],
+    );
+
+    $process->run();
+
+    expect(removeAnsiEscapeSequences($process->getOutput()))->toContain('Tests:    1 passed (1 assertions)')
+        ->and($process->getExitCode())->toBe(0);
+})->skipOnWindows();
+
+test('parallel group-filtered run still fails when the selection matches no tests', function (): void {
+    $process = new Process(
+        ['php', 'bin/pest', '--parallel', '--processes=3', '--group=missing', 'tests/Fixtures/Suites/ParallelGroupFilteredLastFile'],
+        dirname(__DIR__, 2),
+        ['COLLISION_PRINTER' => 'DefaultPrinter', 'COLLISION_IGNORE_DURATION' => 'true', 'PAO_DISABLE' => '1'],
+    );
+
+    $process->run();
+
+    expect($process->getExitCode())->not->toBe(0);
+})->skipOnWindows();