Repository navigation
Fix GH-24523: UAF in zend_test_compile_to_ast() on parse error - #24524
Merged
Merged
Conversation
Contributor
Author
|
The WINDOWS_X64_ZTS failure isn't caused by this change. The SQL Server Express install failed in the Setup step, before the build started. |
ndossche
self-requested a review
October 22, 2026 13:02
ndossche
approved these changes
Oct 22, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Thanks, this is right.
It's fortunately not visible to users since zend_test is internal.
lazerg
pushed a commit
to lazerg/php-src
that referenced
this pull request
Oct 22, 2026
* PHP-8.5: Fix phpGH-24523: UAF in zend_test_compile_to_ast() on parse error (php#24524)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a parse error zend_compile_string_to_ast() frees the arena and returns NULL, but zend_test_compile_to_ast() still destroyed the arena it got back. It now returns early when there is no AST, same as get_default_via_ast() in zend_API.c.
Fixes #24523