Repository navigation
Conversation
ndossche
reviewed
Oct 31, 2026
| newentry.filename_len = tmp_len; | ||
| newentry.fp_refcount = 0; | ||
|
|
||
| if (newentry.link) { |
Member
There was a problem hiding this comment.
Won't this code cause a leak if phar_copy_entry_fp fails down below?
Contributor
Author
There was a problem hiding this comment.
Yes, it would. I now free both in the error path in 1e44fc0.
Contributor
Author
|
The Alpine ASan failure is ext/pcntl/tests/001.phpt, which isn't related to this change and passed on the previous push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phar::copy()memcpy()s the old entry into the new one, solinkandtmpend up shared between the two manifest entries and both free them on shutdown. This duplicates them the same wayphar_update_cached_entry()andphar_convert_to_other()already do;tmpis hit when copying a mounted file.Fixes #25092