From e549dfb1dfb189791d7e4563d6e97c556c0f28e6 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Mon, 19 Oct 2026 01:00:44 -0500 Subject: [PATCH] Run EPV through the organization's strict EPV workflow EPV exits 0 on Error findings, so they never failed this workflow, and pointing it at the extension folder gave a false "Packaging structure" error. EPV now runs in an epv job that calls phpbbmodders/.github's reusable EPV workflow (v1), which fails on any Fatal or Error finding not listed in .github/epv-allowed.txt. .github/epv-allowed.txt lists this extension's justified findings, each with its reason. Co-Authored-By: Claude Opus 5.5 --- .github/epv-allowed.txt | 8 ++++++++ .github/workflows/tests.yml | 9 +++++++++ 2 files changed, 17 insertions(+) create mode 100644 .github/epv-allowed.txt diff --git a/.github/epv-allowed.txt b/.github/epv-allowed.txt new file mode 100644 index 0000000..b390cc9 --- /dev/null +++ b/.github/epv-allowed.txt @@ -0,0 +1,8 @@ +# EPV findings this extension keeps on purpose, checked by the epv job in +# .github/workflows/tests.yml. One finding per line as EPV prints it, without +# "on line N", with paths relative to the extension; give the reason above it. + +# ext.php reads phpBB's own serialized migration dependency lists when it moves +# an install made under the old vendor name, with allowed_classes off, so no +# objects can be created. +Error: Using unserialize in /ext.php diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3ec0c33..3dcaf30 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -29,6 +29,8 @@ jobs: with: # Your extension vendor/package name EXTNAME: phpbbmodders/editedpostsunread + # EPV runs in the epv job below instead + EPV: 0 # Run MySQL/MariaDB tests? RUN_MYSQL_JOBS: 0 @@ -48,3 +50,10 @@ jobs: # The MySQL and PostgreSQL jobs run tests across multiple PHP versions. # List the PHP versions you want your extension tested with. PHP_VERSION_MATRIX: '["8.2", "8.3", "8.4"]' + + # EPV (Extension Pre Validator), failing on any Fatal or Error finding not + # listed in .github/epv-allowed.txt + epv: + uses: phpbbmodders/.github/.github/workflows/epv.yml@v1 + with: + EXTNAME: phpbbmodders/editedpostsunread