From 73c054a1e5fbf9a1127d2ffb0ca66a889fdc05a7 Mon Sep 17 00:00:00 2001 From: Zayd Date: Sat, 24 Oct 2026 06:44:34 -0700 Subject: [PATCH 1/3] fix(cursor): read account limits for SDK browser sign-ins --- .../provider-cursor/src/server/driver.test.ts | 44 ++++++++++++++++++- packages/provider-cursor/src/server/driver.ts | 2 +- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/packages/provider-cursor/src/server/driver.test.ts b/packages/provider-cursor/src/server/driver.test.ts index 5a3202fd20e4d..6e2730bed6479 100644 --- a/packages/provider-cursor/src/server/driver.test.ts +++ b/packages/provider-cursor/src/server/driver.test.ts @@ -3,6 +3,7 @@ import type { AgentOptions, SDKModel } from "@cursor/sdk"; import * as NodeServices from "@effect/platform-node/NodeServices"; import { expect, it } from "@effect/vitest"; import { + DEFAULT_SERVER_SETTINGS, MessageId, NodeId, ProjectId, @@ -21,6 +22,8 @@ import * as Option from "effect/Option"; import * as Stream from "effect/Stream"; import { vi } from "vite-plus/test"; import * as HttpClient from "effect/http/HttpClient"; +import * as HttpClientResponse from "effect/http/HttpClientResponse"; +import * as HostProcess from "@t3tools/shared/HostProcess"; import { DEFAULT_HANDOFF_TOKEN_CAP, @@ -105,9 +108,31 @@ it.layer(layerTest)("CursorDriver", (it) => { environment: [{ name: "CURSOR_API_KEY", value: "", sensitive: true }], config: CursorDriver.defaultConfig(), }; + const settingsControl = yield* TestProviderHost.TestProviderHostSettings; + yield* settingsControl.set({ + ...DEFAULT_SERVER_SETTINGS, + cursorKeychainUsageEnabled: true, + }); + yield* Effect.addFinalizer(() => settingsControl.set(DEFAULT_SERVER_SETTINGS)); const openedKeys: Array = []; let closed = 0; const instance = yield* CursorDriver.create(input).pipe( + Effect.provideService(HostProcess.Platform, "darwin"), + Effect.provideService(CursorKeychain.CursorKeychain, { + accessToken: Effect.succeed("keychain-account-token"), + }), + Effect.provideService( + HttpClient.HttpClient, + HttpClient.make((request) => { + expect(request.headers.authorization).toBe("Bearer keychain-account-token"); + return Effect.succeed( + HttpClientResponse.fromWeb( + request, + Response.json({ planUsage: { totalPercentUsed: 42 } }), + ), + ); + }), + ), Effect.provideService(CursorAgentSdk.CursorAgentSdkRunner, { assertComplete: Effect.void, open: (request) => @@ -132,6 +157,7 @@ it.layer(layerTest)("CursorDriver", (it) => { Effect.map(Option.getOrThrow), ); expect(me).toHaveBeenCalledWith({ apiKey: "instance-browser-key" }); + expect((yield* instance.snapshot.refresh).usageLimits?.windows[0]?.usedPercent).toBe(42); expect(yield* instance.snapshot.getSnapshot).toMatchObject({ status: "ready", auth: { @@ -158,7 +184,23 @@ it.layer(layerTest)("CursorDriver", (it) => { yield* runtime.ensureThread({ threadId, modelSelection, runtimePolicy }); expect(openedKeys).toEqual(["instance-browser-key"]); expect(closed).toBe(0); - const recreated = yield* CursorDriver.create(input); + const recreated = yield* CursorDriver.create(input).pipe( + Effect.provideService(HostProcess.Platform, "darwin"), + Effect.provideService(CursorKeychain.CursorKeychain, { + accessToken: Effect.succeed("keychain-account-token"), + }), + Effect.provideService( + HttpClient.HttpClient, + HttpClient.make((request) => + Effect.succeed( + HttpClientResponse.fromWeb( + request, + Response.json({ planUsage: { totalPercentUsed: 42 } }), + ), + ), + ), + ), + ); expect((yield* recreated.snapshot.refresh).auth.status).toBe("authenticated"); yield* instance.auth!.logout(Effect.void); expect(closed).toBe(1); diff --git a/packages/provider-cursor/src/server/driver.ts b/packages/provider-cursor/src/server/driver.ts index 6937c7aa88a71..a203412f20dd1 100644 --- a/packages/provider-cursor/src/server/driver.ts +++ b/packages/provider-cursor/src/server/driver.ts @@ -233,7 +233,7 @@ export const CursorDriver: ProviderDriver< Effect.flatMap((settings) => readCursorUsageLimits( effectiveConfig, - { ...processEnv, CURSOR_API_KEY: apiKey }, + { ...processEnv, CURSOR_API_KEY: auth.usesApiKey ? apiKey : undefined }, settings.cursorKeychainUsageEnabled, ), ), From 46f128c228ebbca03eb70c06bed07359295b9027 Mon Sep 17 00:00:00 2001 From: Zayd Date: Sat, 24 Oct 2026 07:45:46 -0700 Subject: [PATCH 2/3] test(cursor): check account limits after driver recreation --- packages/provider-cursor/src/server/driver.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/provider-cursor/src/server/driver.test.ts b/packages/provider-cursor/src/server/driver.test.ts index 6e2730bed6479..2ceffcae4edba 100644 --- a/packages/provider-cursor/src/server/driver.test.ts +++ b/packages/provider-cursor/src/server/driver.test.ts @@ -201,7 +201,9 @@ it.layer(layerTest)("CursorDriver", (it) => { ), ), ); - expect((yield* recreated.snapshot.refresh).auth.status).toBe("authenticated"); + const recreatedSnapshot = yield* recreated.snapshot.refresh; + expect(recreatedSnapshot.auth.status).toBe("authenticated"); + expect(recreatedSnapshot.usageLimits?.windows[0]?.usedPercent).toBe(42); yield* instance.auth!.logout(Effect.void); expect(closed).toBe(1); expect((yield* instance.snapshot.getSnapshot).auth.status).toBe("unauthenticated"); From 82bb50160d4aab407faa1e61fc640e8927f054f1 Mon Sep 17 00:00:00 2001 From: Zayd Date: Fri, 30 Oct 2026 07:50:25 -0700 Subject: [PATCH 3/3] test(cursor): isolate the browser-usage fixture from inherited Cursor settings The instance fixture now also clears CURSOR_AUTH_TOKEN and CURSOR_API_ENDPOINT and pins AGENT_CLI_CREDENTIAL_STORE to "default", so the mocked Keychain path is taken regardless of the developer's shell environment. --- packages/provider-cursor/src/server/driver.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/provider-cursor/src/server/driver.test.ts b/packages/provider-cursor/src/server/driver.test.ts index 2ceffcae4edba..0201f93a6df7f 100644 --- a/packages/provider-cursor/src/server/driver.test.ts +++ b/packages/provider-cursor/src/server/driver.test.ts @@ -105,7 +105,13 @@ it.layer(layerTest)("CursorDriver", (it) => { instanceId: ProviderInstanceId.make("cursor-browser-persisted"), displayName: "Personal Cursor", enabled: true, - environment: [{ name: "CURSOR_API_KEY", value: "", sensitive: true }], + // Clear inherited Cursor settings so the fixture always takes the mocked Keychain path. + environment: [ + { name: "CURSOR_API_KEY", value: "", sensitive: true }, + { name: "CURSOR_AUTH_TOKEN", value: "", sensitive: true }, + { name: "CURSOR_API_ENDPOINT", value: "", sensitive: false }, + { name: "AGENT_CLI_CREDENTIAL_STORE", value: "default", sensitive: false }, + ], config: CursorDriver.defaultConfig(), }; const settingsControl = yield* TestProviderHost.TestProviderHostSettings;