From c00fa52cff67fa9188432e96edcdee1e4ff9b258 Mon Sep 17 00:00:00 2001 From: Sergii Dumyk <1376107+realsergii@users.noreply.github.com> Date: Mon, 16 Nov 2026 08:01:08 +0200 Subject: [PATCH 1/4] feat(web): add a setting to turn off hover previews Adds Settings > Appearance > Hover previews (default on). When off, the shared thread hover card (sidebar rows, subagent cards) and the timeline minimap message preview stop rendering. Navigation and button tooltips are unchanged. Co-Authored-By: Claude Opus 5.5 --- .../ThreadHoverCard.browser.test.tsx | 44 +++++++++++ apps/web/src/components/ThreadHoverCard.tsx | 7 ++ .../chat/ThreadRelationshipsControl.tsx | 8 +- .../chat/TimelineMinimap.browser.test.tsx | 74 +++++++++++++++++++ .../src/components/chat/TimelineMinimap.tsx | 11 ++- .../settings/AppearanceSettingsPanel.tsx | 22 ++++++ .../components/settings/SettingsPanels.tsx | 4 + .../src/components/settings/settingsSearch.ts | 6 ++ packages/contracts/src/settings.ts | 2 + 9 files changed, 171 insertions(+), 7 deletions(-) create mode 100644 apps/web/src/components/ThreadHoverCard.browser.test.tsx create mode 100644 apps/web/src/components/chat/TimelineMinimap.browser.test.tsx diff --git a/apps/web/src/components/ThreadHoverCard.browser.test.tsx b/apps/web/src/components/ThreadHoverCard.browser.test.tsx new file mode 100644 index 0000000000000..420d0a8998121 --- /dev/null +++ b/apps/web/src/components/ThreadHoverCard.browser.test.tsx @@ -0,0 +1,44 @@ +import { describe, expect, it, vi } from "vite-plus/test"; + +import { render } from "../../test/render"; +import "../index.css"; + +const settingsOverrides = vi.hoisted(() => ({ hoverPreviews: true })); +vi.mock(import("../hooks/useSettings"), async (original) => { + const actual = await original(); + type Settings = ReturnType; + function useClientSettings(select?: (settings: Settings) => T): T { + const settings = { ...actual.getClientSettings(), ...settingsOverrides }; + return select ? select(settings) : (settings as T); + } + return { ...actual, useClientSettings }; +}); + +import { ThreadHoverCard, ThreadHoverCardPopup } from "./ThreadHoverCard"; +import { Tooltip, TooltipTrigger } from "./ui/tooltip"; + +function openCard() { + return render( + + Thread} /> + + details + + , + ); +} + +describe("ThreadHoverCardPopup", () => { + it("renders the card when hover previews are on", async () => { + settingsOverrides.hoverPreviews = true; + await using _ = await openCard(); + await expect.poll(() => document.body.textContent).toContain("Card title"); + }); + + it("renders nothing when hover previews are off", async () => { + settingsOverrides.hoverPreviews = false; + await using _ = await openCard(); + expect(document.body.textContent).toContain("Thread"); + expect(document.body.textContent).not.toContain("Card title"); + }); +}); diff --git a/apps/web/src/components/ThreadHoverCard.tsx b/apps/web/src/components/ThreadHoverCard.tsx index ae6774a98d76d..b7ce56905dcb7 100644 --- a/apps/web/src/components/ThreadHoverCard.tsx +++ b/apps/web/src/components/ThreadHoverCard.tsx @@ -1,8 +1,15 @@ import type { ComponentProps, ReactNode } from "react"; import { TooltipPopup } from "./ui/tooltip"; +import { useClientSettings } from "~/hooks/useSettings"; import { cn } from "~/lib/utils"; +export function useHoverPreviewsEnabled(): boolean { + return useClientSettings((settings) => settings.hoverPreviews); +} + export function ThreadHoverCardPopup({ className, ...props }: ComponentProps) { + const enabled = useHoverPreviewsEnabled(); + if (!enabled) return null; return ( project.id === node?.thread?.projectId); const relationshipHint = `Open ${relationship.toLowerCase()} in this chat`; - const RelationshipPopup = agent ? ThreadHoverCardPopup : TooltipPopup; - const relationshipTooltip = agent ? ( + const showAgentCard = agent && hoverPreviews; + const RelationshipPopup = showAgentCard ? ThreadHoverCardPopup : TooltipPopup; + const relationshipTooltip = showAgentCard ? ( ({ hoverPreviews: true })); +vi.mock(import("../../hooks/useSettings"), async (original) => { + const actual = await original(); + type Settings = ReturnType; + function useClientSettings(select?: (settings: Settings) => T): T { + const settings = { ...actual.getClientSettings(), ...settingsOverrides }; + return select ? select(settings) : (settings as T); + } + return { ...actual, useClientSettings }; +}); + +import { TimelineMinimap } from "./TimelineMinimap"; +import type { TimelineMinimapItem } from "./timelineMinimapItems"; + +const items: ReadonlyArray = [ + { id: "a", rowIndex: 0, userText: "First question", assistantText: "First answer" }, + { id: "b", rowIndex: 1, userText: "Second question", assistantText: "Second answer" }, +]; + +async function renderMinimap(onSelect = vi.fn()) { + const screen = await render( +
+ {}} + onSelect={onSelect} + /> +
, + ); + const jump = screen.container.querySelector( + 'button[aria-label^="Jump to message"]', + ); + if (!jump) throw new Error("missing minimap jump button"); + return { screen, jump, onSelect }; +} + +describe("TimelineMinimap hover previews", () => { + it("shows the message preview by default", async () => { + settingsOverrides.hoverPreviews = true; + const { screen, jump } = await renderMinimap(); + await using _ = screen; + + await act(() => jump.focus()); + + const preview = screen.container.querySelector("[data-minimap-preview]"); + expect(preview?.textContent).toContain("First question"); + }); + + it("hides the preview but keeps navigation when previews are off", async () => { + settingsOverrides.hoverPreviews = false; + const { screen, jump, onSelect } = await renderMinimap(); + await using _ = screen; + + await act(() => jump.focus()); + expect(screen.container.querySelector("[data-minimap-preview]")).toBeNull(); + + await act(() => { + jump.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowDown", bubbles: true })); + }); + await act(() => { + jump.dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true })); + }); + expect(onSelect).toHaveBeenCalledWith(items[1]); + }); +}); diff --git a/apps/web/src/components/chat/TimelineMinimap.tsx b/apps/web/src/components/chat/TimelineMinimap.tsx index 3a32ec20400d9..6be2ffe079e45 100644 --- a/apps/web/src/components/chat/TimelineMinimap.tsx +++ b/apps/web/src/components/chat/TimelineMinimap.tsx @@ -10,6 +10,7 @@ import { TIMELINE_MINIMAP_MIN_ITEMS, } from "./MessagesTimeline.logic"; import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip"; +import { useHoverPreviewsEnabled } from "../ThreadHoverCard"; import { cn } from "~/lib/utils"; // A release outside the window can skip `mouseup`, so the next button-free @@ -49,6 +50,7 @@ export function TimelineMinimap({ onSelect: (item: TimelineMinimapItem) => void; }) { const [activeIndex, setActiveIndex] = useState(null); + const hoverPreviews = useHoverPreviewsEnabled(); const wheelTargetRef = (node: HTMLDivElement | null) => { if (!node) return; node.addEventListener("wheel", onWheel, { passive: false }); @@ -63,6 +65,7 @@ export function TimelineMinimap({ const activeItem = resolveTimelineMinimapPreview( resolvedActiveIndex === null ? null : (items[resolvedActiveIndex] ?? null), ); + const previewItem = hoverPreviews ? activeItem : null; const navigationInteractive = resolveTimelineMinimapNavigationInteractive(hitStripWidth) && !passThrough; const activeTopPercent = @@ -223,7 +226,7 @@ export function TimelineMinimap({ /> ); })} - {activeItem ? ( + {previewItem ? ( // Display-only: it overlaps the message column, and the strip keeps tracking beneath it. - {activeItem.userText ?? "User message"} + {previewItem.userText ?? "User message"} - {activeItem.assistantText ? ( + {previewItem.assistantText ? ( - {activeItem.assistantText} + {previewItem.assistantText} ) : null} diff --git a/apps/web/src/components/settings/AppearanceSettingsPanel.tsx b/apps/web/src/components/settings/AppearanceSettingsPanel.tsx index 00783b085d609..005d2f5ffa590 100644 --- a/apps/web/src/components/settings/AppearanceSettingsPanel.tsx +++ b/apps/web/src/components/settings/AppearanceSettingsPanel.tsx @@ -257,6 +257,28 @@ export function AppearanceSettingsPanel() { } /> + + updateSettings({ hoverPreviews: DEFAULT_UNIFIED_SETTINGS.hoverPreviews }) + } + /> + ) : null + } + control={ + updateSettings({ hoverPreviews: Boolean(checked) })} + aria-label="Show hover previews" + /> + } + /> + void) { DEFAULT_UNIFIED_SETTINGS.persistComposerContextStrip ? ["Composer context"] : []), + ...(settings.hoverPreviews !== DEFAULT_UNIFIED_SETTINGS.hoverPreviews + ? ["Hover previews"] + : []), ...getChangedTypographySettingLabels(settings), ...(settings.diffFilesCollapsed !== DEFAULT_UNIFIED_SETTINGS.diffFilesCollapsed ? ["Default diff file state"] @@ -660,6 +663,7 @@ export function useSettingsRestore(onRestored?: () => void) { inAppNotificationsEnabled: DEFAULT_UNIFIED_SETTINGS.inAppNotificationsEnabled, wordWrap: DEFAULT_UNIFIED_SETTINGS.wordWrap, persistComposerContextStrip: DEFAULT_UNIFIED_SETTINGS.persistComposerContextStrip, + hoverPreviews: DEFAULT_UNIFIED_SETTINGS.hoverPreviews, diffFilesCollapsed: DEFAULT_UNIFIED_SETTINGS.diffFilesCollapsed, diffIgnoreWhitespace: DEFAULT_UNIFIED_SETTINGS.diffIgnoreWhitespace, diffLayout: DEFAULT_UNIFIED_SETTINGS.diffLayout, diff --git a/apps/web/src/components/settings/settingsSearch.ts b/apps/web/src/components/settings/settingsSearch.ts index 7d7939e7f21f9..26c54a9ec261a 100644 --- a/apps/web/src/components/settings/settingsSearch.ts +++ b/apps/web/src/components/settings/settingsSearch.ts @@ -427,6 +427,12 @@ export const SETTINGS_SEARCH_ITEMS = [ title: "Composer context", to: "/settings/appearance", }, + { + id: "hover-previews", + title: "Hover previews", + to: "/settings/appearance", + searchTerms: ["popover tooltip preview sidebar subagent minimap timeline details clutter"], + }, { id: "project-grouping", title: msg("Project grouping"), diff --git a/packages/contracts/src/settings.ts b/packages/contracts/src/settings.ts index 7bbb03595d4bb..dfc66de7d22c0 100644 --- a/packages/contracts/src/settings.ts +++ b/packages/contracts/src/settings.ts @@ -505,6 +505,7 @@ export const ClientSettingsSchema = Schema.Struct({ persistComposerContextStrip: Schema.Boolean.pipe( Schema.withDecodingDefault(Effect.succeed(false)), ), + hoverPreviews: Schema.Boolean.pipe(Schema.withDecodingDefault(Effect.succeed(true))), favorites: ModelFavorites.pipe(Schema.withDecodingDefault(Effect.succeed([]))), providerModelPreferences: ProviderModelPreferences.pipe( @@ -2073,6 +2074,7 @@ export const ClientSettingsPatch = Schema.Struct({ fontFamilyTerminal: Schema.optionalKey(FontFamilyPreference), fontSmoothing: Schema.optionalKey(Schema.Boolean), persistComposerContextStrip: Schema.optionalKey(Schema.Boolean), + hoverPreviews: Schema.optionalKey(Schema.Boolean), favorites: Schema.optionalKey(ModelFavorites), providerModelPreferences: Schema.optionalKey(ProviderModelPreferences), pullRequestMergeMethodOverrides: Schema.optionalKey( From 36732d1fd787f75d4864a1f7f2359bb186b5fd3b Mon Sep 17 00:00:00 2001 From: Sergii Dumyk <1376107+realsergii@users.noreply.github.com> Date: Sun, 25 Oct 2026 17:45:40 +0200 Subject: [PATCH 2/4] test(web): follow browser test conventions in hover preview tests Reset mock settings through setup(), dispose the minimap screen if the helper fails, use classes for the wrapper, and assert through expect.element. Co-Authored-By: Claude Opus 5.5 --- .../ThreadHoverCard.browser.test.tsx | 17 +++-- .../chat/TimelineMinimap.browser.test.tsx | 74 +++++++++---------- 2 files changed, 47 insertions(+), 44 deletions(-) diff --git a/apps/web/src/components/ThreadHoverCard.browser.test.tsx b/apps/web/src/components/ThreadHoverCard.browser.test.tsx index 420d0a8998121..618ffdccd6773 100644 --- a/apps/web/src/components/ThreadHoverCard.browser.test.tsx +++ b/apps/web/src/components/ThreadHoverCard.browser.test.tsx @@ -1,4 +1,5 @@ import { describe, expect, it, vi } from "vite-plus/test"; +import { page } from "vite-plus/test/browser"; import { render } from "../../test/render"; import "../index.css"; @@ -17,6 +18,10 @@ vi.mock(import("../hooks/useSettings"), async (original) => { import { ThreadHoverCard, ThreadHoverCardPopup } from "./ThreadHoverCard"; import { Tooltip, TooltipTrigger } from "./ui/tooltip"; +function setup({ hoverPreviews }: { hoverPreviews: boolean }) { + settingsOverrides.hoverPreviews = hoverPreviews; +} + function openCard() { return render( @@ -30,15 +35,17 @@ function openCard() { describe("ThreadHoverCardPopup", () => { it("renders the card when hover previews are on", async () => { - settingsOverrides.hoverPreviews = true; + setup({ hoverPreviews: true }); await using _ = await openCard(); - await expect.poll(() => document.body.textContent).toContain("Card title"); + + await expect.element(page.getByText("Card title")).toBeVisible(); }); it("renders nothing when hover previews are off", async () => { - settingsOverrides.hoverPreviews = false; + setup({ hoverPreviews: false }); await using _ = await openCard(); - expect(document.body.textContent).toContain("Thread"); - expect(document.body.textContent).not.toContain("Card title"); + + await expect.element(page.getByRole("button", { name: "Thread" })).toBeVisible(); + await expect.element(page.getByText("Card title")).not.toBeInTheDocument(); }); }); diff --git a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx index e6c9c30e7010c..ff695110eae3f 100644 --- a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx +++ b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx @@ -1,6 +1,7 @@ import { describe, expect, it, vi } from "vite-plus/test"; +import { page, userEvent } from "vite-plus/test/browser"; -import { act, render } from "../../../test/render"; +import { render } from "../../../test/render"; import "../../index.css"; const settingsOverrides = vi.hoisted(() => ({ hoverPreviews: true })); @@ -22,53 +23,48 @@ const items: ReadonlyArray = [ { id: "b", rowIndex: 1, userText: "Second question", assistantText: "Second answer" }, ]; -async function renderMinimap(onSelect = vi.fn()) { - const screen = await render( -
- {}} - onSelect={onSelect} - /> -
, - ); - const jump = screen.container.querySelector( - 'button[aria-label^="Jump to message"]', +function setup({ hoverPreviews }: { hoverPreviews: boolean }) { + settingsOverrides.hoverPreviews = hoverPreviews; +} + +async function renderFocusedMinimap(onSelect = vi.fn()) { + await using stack = new AsyncDisposableStack(); + const screen = stack.use( + await render( +
+ {}} + onSelect={onSelect} + /> +
, + ), ); - if (!jump) throw new Error("missing minimap jump button"); - return { screen, jump, onSelect }; + const jump = page.getByRole("button", { name: /Jump to message/ }); + await expect.element(jump).toBeInTheDocument(); + jump.element().focus(); + const disposables = stack.move(); + return { screen, onSelect, [Symbol.asyncDispose]: () => disposables.disposeAsync() }; } describe("TimelineMinimap hover previews", () => { it("shows the message preview by default", async () => { - settingsOverrides.hoverPreviews = true; - const { screen, jump } = await renderMinimap(); - await using _ = screen; + setup({ hoverPreviews: true }); + await using _ = await renderFocusedMinimap(); - await act(() => jump.focus()); - - const preview = screen.container.querySelector("[data-minimap-preview]"); - expect(preview?.textContent).toContain("First question"); + await expect.element(page.getByText("First answer")).toBeVisible(); }); it("hides the preview but keeps navigation when previews are off", async () => { - settingsOverrides.hoverPreviews = false; - const { screen, jump, onSelect } = await renderMinimap(); - await using _ = screen; - - await act(() => jump.focus()); - expect(screen.container.querySelector("[data-minimap-preview]")).toBeNull(); + setup({ hoverPreviews: false }); + await using minimap = await renderFocusedMinimap(); - await act(() => { - jump.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowDown", bubbles: true })); - }); - await act(() => { - jump.dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true })); - }); - expect(onSelect).toHaveBeenCalledWith(items[1]); + await expect.element(page.getByText("First answer")).not.toBeInTheDocument(); + await userEvent.keyboard("{ArrowDown}{Enter}"); + await vi.waitFor(() => expect(minimap.onSelect).toHaveBeenCalledWith(items[1])); }); }); From 38bce05d8ae75d32d072b6fa5d5967853c69b482 Mon Sep 17 00:00:00 2001 From: Sergii Dumyk <1376107+realsergii@users.noreply.github.com> Date: Sun, 25 Oct 2026 21:52:30 +0200 Subject: [PATCH 3/4] test(web): assert the minimap hit area stays narrow with previews off Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/TimelineMinimap.browser.test.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx index ff695110eae3f..1ca19d1b3d6d5 100644 --- a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx +++ b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx @@ -64,6 +64,8 @@ describe("TimelineMinimap hover previews", () => { await using minimap = await renderFocusedMinimap(); await expect.element(page.getByText("First answer")).not.toBeInTheDocument(); + const jump = page.getByRole("button", { name: /Jump to message/ }); + await vi.waitFor(() => expect(jump.element().getBoundingClientRect().width).toBe(24)); await userEvent.keyboard("{ArrowDown}{Enter}"); await vi.waitFor(() => expect(minimap.onSelect).toHaveBeenCalledWith(items[1])); }); From a834935fbdeda3a35d9df577c3ff956d22cdbe9f Mon Sep 17 00:00:00 2001 From: Sergii Dumyk <1376107+realsergii@users.noreply.github.com> Date: Mon, 16 Nov 2026 08:11:01 +0200 Subject: [PATCH 4/4] test(web): pass the new atEnd prop in minimap tests Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/TimelineMinimap.browser.test.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx index 1ca19d1b3d6d5..2f38e8c1da57d 100644 --- a/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx +++ b/apps/web/src/components/chat/TimelineMinimap.browser.test.tsx @@ -36,6 +36,7 @@ async function renderFocusedMinimap(onSelect = vi.fn()) { hasPersistentGutter hitStripWidth={24} currentIndex={0} + atEnd={false} items={items} stripMap={new Map()} onWheel={() => {}}