From 285697d0f94ce5f6c5e0bc906cc85ccac635b805 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 2 Nov 2026 06:20:08 +0000 Subject: [PATCH 1/6] test(web): reproduce #29099 clipped model picker labels without hover titles These tests fail on main: a model row whose sub-provider label is cut off names neither the full label nor the provider instance on hover, and the docked effort column header gives no title for a cut-off model label. Co-Authored-By: Claude Opus 5.5 --- .../chat/ComposerModelEffort.browser.test.tsx | 29 ++++++++++- .../chat/ProviderModelPicker.browser.test.tsx | 49 +++++++++++++++++++ 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx index 3d704b5209305..83dd7500b8756 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx @@ -6,11 +6,14 @@ import { } from "@t3tools/contracts"; import { createModelCapabilities } from "@t3tools/shared/model"; import { useState } from "react"; -import { expect, it } from "vite-plus/test"; +import { expect, it, vi } from "vite-plus/test"; import { page, userEvent } from "vite-plus/test/browser"; +import "~/index.css"; + import { render } from "../../../test/render"; import { ComposerEffortColumn, describeComposerEffort } from "./ComposerModelEffort"; +import { DockedPickerContext } from "./ProviderModelPicker"; import type { TraitsSelectionInput } from "./TraitsPicker"; // Shaped like Devin over ACP: its session mode comes first, and its reasoning id is its own. @@ -123,3 +126,27 @@ it("draws an agent's reasoning as bars and keeps its mode out of the levels", as .toBeInTheDocument(); await expect.element(page.getByRole("menuitemradio")).not.toBeInTheDocument(); }); + +it("names the selected model in full when the column header cuts it off", async () => { + const modelLabel = "DeepSeek V4.1 Flash Free"; + await using screen = await render( + + {/* The docked column's width. */} +
+ {})} /> +
+
, + { router: false }, // no routes involved + ); + const header = screen.getByText(modelLabel); + const clipped = header.element(); + expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth); + + await userEvent.hover(header); + await vi.waitFor(() => + expect( + clipped.closest("[title]")?.getAttribute("title") ?? "", + "hover title of the cut-off model label", + ).toBe(modelLabel), + ); +}); diff --git a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx index b6dd1a38e86cf..75a83e93ba439 100644 --- a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx +++ b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx @@ -169,3 +169,52 @@ it("keeps a docked picker open after a pick and hands focus to that model's effo await userEvent.keyboard("{Escape}"); await expect.element(search).not.toBeInTheDocument(); }); + +it("names a row's cut-off sub-provider and its provider instance on hover", async () => { + const instanceId = ProviderInstanceId.make("opencode-zen"); + const entries = deriveProviderInstanceEntries([ + { + instanceId, + driver: ProviderDriverKind.make("opencode"), + displayName: "OpenCode Zen", + enabled: true, + installed: true, + version: null, + status: "ready", + auth: { status: "authenticated" }, + checkedAt: "2026-01-01T00:00:00.000Z", + models: [], + slashCommands: [], + skills: [], + }, + ]); + const name = "DeepSeek V4.1 Flash Free"; + const subProvider = "Alibaba Cloud International Model Studio"; + const options = new Map([[instanceId, [{ slug: "deepseek-v4.1-flash", name, subProvider }]]]); + + await using screen = await render( + {}} + />, + ); + await screen.getByRole("button", { name: "Choose model" }).click(); + const label = page.getByRole("option", { name: new RegExp(name) }).getByText(subProvider); + const clipped = label.element(); + expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth); + + await userEvent.hover(label); + await vi.waitFor(() => { + const title = clipped.closest("[title]")?.getAttribute("title") ?? ""; + const hint = "hover title of a row with a cut-off sub-provider"; + expect(title, hint).toContain(name); + expect(title, hint).toContain(subProvider); + expect(title, hint).toContain("OpenCode Zen"); + }); +}); From c6f735c47d6e8c8b79d1e38c8e6726bf00d364c3 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 2 Nov 2026 06:22:51 +0000 Subject: [PATCH 2/6] fix(web): name cut-off model picker labels in full on hover Rows title the model, sub-provider and provider instance when either label is clipped; the docked effort header titles its model label. Co-Authored-By: Claude Opus 5.5 --- .../components/chat/ComposerModelEffort.tsx | 6 ++++- apps/web/src/components/chat/ModelListRow.tsx | 27 +++++++++---------- apps/web/src/components/chat/clippedTitle.ts | 12 +++++++++ 3 files changed, 29 insertions(+), 16 deletions(-) create mode 100644 apps/web/src/components/chat/clippedTitle.ts diff --git a/apps/web/src/components/chat/ComposerModelEffort.tsx b/apps/web/src/components/chat/ComposerModelEffort.tsx index 3a863936101b2..403874eb80745 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.tsx @@ -23,6 +23,7 @@ import { Switch } from "../ui/switch"; import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip"; import type { ComposerControlSize } from "./ComposerControl"; import { ComposerPermissionsSection, type RuntimeModeOption } from "./ComposerFooterControls"; +import { titleWhenClipped } from "./clippedTitle"; import { composerFloatingLayerProps, focusCheckedPermission } from "./composerEventScope"; import { EffortGlyph, FastBolt, resolveEffortGlyph } from "./EffortGlyph"; import { DockedPickerContext } from "./ProviderModelPicker"; @@ -506,7 +507,10 @@ export function ComposerEffortColumn(props: { traits: TraitsSelectionInput | nul {controls?.effort?.descriptor.label ?? (controls?.others.length ? "Options" : "Effort")} - + {picker.modelLabel} diff --git a/apps/web/src/components/chat/ModelListRow.tsx b/apps/web/src/components/chat/ModelListRow.tsx index e70c32b064a3e..04c598aa21601 100644 --- a/apps/web/src/components/chat/ModelListRow.tsx +++ b/apps/web/src/components/chat/ModelListRow.tsx @@ -10,6 +10,7 @@ import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip"; import { cn } from "~/lib/utils"; import { modelPickerModelKey } from "./modelPickerKeys"; import { ProviderInstanceIcon } from "./ProviderInstanceIcon"; +import { titleWhenClipped } from "./clippedTitle"; export const ModelListRow = memo(function ModelListRow(props: { index: number; @@ -34,11 +35,7 @@ export const ModelListRow = memo(function ModelListRow(props: { disabledReason?: string | null; onToggleFavorite: (instanceId: ProviderInstanceId, slug: string) => void; }) { - const model = { - slug: props.slug, - name: props.name, - subProvider: props.subProvider, - }; + const displayName = getDisplayModelName(props); const row = ( -
-
{ - const name = event.currentTarget; - name.title = name.scrollWidth > name.clientWidth ? getDisplayModelName(model) : ""; - }} - > - {getDisplayModelName(model)} +
+
+ {displayName} {/* The logo is decorative, so name the provider for screen readers. */} , {props.providerDisplayName}
diff --git a/apps/web/src/components/chat/clippedTitle.ts b/apps/web/src/components/chat/clippedTitle.ts new file mode 100644 index 0000000000000..85512cbf3b3fb --- /dev/null +++ b/apps/web/src/components/chat/clippedTitle.ts @@ -0,0 +1,12 @@ +import type { PointerEvent } from "react"; + +/** A pointer-enter handler that titles the element with `title` only while it or a child is cut off. */ +export function titleWhenClipped(title: string) { + return (event: PointerEvent) => { + const element = event.currentTarget; + const clipped = [element, ...element.children].some( + (node) => node.scrollWidth > node.clientWidth, + ); + element.title = clipped ? title : ""; + }; +} From bb2c038095ca12549573b17ab6e10b8230f5331d Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 2 Nov 2026 07:27:22 +0000 Subject: [PATCH 3/6] fix(web): the Reasoning header's hover names the model in full The header shows the trigger's short name ("Opus 5.5"), so its hover title now uses the full display name. Clip checks in the tests wait for layout. Co-Authored-By: Claude Opus 5.5 --- .../chat/ComposerModelEffort.browser.test.tsx | 10 ++++++---- apps/web/src/components/chat/ComposerModelEffort.tsx | 2 +- .../chat/ProviderModelPicker.browser.test.tsx | 2 +- apps/web/src/components/chat/ProviderModelPicker.tsx | 7 +++++-- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx index 83dd7500b8756..7e248568cceee 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx @@ -128,9 +128,11 @@ it("draws an agent's reasoning as bars and keeps its mode out of the levels", as }); it("names the selected model in full when the column header cuts it off", async () => { - const modelLabel = "DeepSeek V4.1 Flash Free"; + // The header shows the trigger's short name; the hover names the model in full. + const modelLabel = "Opus 5.5 Fast Long Context"; + const modelName = "Claude Opus 5.5 Fast Long Context"; await using screen = await render( - + {/* The docked column's width. */}
{})} /> @@ -140,13 +142,13 @@ it("names the selected model in full when the column header cuts it off", async ); const header = screen.getByText(modelLabel); const clipped = header.element(); - expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth); + await vi.waitFor(() => expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth)); await userEvent.hover(header); await vi.waitFor(() => expect( clipped.closest("[title]")?.getAttribute("title") ?? "", "hover title of the cut-off model label", - ).toBe(modelLabel), + ).toBe(modelName), ); }); diff --git a/apps/web/src/components/chat/ComposerModelEffort.tsx b/apps/web/src/components/chat/ComposerModelEffort.tsx index 403874eb80745..393aa81ecfb08 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.tsx @@ -509,7 +509,7 @@ export function ComposerEffortColumn(props: { traits: TraitsSelectionInput | nul {picker.modelLabel} diff --git a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx index 75a83e93ba439..277b1d2f99d71 100644 --- a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx +++ b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx @@ -207,7 +207,7 @@ it("names a row's cut-off sub-provider and its provider instance on hover", asyn await screen.getByRole("button", { name: "Choose model" }).click(); const label = page.getByRole("option", { name: new RegExp(name) }).getByText(subProvider); const clipped = label.element(); - expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth); + await vi.waitFor(() => expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth)); await userEvent.hover(label); await vi.waitFor(() => { diff --git a/apps/web/src/components/chat/ProviderModelPicker.tsx b/apps/web/src/components/chat/ProviderModelPicker.tsx index 2e47b4c2fe3b4..ea2da4a1551ea 100644 --- a/apps/web/src/components/chat/ProviderModelPicker.tsx +++ b/apps/web/src/components/chat/ProviderModelPicker.tsx @@ -71,7 +71,10 @@ function lockBackgroundScroll(popup: HTMLElement | null) { } /** What a docked effort column needs from its picker: the model it serves. */ -export const DockedPickerContext = createContext<{ modelLabel: string }>({ modelLabel: "" }); +export const DockedPickerContext = createContext<{ modelLabel: string; modelName: string }>({ + modelLabel: "", + modelName: "", +}); export const ProviderModelPicker = memo(function ProviderModelPicker(props: { environmentId: EnvironmentId | null; @@ -425,7 +428,7 @@ export const ProviderModelPicker = memo(function ProviderModelPicker(props: { touchBackdrop > {props.effortColumn ? ( - +
{/* One fixed height, so a model with more options never resizes the popup. Short windows shrink it and keep the footer. */} From 4039839b19a17c528a698719e2d42fcb07d62927 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 2 Nov 2026 07:36:54 +0000 Subject: [PATCH 4/6] fix(web): a model picked under the pointer drops the header's old title Co-Authored-By: Claude Opus 5.5 --- .../chat/ComposerModelEffort.browser.test.tsx | 18 ++++++++++++++---- .../components/chat/ComposerModelEffort.tsx | 2 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx index 7e248568cceee..5396fa8c8a89f 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx @@ -131,15 +131,17 @@ it("names the selected model in full when the column header cuts it off", async // The header shows the trigger's short name; the hover names the model in full. const modelLabel = "Opus 5.5 Fast Long Context"; const modelName = "Claude Opus 5.5 Fast Long Context"; - await using screen = await render( - + const column = (label: string, name: string) => ( + {/* The docked column's width. */}
{})} />
-
, - { router: false }, // no routes involved +
); + await using screen = await render(column(modelLabel, modelName), { + router: false, // no routes involved + }); const header = screen.getByText(modelLabel); const clipped = header.element(); await vi.waitFor(() => expect(clipped.scrollWidth).toBeGreaterThan(clipped.clientWidth)); @@ -151,4 +153,12 @@ it("names the selected model in full when the column header cuts it off", async "hover title of the cut-off model label", ).toBe(modelName), ); + + // Picking another model with the keyboard leaves the pointer resting on the header. + await screen.rerender(column("Sonnet 5.5 Long Context", "Claude Sonnet 5.5 Long Context")); + const next = screen.getByText("Sonnet 5.5 Long Context").element(); + expect( + next.closest("[title]")?.getAttribute("title") ?? "", + "title after a model change", + ).not.toBe(modelName); }); diff --git a/apps/web/src/components/chat/ComposerModelEffort.tsx b/apps/web/src/components/chat/ComposerModelEffort.tsx index 393aa81ecfb08..eb539ee94d2cb 100644 --- a/apps/web/src/components/chat/ComposerModelEffort.tsx +++ b/apps/web/src/components/chat/ComposerModelEffort.tsx @@ -507,7 +507,9 @@ export function ComposerEffortColumn(props: { traits: TraitsSelectionInput | nul {controls?.effort?.descriptor.label ?? (controls?.others.length ? "Options" : "Effort")} + {/* Keyed so a model picked under a resting pointer drops the last model's title. */} From 8cd418bf1cae19ac6a6d2131e53f18f1161dcb06 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Fri, 13 Nov 2026 02:55:38 +0000 Subject: [PATCH 5/6] fix(web): the model row's hover names only what the row shows The provider instance is never drawn as text in the row, so it is not clipped text and stays out of the hover title. Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/ModelListRow.tsx | 4 +--- .../src/components/chat/ProviderModelPicker.browser.test.tsx | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/apps/web/src/components/chat/ModelListRow.tsx b/apps/web/src/components/chat/ModelListRow.tsx index 134e1f1498584..fdf76c0c4c7bd 100644 --- a/apps/web/src/components/chat/ModelListRow.tsx +++ b/apps/web/src/components/chat/ModelListRow.tsx @@ -66,9 +66,7 @@ export const ModelListRow = memo(function ModelListRow(props: {
diff --git a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx index c22bbeb024b64..d67fa670c571f 100644 --- a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx +++ b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx @@ -176,7 +176,7 @@ it("keeps a docked picker open after a pick and hands focus to that model's effo await expect.element(search).not.toBeInTheDocument(); }); -it("names a row's cut-off sub-provider and its provider instance on hover", async () => { +it("names a row's cut-off sub-provider in full on hover", async () => { const instanceId = ProviderInstanceId.make("opencode-zen"); const entries = deriveProviderInstanceEntries([ { @@ -221,7 +221,6 @@ it("names a row's cut-off sub-provider and its provider instance on hover", asyn const hint = "hover title of a row with a cut-off sub-provider"; expect(title, hint).toContain(name); expect(title, hint).toContain(subProvider); - expect(title, hint).toContain("OpenCode Zen"); }); }); From 38ad2f258ee364beaffc44287099b4955c481163 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Fri, 13 Nov 2026 03:26:29 +0000 Subject: [PATCH 6/6] fix(web): the model row's hover names its provider instance again The row shows the provider only as a logo, so a clipped row's title names the instance too; the proof run expects it there. This reverts commit 8cd418bf1cae19ac6a6d2131e53f18f1161dcb06. Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/ModelListRow.tsx | 4 +++- .../src/components/chat/ProviderModelPicker.browser.test.tsx | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/apps/web/src/components/chat/ModelListRow.tsx b/apps/web/src/components/chat/ModelListRow.tsx index fdf76c0c4c7bd..134e1f1498584 100644 --- a/apps/web/src/components/chat/ModelListRow.tsx +++ b/apps/web/src/components/chat/ModelListRow.tsx @@ -66,7 +66,9 @@ export const ModelListRow = memo(function ModelListRow(props: {
diff --git a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx index d67fa670c571f..c22bbeb024b64 100644 --- a/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx +++ b/apps/web/src/components/chat/ProviderModelPicker.browser.test.tsx @@ -176,7 +176,7 @@ it("keeps a docked picker open after a pick and hands focus to that model's effo await expect.element(search).not.toBeInTheDocument(); }); -it("names a row's cut-off sub-provider in full on hover", async () => { +it("names a row's cut-off sub-provider and its provider instance on hover", async () => { const instanceId = ProviderInstanceId.make("opencode-zen"); const entries = deriveProviderInstanceEntries([ { @@ -221,6 +221,7 @@ it("names a row's cut-off sub-provider in full on hover", async () => { const hint = "hover title of a row with a cut-off sub-provider"; expect(title, hint).toContain(name); expect(title, hint).toContain(subProvider); + expect(title, hint).toContain("OpenCode Zen"); }); });