From 5837ac6243dbdc477c534d337c96f0f8596a236c Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sat, 14 Nov 2026 08:28:32 +0000 Subject: [PATCH 1/4] test(pi): Pi crash errors should carry the stderr cause (#28653) Fails on main: an unexpected Pi exit reports only the exit code. Co-Authored-By: Claude Opus 5.5 --- .../provider-pi/src/server/adapter.test.ts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/packages/provider-pi/src/server/adapter.test.ts b/packages/provider-pi/src/server/adapter.test.ts index 7005311fff840..717e1757fefbf 100644 --- a/packages/provider-pi/src/server/adapter.test.ts +++ b/packages/provider-pi/src/server/adapter.test.ts @@ -6081,6 +6081,31 @@ describe("PiRpc early process exit", () => { assert.isFalse(error.message.includes("super-secret")); }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)), ); + + it.effect("includes Pi's stderr cause when it exits nonzero", () => + Effect.gen(function* () { + const cause = "Error: This extension ctx is stale after session replacement\n"; + const spawner = ChildProcessSpawner.make(() => + Effect.succeed( + makeHandle({ + exitCode: Effect.succeed(ChildProcessSpawner.ExitCode(1)), + stderr: Stream.fromIterable([new TextEncoder().encode(cause)]), + }), + ), + ); + const connection = yield* makePiRpcConnection({ + command: "pi", + args: ["--mode", "rpc"], + cwd: undefined, + env: {}, + }).pipe(Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner)); + + const error = yield* Queue.take(connection.events).pipe(Effect.flip); + assert.equal(error._tag, "PiRpcError"); + assert.include(error.message, "pi process exited with code 1"); + assert.include(error.message, "This extension ctx is stale after session replacement"); + }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)), + ); }); describe("PiRpc teardown", () => { From 006543befc559e5614e7eba6a9d99ba1a3547f1e Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sat, 14 Nov 2026 08:42:14 +0000 Subject: [PATCH 2/4] fix(pi): Pi crash errors now include the stderr cause When Pi exited unexpectedly, the RPC error carried only the exit code, so a crashing Pi extension showed up as 'pi process exited with code 1'. Keep a bounded stderr tail and, on a nonzero exit, append the last error line and its first stack frame, redacted and capped, waiting briefly for stderr to drain. Fixes pingdotgg/t3code#28653 Co-Authored-By: Claude Opus 5.5 --- packages/provider-core/src/server/failure.ts | 2 +- packages/provider-pi/src/server/rpc.ts | 41 +++++++++++++++++--- 2 files changed, 36 insertions(+), 7 deletions(-) diff --git a/packages/provider-core/src/server/failure.ts b/packages/provider-core/src/server/failure.ts index d5e9277633bc8..91ea5caad2d02 100644 --- a/packages/provider-core/src/server/failure.ts +++ b/packages/provider-core/src/server/failure.ts @@ -240,7 +240,7 @@ function replaceUnsafeControlCharacters(value: string): string { return sanitized.join(""); } -function redactProviderFailureText(value: string): string { +export function redactProviderFailureText(value: string): string { return replaceUnsafeControlCharacters(value) .replace(/\bhttps?:\/\/[^\s<>"']+/giu, redactUrl) .replace(/\b(Bearer|Basic)\s+[^\s,;]+/giu, "$1 [REDACTED]") diff --git a/packages/provider-pi/src/server/rpc.ts b/packages/provider-pi/src/server/rpc.ts index 9b016051a1501..b17b49ea0d81c 100644 --- a/packages/provider-pi/src/server/rpc.ts +++ b/packages/provider-pi/src/server/rpc.ts @@ -18,6 +18,7 @@ import { MAX_TOOL_OUTPUT_IMAGE_BASE64_LENGTH, } from "@t3tools/shared/toolOutput"; +import { redactProviderFailureText } from "@t3tools/provider-core/server/failure"; import { signalProcessGroup } from "@t3tools/provider-core/server/processGroup"; export class PiRpcError extends Schema.TaggedError()("PiRpcError", { @@ -171,12 +172,30 @@ function summarizePiError(error: unknown): string { : text; } +const PI_STDERR_TAIL_MAX_CHARS = 8_192; +const PI_STDERR_LINE_MAX_CHARS = 240; +const PI_STDERR_ERROR_LINE = /^[\w$.]*(?:Error|Exception)(?: \[[\w-]+\])?:/; + +// Only the last error line and its first stack frame: free-form stderr may echo prompts. +function piStderrCause(stderrTail: string): string | undefined { + const lines = stderrTail.split(/\r?\n/).map((line) => line.trim()); + for (let index = lines.length - 1; index >= 0; index -= 1) { + if (!PI_STDERR_ERROR_LINE.test(lines[index]!)) continue; + const frame = lines[index + 1]; + return [lines[index]!, ...(frame?.startsWith("at ") ? [frame] : [])] + .map((line) => redactProviderFailureText(line.slice(0, PI_STDERR_LINE_MAX_CHARS))) + .join(" "); + } + return undefined; +} + // Pi 0.84+ may exit 1 during import without any protocol output. -function describePiStdoutClosure(exitCode: number | undefined): string { +function describePiStdoutClosure(exitCode: number | undefined, stderrTail: string): string { if (exitCode === undefined || !Number.isFinite(exitCode)) { return "pi process closed stdout"; } - return `pi process exited with code ${exitCode}`; + const cause = exitCode === 0 ? undefined : piStderrCause(stderrTail); + return `pi process exited with code ${exitCode}${cause === undefined ? "" : `: ${cause}`}`; } function parsePiRecord(line: string): PiRpcRecord | undefined { @@ -273,6 +292,8 @@ export const makePiRpcConnection = Effect.fnUntraced(function* (options: PiRpcSp const outgoing = yield* Queue.unbounded(); const transportDown = yield* Deferred.make(); const exitDeferred = yield* Deferred.make(); + const stderrDrained = yield* Deferred.make(); + let stderrTail = ""; let nextRequestId = 0; const failTransport = Effect.fn("PiRpc.failTransport")(function* (error: PiRpcError) { @@ -371,11 +392,17 @@ export const makePiRpcConnection = Effect.fnUntraced(function* (options: PiRpcSp Effect.provideService(Clock.Clock, Clock.Clock.defaultValue()), Effect.orElseSucceed(() => Option.none()), ); + // Extension children that inherit stderr can hold it open after Pi exits. + yield* Deferred.await(stderrDrained).pipe( + Effect.timeoutOption(Duration.millis(250)), + Effect.provideService(Clock.Clock, Clock.Clock.defaultValue()), + ); return yield* failTransport( new PiRpcError({ operation: "read", detail: describePiStdoutClosure( Option.isSome(maybeExitCode) ? maybeExitCode.value : undefined, + stderrTail, ), }), ); @@ -386,13 +413,15 @@ export const makePiRpcConnection = Effect.fnUntraced(function* (options: PiRpcSp yield* child.stderr.pipe( Stream.decodeText(), - Stream.runForEach((chunk) => - chunk.trim().length === 0 + Stream.runForEach((chunk) => { + stderrTail = `${stderrTail}${chunk}`.slice(-PI_STDERR_TAIL_MAX_CHARS); + return chunk.trim().length === 0 ? Effect.void : // Log stderr length only; unbounded text may contain credentials or prompts. - Effect.logDebug("pi stderr", { stderrLength: chunk.length }), - ), + Effect.logDebug("pi stderr", { stderrLength: chunk.length }); + }), Effect.ignore, + Effect.ensuring(Deferred.succeed(stderrDrained, undefined)), Effect.forkIn(scope), ); From 522facaa957dffdd8db61a8973a3cf8c691c85f1 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sat, 14 Nov 2026 08:52:29 +0000 Subject: [PATCH 3/4] fix(pi): redact credential flag values in Pi stderr excerpts The shared redactor covers key=value but not space-separated flags, so an extension error echoing '--api-key ' leaked the value into PiRpcError. Co-Authored-By: Claude Opus 5.5 --- packages/provider-pi/src/server/adapter.test.ts | 5 ++++- packages/provider-pi/src/server/rpc.ts | 11 ++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/provider-pi/src/server/adapter.test.ts b/packages/provider-pi/src/server/adapter.test.ts index 717e1757fefbf..0194159e28a5a 100644 --- a/packages/provider-pi/src/server/adapter.test.ts +++ b/packages/provider-pi/src/server/adapter.test.ts @@ -6084,7 +6084,8 @@ describe("PiRpc early process exit", () => { it.effect("includes Pi's stderr cause when it exits nonzero", () => Effect.gen(function* () { - const cause = "Error: This extension ctx is stale after session replacement\n"; + const cause = + "Error: This extension ctx is stale after session replacement --api-key super-secret\n"; const spawner = ChildProcessSpawner.make(() => Effect.succeed( makeHandle({ @@ -6104,6 +6105,8 @@ describe("PiRpc early process exit", () => { assert.equal(error._tag, "PiRpcError"); assert.include(error.message, "pi process exited with code 1"); assert.include(error.message, "This extension ctx is stale after session replacement"); + assert.include(error.message, "--api-key [REDACTED]"); + assert.isFalse(error.message.includes("super-secret")); }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)), ); }); diff --git a/packages/provider-pi/src/server/rpc.ts b/packages/provider-pi/src/server/rpc.ts index b17b49ea0d81c..7fe079b21e2fe 100644 --- a/packages/provider-pi/src/server/rpc.ts +++ b/packages/provider-pi/src/server/rpc.ts @@ -175,6 +175,9 @@ function summarizePiError(error: unknown): string { const PI_STDERR_TAIL_MAX_CHARS = 8_192; const PI_STDERR_LINE_MAX_CHARS = 240; const PI_STDERR_ERROR_LINE = /^[\w$.]*(?:Error|Exception)(?: \[[\w-]+\])?:/; +// The shared redactor covers `key=value`; extension errors can also echo `--api-key value` argv. +const PI_STDERR_CREDENTIAL_FLAG = + /(--?[\w-]*(?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)\s+)(?:"[^"]*"|'[^']*'|\S+)/giu; // Only the last error line and its first stack frame: free-form stderr may echo prompts. function piStderrCause(stderrTail: string): string | undefined { @@ -183,7 +186,13 @@ function piStderrCause(stderrTail: string): string | undefined { if (!PI_STDERR_ERROR_LINE.test(lines[index]!)) continue; const frame = lines[index + 1]; return [lines[index]!, ...(frame?.startsWith("at ") ? [frame] : [])] - .map((line) => redactProviderFailureText(line.slice(0, PI_STDERR_LINE_MAX_CHARS))) + .map((line) => + redactProviderFailureText( + line + .slice(0, PI_STDERR_LINE_MAX_CHARS) + .replace(PI_STDERR_CREDENTIAL_FLAG, "$1[REDACTED]"), + ), + ) .join(" "); } return undefined; From dd43464e0ac4f64e2075a2d8f4359255a6597231 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sat, 14 Nov 2026 09:02:35 +0000 Subject: [PATCH 4/4] fix(pi): redact Pi stderr lines before truncating them Cutting a line at 240 chars first could split a quoted credential value from its closing quote, so only its first word was redacted. Co-Authored-By: Claude Opus 5.5 --- packages/provider-pi/src/server/adapter.test.ts | 4 ++-- packages/provider-pi/src/server/rpc.ts | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/provider-pi/src/server/adapter.test.ts b/packages/provider-pi/src/server/adapter.test.ts index 0194159e28a5a..418f3e31c185a 100644 --- a/packages/provider-pi/src/server/adapter.test.ts +++ b/packages/provider-pi/src/server/adapter.test.ts @@ -6084,8 +6084,7 @@ describe("PiRpc early process exit", () => { it.effect("includes Pi's stderr cause when it exits nonzero", () => Effect.gen(function* () { - const cause = - "Error: This extension ctx is stale after session replacement --api-key super-secret\n"; + const cause = `Error: This extension ctx is stale after session replacement --api-key super-secret --token "quoted leaked-word ${"y".repeat(240)}"\n`; const spawner = ChildProcessSpawner.make(() => Effect.succeed( makeHandle({ @@ -6107,6 +6106,7 @@ describe("PiRpc early process exit", () => { assert.include(error.message, "This extension ctx is stale after session replacement"); assert.include(error.message, "--api-key [REDACTED]"); assert.isFalse(error.message.includes("super-secret")); + assert.isFalse(error.message.includes("leaked-word")); }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)), ); }); diff --git a/packages/provider-pi/src/server/rpc.ts b/packages/provider-pi/src/server/rpc.ts index 7fe079b21e2fe..5dc780c90f10b 100644 --- a/packages/provider-pi/src/server/rpc.ts +++ b/packages/provider-pi/src/server/rpc.ts @@ -177,7 +177,7 @@ const PI_STDERR_LINE_MAX_CHARS = 240; const PI_STDERR_ERROR_LINE = /^[\w$.]*(?:Error|Exception)(?: \[[\w-]+\])?:/; // The shared redactor covers `key=value`; extension errors can also echo `--api-key value` argv. const PI_STDERR_CREDENTIAL_FLAG = - /(--?[\w-]*(?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)\s+)(?:"[^"]*"|'[^']*'|\S+)/giu; + /((? - redactProviderFailureText( - line - .slice(0, PI_STDERR_LINE_MAX_CHARS) - .replace(PI_STDERR_CREDENTIAL_FLAG, "$1[REDACTED]"), + // Redact before truncating so a cut cannot split a quoted value out of its match. + redactProviderFailureText(line.replace(PI_STDERR_CREDENTIAL_FLAG, "$1[REDACTED]")).slice( + 0, + PI_STDERR_LINE_MAX_CHARS, ), ) .join(" ");