From 892d8cd9875ab6d770892eb37734636ffa2a5a37 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 16 Nov 2026 16:02:52 -0800 Subject: [PATCH 1/3] fix(server): enforce authorization on MCP retries --- .../src/mcp/OrchestratorMcpService.test.ts | 19 +++++++- apps/server/src/mcp/OrchestratorMcpService.ts | 20 +++++++++ .../src/mcp/toolkits/project/handlers.test.ts | 10 ++++- .../src/mcp/toolkits/project/handlers.ts | 44 +++++++++++-------- 4 files changed, 71 insertions(+), 22 deletions(-) diff --git a/apps/server/src/mcp/OrchestratorMcpService.test.ts b/apps/server/src/mcp/OrchestratorMcpService.test.ts index f49bcc7c9412f..aae212b82c86e 100644 --- a/apps/server/src/mcp/OrchestratorMcpService.test.ts +++ b/apps/server/src/mcp/OrchestratorMcpService.test.ts @@ -2866,7 +2866,7 @@ describe("OrchestratorMcpService provider resolution", () => { projectId, title: "MCP parent", modelSelection: { instanceId: codexInstanceId, model: "gpt-5.4" }, - runtimeMode: "full-access", + runtimeMode: "approval-required", interactionMode: "default", branch: null, worktreePath: cwd, @@ -2910,6 +2910,23 @@ describe("OrchestratorMcpService provider resolution", () => { ...request, clientRequestId: "empty", }); + const raised = yield* service.createThreads(scope, { + ...request, + clientRequestId: "raised", + }); + const raisedId = raised.threads[0]!.threadId; + yield* orchestrator.dispatch({ + type: "thread.runtime-mode.set", + commandId: CommandId.make("raise-created-thread"), + threadId: raisedId, + runtimeMode: "full-access", + }); + const rejected = yield* service + .createThreads(scope, { ...withPrompt, clientRequestId: "raised" }) + .pipe(Effect.flip); + assert.equal(rejected.code, "runtime_mode_escalation_denied"); + assert.equal((yield* orchestrator.getThreadProjection(raisedId)).runs.length, 0); + const emojiAtLimit = yield* service.createThreads(scope, { threads: [{ ...request.threads[0]!, prompt: `${"a".repeat(76)}😀 and more work.` }], clientRequestId: "emoji-title", diff --git a/apps/server/src/mcp/OrchestratorMcpService.ts b/apps/server/src/mcp/OrchestratorMcpService.ts index 5c5c9636406e1..a8998c258a22f 100644 --- a/apps/server/src/mcp/OrchestratorMcpService.ts +++ b/apps/server/src/mcp/OrchestratorMcpService.ts @@ -3127,6 +3127,7 @@ const make = Effect.gen(function* () { initialMessage !== undefined && !created.storedEvents.some(({ event }) => event.type === "run.created") ) { + const refused = yield* Ref.make(undefined); yield* threadManagement .dispatch({ ...initialMessage, @@ -3144,6 +3145,11 @@ const make = Effect.gen(function* () { dispatchMode: { type: "start_immediately" }, }) .pipe( + Effect.provideService(DispatchModeLimit, { + runtimeMode: parent.thread.runtimeMode, + interactionMode: parent.thread.interactionMode, + refused, + }), Effect.mapError((error) => error._tag === "ThreadManagementProviderInstanceDisabledError" ? threadManagementFailure(error) @@ -3152,6 +3158,20 @@ const make = Effect.gen(function* () { `Unable to start thread ${index + 1}: ${userFacingDispatchErrorMessage(error) ?? errorMessage(error)}`, ), ), + Effect.catch((error) => + Effect.flatMap(Ref.get(refused), (refusal) => + Effect.fail( + refusal === undefined + ? error + : failure( + refusal.mode === "runtime" + ? "runtime_mode_escalation_denied" + : "interaction_mode_escalation_denied", + `Thread ${refusal.threadId} now runs in ${refusal.runtimeMode}/${refusal.interactionMode} mode, above this thread's.`, + ), + ), + ), + ), ); } const projection = yield* loadThreadRecords(threadId, ["runs"]); diff --git a/apps/server/src/mcp/toolkits/project/handlers.test.ts b/apps/server/src/mcp/toolkits/project/handlers.test.ts index c95fadd9096e2..7d3b1cdc2d75e 100644 --- a/apps/server/src/mcp/toolkits/project/handlers.test.ts +++ b/apps/server/src/mcp/toolkits/project/handlers.test.ts @@ -540,16 +540,22 @@ it.effect("a launch binds only an existing checkout that is one of the project's McpToolAccess.HandlersLayer.layer(ProjectHandlers.layer).pipe(Layer.provide(dependencies)), ), ); - const launchInto = (worktreePath: string) => + const launchInto = (worktreePath: string, clientRequestId?: string) => toolkit .handle("t3_thread_launch", { title: "Fix", projectId, + ...(clientRequestId === undefined ? {} : { clientRequestId }), workspaceStrategy: { type: "existing_worktree", worktreePath }, }) .pipe(Stream.unwrap, Stream.runCollect, Effect.provide(dependencies)); - expect((yield* launchInto(worktree)).at(-1)?.result).toMatchObject({ projectId }); + expect((yield* launchInto(worktree, "existing-checkout")).at(-1)?.result).toMatchObject({ + projectId, + }); + expect((yield* launchInto(outside, "existing-checkout")).at(-1)?.result).toMatchObject({ + code: "invalid_request", + }); expect((yield* launchInto(repo)).at(-1)?.result).toMatchObject({ projectId }); for (const elsewhere of [outside, path.join(worktree, "..", "outside"), "/"]) { expect((yield* launchInto(elsewhere)).at(-1)?.result).toMatchObject({ diff --git a/apps/server/src/mcp/toolkits/project/handlers.ts b/apps/server/src/mcp/toolkits/project/handlers.ts index 7a2fb5381227e..f3266fedbad41 100644 --- a/apps/server/src/mcp/toolkits/project/handlers.ts +++ b/apps/server/src/mcp/toolkits/project/handlers.ts @@ -161,24 +161,30 @@ export const layer = McpToolAccess.toLayer(ProjectToolkit, { const launchedModel = launched === null || launched.deletedAt !== null ? undefined : launched.modelSelection; const replaying = launchedModel !== undefined; - const project = replaying - ? undefined - : yield* Project.ProjectService.pipe( - Effect.flatMap((projects) => projects.getById(projectId)), - Effect.mapError(unavailable), - Effect.flatMap( - Option.match({ - onNone: () => - Effect.fail( - new OrchestratorMcpFailure({ - code: "invalid_request", - message: "The project was not found.", - }), - ), - onSome: Effect.succeed, - }), - ), - ); + if (launched !== null && replaying && launched.projectId !== projectId) + return yield* new OrchestratorMcpFailure({ + code: "invalid_request", + message: "A launch retry must use the original project.", + }); + const project = + replaying && input.workspaceStrategy?.type !== "existing_worktree" + ? undefined + : yield* Project.ProjectService.pipe( + Effect.flatMap((projects) => projects.getById(projectId)), + Effect.mapError(unavailable), + Effect.flatMap( + Option.match({ + onNone: () => + Effect.fail( + new OrchestratorMcpFailure({ + code: "invalid_request", + message: "The project was not found.", + }), + ), + onSome: Effect.succeed, + }), + ), + ); if (project !== undefined && input.workspaceStrategy?.type === "existing_worktree") yield* assertProjectWorktree(project.workspaceRoot, input.workspaceStrategy.worktreePath); if (!replaying && input.modelSelection !== undefined) { @@ -189,7 +195,7 @@ export const layer = McpToolAccess.toLayer(ProjectToolkit, { yield* OrchestrationMcp.requireAdvertisedModel(provider, model); } const projectSettings = - project === undefined + replaying || project === undefined ? undefined : yield* ServerSettings.ServerSettingsService.pipe( Effect.flatMap((settings) => settings.getSettings), From ac0e78b114abbc9f8c9678e9678e56afd3dc2682 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 16 Nov 2026 16:39:58 -0800 Subject: [PATCH 2/3] fix(server): recheck launch project and parent modes on retry --- apps/server/src/mcp/OrchestratorMcpService.ts | 5 +++-- apps/server/src/orchestration-v2/ThreadLaunchService.ts | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/apps/server/src/mcp/OrchestratorMcpService.ts b/apps/server/src/mcp/OrchestratorMcpService.ts index a8998c258a22f..b7908d1d74878 100644 --- a/apps/server/src/mcp/OrchestratorMcpService.ts +++ b/apps/server/src/mcp/OrchestratorMcpService.ts @@ -3127,6 +3127,7 @@ const make = Effect.gen(function* () { initialMessage !== undefined && !created.storedEvents.some(({ event }) => event.type === "run.created") ) { + const currentParent = (yield* loadThreadRecords(scope.thread.threadId, [])).thread; const refused = yield* Ref.make(undefined); yield* threadManagement .dispatch({ @@ -3146,8 +3147,8 @@ const make = Effect.gen(function* () { }) .pipe( Effect.provideService(DispatchModeLimit, { - runtimeMode: parent.thread.runtimeMode, - interactionMode: parent.thread.interactionMode, + runtimeMode: currentParent.runtimeMode, + interactionMode: currentParent.interactionMode, refused, }), Effect.mapError((error) => diff --git a/apps/server/src/orchestration-v2/ThreadLaunchService.ts b/apps/server/src/orchestration-v2/ThreadLaunchService.ts index eb452b883d761..cc07a04f0b01b 100644 --- a/apps/server/src/orchestration-v2/ThreadLaunchService.ts +++ b/apps/server/src/orchestration-v2/ThreadLaunchService.ts @@ -1334,7 +1334,10 @@ const make = Effect.gen(function* () { const threadId = claimed.storedEvents.find((stored) => stored.event.type.startsWith("thread."))?.event .threadId ?? candidateThreadId; - if (project.id !== input.projectId) { + const committedThread = yield* threads + .getThreadShell(threadId) + .pipe(Effect.mapError(mapError(input, "resolve-project", threadId))); + if (committedThread?.projectId !== input.projectId) { return yield* mapError(input, "resolve-project", threadId)("Project identity changed."); } let runId: RunId | null = null; From 9f229a53f3b59a77b31a9f5c07ded34412fbf8a0 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 16 Nov 2026 16:48:07 -0800 Subject: [PATCH 3/3] fix(server): reuse the accepted existing worktree on launch retry --- apps/server/src/orchestration-v2/ThreadLaunchService.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/server/src/orchestration-v2/ThreadLaunchService.ts b/apps/server/src/orchestration-v2/ThreadLaunchService.ts index cc07a04f0b01b..21a9e829f780e 100644 --- a/apps/server/src/orchestration-v2/ThreadLaunchService.ts +++ b/apps/server/src/orchestration-v2/ThreadLaunchService.ts @@ -1413,7 +1413,8 @@ const make = Effect.gen(function* () { // retry's own strategy, whose defaults may resolve differently. const accepted = current?.runs.find((run) => run.id === runId)?.workspacePreparation; const preparationStrategy: ThreadLaunchWorkspaceStrategy = - Option.isSome(launchReceipt) && accepted?.type === "worktree" + Option.isSome(launchReceipt) && + (accepted?.type === "worktree" || accepted?.type === "existing_worktree") ? accepted : Option.isSome(launchReceipt) && workspaceStrategy.type === "root" &&