From 640b5f7796b6a36c482a40c924f801c58b99732e Mon Sep 17 00:00:00 2001 From: Anthony Mittaz Date: Tue, 17 Nov 2026 11:20:03 +1100 Subject: [PATCH 1/2] fix(server): long setup scripts complete in macOS zsh --- .../project/ProjectSetupScriptRunner.test.ts | 22 +++++++++++++------ .../src/project/ProjectSetupScriptRunner.ts | 8 +++++-- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/apps/server/src/project/ProjectSetupScriptRunner.test.ts b/apps/server/src/project/ProjectSetupScriptRunner.test.ts index fd40f24d5a90..11e9f6e602cd 100644 --- a/apps/server/src/project/ProjectSetupScriptRunner.test.ts +++ b/apps/server/src/project/ProjectSetupScriptRunner.test.ts @@ -125,7 +125,9 @@ describe("ProjectSetupScriptRunner", () => { const { writes } = yield* setup({ shell: "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe", }); - expect(yield* Queue.take(writes)).toContain("$global:LASTEXITCODE"); + const submitted = yield* Queue.take(writes); + expect(submitted).toContain("$global:LASTEXITCODE"); + expect(submitted).not.toContain("\x1b[200~"); }), ); @@ -186,9 +188,11 @@ describe("ProjectSetupScriptRunner", () => { it.effect("types into a quiet shell that has no line editor", () => Effect.gen(function* () { - const { writes } = yield* setup(); + const { writes } = yield* setup({ command: "printf '%s\\n' 'setup-ready'\n".repeat(120) }); yield* TestClock.adjust("3 seconds"); - expect(yield* Queue.take(writes)).toContain("vp i"); + const submitted = yield* Queue.take(writes); + expect(submitted).toContain("setup-ready"); + expect(submitted).not.toContain("\x1b[200~"); }), ); @@ -248,6 +252,7 @@ const runObservedSetup = Effect.fnUntraced(function* (command: string) { const { writes, outputLines, emit, completion } = yield* setup({ command }); yield* emit({ ...event, type: "output", data: "\x1b[?2004h" }); const submitted = yield* Queue.take(writes); + const shellInput = submitted.replace("\x1b[200~", "").replace("\x1b[201~", ""); const cwd = yield* HostProcess.WorkingDirectory; const env = yield* HostProcess.Environment; @@ -258,7 +263,7 @@ const runObservedSetup = Effect.fnUntraced(function* (command: string) { const handle = yield* spawner.spawn( ChildProcess.make( "/bin/bash", - ["--noprofile", "--norc", "-c", submitted.replaceAll("\r", "\n")], + ["--noprofile", "--norc", "-c", shellInput.replaceAll("\r", "\n")], { cwd, env: { PATH: env.PATH }, @@ -279,6 +284,7 @@ const runObservedSetup = Effect.fnUntraced(function* (command: string) { yield* emit({ ...event, type: "closed" }); return { submitted, + shellInput, lines: yield* Queue.clear(outputLines), exitCode: (yield* completion).exitCode, }; @@ -298,6 +304,7 @@ describe.skipIf(HostProcess.Platform.defaultValue() === "win32")("POSIX setup co ); assert.equal(result.submitted.at(-1), "\r"); assert.notMatch(result.submitted.slice(0, -1), /[\r\n]/); + assert.notInclude(result.submitted, "\x1b[200~"); assert.deepEqual(result.lines, [ "it's ready", "literal \\n $(printf wrong) `printf wrong` café", @@ -324,9 +331,10 @@ describe.skipIf(HostProcess.Platform.defaultValue() === "win32")("POSIX setup co assert.deepEqual(result.lines, expected); assert.equal(result.exitCode, 0); assert.equal(result.submitted.at(-1), "\r"); - assert.notInclude(result.submitted, "\n"); - // The runner can write before the shell switches the terminal out of canonical mode. - for (const line of result.submitted.slice(0, -1).split("\r")) { + assert.isTrue(result.submitted.startsWith(" \x1b[200~")); + assert.isTrue(result.submitted.endsWith("\x1b[201~\r")); + assert.notInclude(result.submitted.slice(0, -1), "\r"); + for (const line of result.shellInput.slice(0, -1).split("\n")) { assert.isBelow(utf8.encode(line).byteLength, 1_024); } }), diff --git a/apps/server/src/project/ProjectSetupScriptRunner.ts b/apps/server/src/project/ProjectSetupScriptRunner.ts index 60084f648a18..ac6ccec7c5d7 100644 --- a/apps/server/src/project/ProjectSetupScriptRunner.ts +++ b/apps/server/src/project/ProjectSetupScriptRunner.ts @@ -401,7 +401,7 @@ export const make = Effect.gen(function* () { const seen = activity; yield* Effect.sleep(SHELL_QUIET_FALLBACK); if (activity !== seen) continue; - if (!busy) return "ready" as const; + if (!busy) return "quiet" as const; yield* input.onStartupPrompt; } }); @@ -590,7 +590,11 @@ export const make = Effect.gen(function* () { : terminalManager.write({ threadId: input.threadId, terminalId, - data: projectScriptTerminalInput(commandLine), + data: projectScriptTerminalInput( + shell === "ready" && completionShell === "posix" && commandLine.includes("\r") + ? `\x1b[200~${commandLine.replaceAll("\r", "\n")}\x1b[201~` + : commandLine, + ), }), ), Effect.catchCause((cause) => From 8f84442040a55f16cdfdeae3eceaae69baa33570 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Tue, 17 Nov 2026 00:42:44 +0000 Subject: [PATCH 2/2] chore(server): explain the setup paste and drop a redundant assertion Co-Authored-By: Claude Opus 5.5 --- apps/server/src/project/ProjectSetupScriptRunner.test.ts | 1 - apps/server/src/project/ProjectSetupScriptRunner.ts | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/server/src/project/ProjectSetupScriptRunner.test.ts b/apps/server/src/project/ProjectSetupScriptRunner.test.ts index 11e9f6e602cd..9e633ef8f45f 100644 --- a/apps/server/src/project/ProjectSetupScriptRunner.test.ts +++ b/apps/server/src/project/ProjectSetupScriptRunner.test.ts @@ -304,7 +304,6 @@ describe.skipIf(HostProcess.Platform.defaultValue() === "win32")("POSIX setup co ); assert.equal(result.submitted.at(-1), "\r"); assert.notMatch(result.submitted.slice(0, -1), /[\r\n]/); - assert.notInclude(result.submitted, "\x1b[200~"); assert.deepEqual(result.lines, [ "it's ready", "literal \\n $(printf wrong) `printf wrong` café", diff --git a/apps/server/src/project/ProjectSetupScriptRunner.ts b/apps/server/src/project/ProjectSetupScriptRunner.ts index ac6ccec7c5d7..1d083cf56095 100644 --- a/apps/server/src/project/ProjectSetupScriptRunner.ts +++ b/apps/server/src/project/ProjectSetupScriptRunner.ts @@ -590,6 +590,7 @@ export const make = Effect.gen(function* () { : terminalManager.write({ threadId: input.threadId, terminalId, + // macOS zsh garbles long typed-ahead multiline input; a live line editor takes it as one paste. data: projectScriptTerminalInput( shell === "ready" && completionShell === "posix" && commandLine.includes("\r") ? `\x1b[200~${commandLine.replaceAll("\r", "\n")}\x1b[201~`