From e273132dd5f934db7aa1fc3edf5204dabc7bbd53 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 18 Nov 2026 01:25:33 +0000 Subject: [PATCH 1/2] test(web): the PR row's meta line does not repeat the number to screen readers Reproduces #38396. Co-Authored-By: Claude Opus 5.5 --- .../components/chat/ThreadDetailsPrRow.browser.test.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx index 1c3fa1a3899fc..0c33baf1a2e4c 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx @@ -361,6 +361,13 @@ it("names a linked pull request row by its kind, number and title, not its URL", expect(name).toMatch(/pull request/i); expect(name).toContain("#1"); expect(name).toContain("Test PR"); + const exposedNumbers = [...screen.container.querySelectorAll("span")].filter( + (span) => + span.textContent?.trim() === "#1" && + span.closest("button") === null && + span.closest('[aria-hidden="true"]') === null, + ); + expect(exposedNumbers).toHaveLength(0); }); it("names a linked issue row by its kind, number and title, not its URL", async () => { From 1aca00378b4acc525ae3b5edd56536ca1d1ab188 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 18 Nov 2026 01:31:57 +0000 Subject: [PATCH 2/2] fix(web): screen readers read a pull request's number once in thread details The PR row's meta line repeated the number already in the title button's label. Hide that visible copy from assistive technology. Fixes pingdotgg/t3code#38396 Co-Authored-By: Claude Opus 5.5 --- apps/web/src/components/chat/ThreadDetailsPrRow.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx index c067632980156..3fc70104882c8 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.tsx @@ -483,7 +483,9 @@ export function ThreadDetailsPrRow({
{openRow(detail.title, "row", true)}
- #{number} + + #{number} + {showChecks && checksRollup !== null ? (