From 63670c6cecf17a7089b6712e214c2bc362f2e593 Mon Sep 17 00:00:00 2001 From: MINIlaolao <30876219+MINIlaolao@users.noreply.github.com> Date: Wed, 18 Nov 2026 12:12:42 +0800 Subject: [PATCH 1/2] fix(server): recover JSON-stringified delegate targets --- apps/server/src/mcp/McpHttpServer.test.ts | 33 +++++++++++++++++++++++ packages/contracts/src/orchestratorMcp.ts | 5 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/apps/server/src/mcp/McpHttpServer.test.ts b/apps/server/src/mcp/McpHttpServer.test.ts index 5801a210ba6cf..b7864cea35f6b 100644 --- a/apps/server/src/mcp/McpHttpServer.test.ts +++ b/apps/server/src/mcp/McpHttpServer.test.ts @@ -680,6 +680,39 @@ it.effect("decodes null optional arguments the way it decodes omitted ones", () }).pipe(Effect.provide(layerRecordingTools(calls))); }); +it.effect("decodes a JSON-stringified delegate target as the same object", () => { + const calls: Array = []; + return Effect.gen(function* () { + const task = "Inspect"; + const target = { + providerInstanceId: "codex", + model: "gpt-6.2-sol", + options: { reasoningEffort: "medium" }, + }; + yield* callTool("delegate_task", { task, target }); + yield* callTool("delegate_task", { task, target: JSON.stringify(target) }); + + for (const invalidTarget of ["{model:", "[]", '{"model":42}']) { + const error = yield* Effect.flip(callTool("delegate_task", { task, target: invalidTarget })); + expect(error).toBeInstanceOf(McpSchema.InvalidParams); + } + expect(calls).toHaveLength(2); + expect(calls[0]).toEqual({ + task, + target: { + ...target, + options: [{ id: "reasoningEffort", value: "medium" }], + }, + }); + expect(calls[1]).toEqual(calls[0]); + }).pipe(Effect.provide(layerRecordingTools(calls))); +}); + +it("advertises delegate target as an object", () => { + const schema = advertisedJsonSchema(OrchestratorToolkit.tools.delegate_task); + expect(schema.properties).toMatchObject({ target: { type: "object" } }); +}); + it.effect("rejects arguments a tool does not declare instead of dropping them", () => { const calls: Array = []; return Effect.gen(function* () { diff --git a/packages/contracts/src/orchestratorMcp.ts b/packages/contracts/src/orchestratorMcp.ts index ed6a62bf1eb7f..d7c607744d4a7 100644 --- a/packages/contracts/src/orchestratorMcp.ts +++ b/packages/contracts/src/orchestratorMcp.ts @@ -170,7 +170,10 @@ export type OrchestratorMcpTerminalDelegatedTaskStatus = export const OrchestratorMcpDelegateTaskInput = Schema.Struct({ task: OrchestratorMcpPrompt, - target: Schema.optional(OrchestratorMcpTarget), + // Some providers send the whole target object as JSON text. + target: Schema.optional( + Schema.Union([OrchestratorMcpTarget, Schema.fromJsonString(OrchestratorMcpTarget)]), + ), title: Schema.optional(OrchestratorMcpTitle), role: Schema.optional(OrchestratorMcpTaskRole), isolation: Schema.optional( From f44949a6aa8e8de8ba442e486488d305db2caa3d Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 18 Nov 2026 04:25:24 +0000 Subject: [PATCH 2/2] test(server): drop redundant delegate target schema test Co-Authored-By: Claude Opus 5.5 --- apps/server/src/mcp/McpHttpServer.test.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/apps/server/src/mcp/McpHttpServer.test.ts b/apps/server/src/mcp/McpHttpServer.test.ts index b7864cea35f6b..761991fd48769 100644 --- a/apps/server/src/mcp/McpHttpServer.test.ts +++ b/apps/server/src/mcp/McpHttpServer.test.ts @@ -692,7 +692,7 @@ it.effect("decodes a JSON-stringified delegate target as the same object", () => yield* callTool("delegate_task", { task, target }); yield* callTool("delegate_task", { task, target: JSON.stringify(target) }); - for (const invalidTarget of ["{model:", "[]", '{"model":42}']) { + for (const invalidTarget of ["{model:", '{"model":42}']) { const error = yield* Effect.flip(callTool("delegate_task", { task, target: invalidTarget })); expect(error).toBeInstanceOf(McpSchema.InvalidParams); } @@ -708,11 +708,6 @@ it.effect("decodes a JSON-stringified delegate target as the same object", () => }).pipe(Effect.provide(layerRecordingTools(calls))); }); -it("advertises delegate target as an object", () => { - const schema = advertisedJsonSchema(OrchestratorToolkit.tools.delegate_task); - expect(schema.properties).toMatchObject({ target: { type: "object" } }); -}); - it.effect("rejects arguments a tool does not declare instead of dropping them", () => { const calls: Array = []; return Effect.gen(function* () {