From d1385aea8930c11cb6f8137e0adcb84c22fa6af5 Mon Sep 17 00:00:00 2001 From: Geezy Date: Wed, 18 Nov 2026 11:09:33 +0100 Subject: [PATCH 1/5] fix(server): label speaker notes in OpenDocument attachments Co-authored-by: Codex (gpt-6.2-sol) --- apps/server/src/provider/documentTextWorker.ts | 16 ++++++++++++++-- .../src/provider/userInputAttachments.test.ts | 5 +++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/apps/server/src/provider/documentTextWorker.ts b/apps/server/src/provider/documentTextWorker.ts index 237df2a07ab13..bff12b296f2d4 100644 --- a/apps/server/src/provider/documentTextWorker.ts +++ b/apps/server/src/provider/documentTextWorker.ts @@ -552,8 +552,20 @@ async function* document(path: string, extension: string): AsyncGenerator child.name === "notes"); + yield* paragraphs( + speakerNotes + ? { ...part, children: part.children.filter((child) => child !== speakerNotes) } + : part, + ); + if (speakerNotes?.hasText) { + yield "Notes:\n"; + yield* paragraphs(speakerNotes); + } } } } else if (extension === ".xlsx") { diff --git a/apps/server/src/provider/userInputAttachments.test.ts b/apps/server/src/provider/userInputAttachments.test.ts index e0212783f6f62..991dc68b9b8a7 100644 --- a/apps/server/src/provider/userInputAttachments.test.ts +++ b/apps/server/src/provider/userInputAttachments.test.ts @@ -1049,9 +1049,10 @@ describe("question answer paths", () => { ext: "odp", parts: { "content.xml": - "\n First\n\t slide Second", + "\n First\n\t slide Speaker onlySecond", }, - expected: ["## Slide 1\nFirst slide\n\n## Slide 2\nSecond"], + expected: ["## Slide 1\nFirst slide\nNotes:\nSpeaker only\n\n## Slide 2\nSecond"], + absent: ["Second\nNotes:"], }, { ext: "ods", From cf36fd4c99074f109d0862cb5fa4da770982066f Mon Sep 17 00:00:00 2001 From: Geezy Date: Wed, 18 Nov 2026 11:24:22 +0100 Subject: [PATCH 2/5] fix(server): keep ODP note headings separate from slide metadata Co-authored-by: Codex (gpt-6.2-sol) --- apps/server/src/provider/documentTextWorker.ts | 7 +++++-- .../src/provider/userInputAttachments.test.ts | 15 ++++++++++++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/apps/server/src/provider/documentTextWorker.ts b/apps/server/src/provider/documentTextWorker.ts index bff12b296f2d4..9e4db01ac24db 100644 --- a/apps/server/src/provider/documentTextWorker.ts +++ b/apps/server/src/provider/documentTextWorker.ts @@ -107,7 +107,10 @@ function xml(source: string, extension: string): XmlNode { if (odf && (node.name === "p" || node.name === "h")) collapseOdfWhitespace(node); if ( (extension === ".docx" && node.name === "del") || - (odf && node.name === "annotation" && parent.name !== "semantics") + (odf && node.name === "annotation" && parent.name !== "semantics") || + (extension === ".odp" && + node.name === "page-thumbnail" && + stack.some((ancestor) => ancestor.name === "notes")) ) { parent.children.pop(); return; @@ -563,7 +566,7 @@ async function* document(path: string, extension: string): AsyncGenerator { ext: "odp", parts: { "content.xml": - "\n First\n\t slide Speaker onlySecond", + "" + + "\n First\n\t slide " + + "Overview" + + "Speaker only" + + "Second" + + "Slide previewThumbnail metadata" + + "", }, - expected: ["## Slide 1\nFirst slide\nNotes:\nSpeaker only\n\n## Slide 2\nSecond"], - absent: ["Second\nNotes:"], + expected: [ + "## Slide 1\nFirst slide\nOverview\nNotes:\nSpeaker only\n\n## Slide 2\nSecond", + ], + occurrences: { text: "\nNotes:", count: 1 }, + absent: ["Slide preview", "Thumbnail metadata"], }, { ext: "ods", From 2c04f85fb9a63ce708dcaca57c5e5a56fe246b29 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Wed, 18 Nov 2026 10:31:21 +0000 Subject: [PATCH 3/5] refactor(server): always drop ODP notes from slide body before extraction Co-Authored-By: Claude Opus 5.5 --- apps/server/src/provider/documentTextWorker.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/apps/server/src/provider/documentTextWorker.ts b/apps/server/src/provider/documentTextWorker.ts index 9e4db01ac24db..113f7e708f156 100644 --- a/apps/server/src/provider/documentTextWorker.ts +++ b/apps/server/src/provider/documentTextWorker.ts @@ -559,15 +559,14 @@ async function* document(path: string, extension: string): AsyncGenerator child.name === "notes"); - yield* paragraphs( - speakerNotes - ? { ...part, children: part.children.filter((child) => child !== speakerNotes) } - : part, - ); - if (speakerNotes?.hasText) { + const notes = children(part).find((child) => child.name === "notes"); + yield* paragraphs({ + ...part, + children: part.children.filter((child) => child !== notes), + }); + if (notes?.hasText) { yield "\nNotes:\n"; - yield* paragraphs(speakerNotes); + yield* paragraphs(notes); } } } From a542df09b427c18dc51eb233298377870c5a9a17 Mon Sep 17 00:00:00 2001 From: Geezy Date: Wed, 18 Nov 2026 11:44:10 +0100 Subject: [PATCH 4/5] fix(server): keep table values in ODP speaker notes Co-authored-by: Codex (gpt-6.2-sol) --- apps/server/src/provider/documentTextWorker.ts | 7 +++++++ apps/server/src/provider/userInputAttachments.test.ts | 9 ++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/apps/server/src/provider/documentTextWorker.ts b/apps/server/src/provider/documentTextWorker.ts index 113f7e708f156..8fe94682551c6 100644 --- a/apps/server/src/provider/documentTextWorker.ts +++ b/apps/server/src/provider/documentTextWorker.ts @@ -116,6 +116,13 @@ function xml(source: string, extension: string): XmlNode { return; } if (node.name === "Fallback" && !retainCompatibilityFallback(parent, node)) return; + if ( + extension === ".odp" && + (node.name === "table-cell" || node.name === "covered-table-cell") && + odfValue(node).trim() + ) { + node.hasText = true; + } if (HIDDEN.has(node.name) || (!node.hasText && node.name !== "noBreakHyphen")) return; parent.hasText = true; if (node.name === "Choice") parent.hasTextChoice = true; diff --git a/apps/server/src/provider/userInputAttachments.test.ts b/apps/server/src/provider/userInputAttachments.test.ts index 5dfdb75420edb..3b2d08a2b75d6 100644 --- a/apps/server/src/provider/userInputAttachments.test.ts +++ b/apps/server/src/provider/userInputAttachments.test.ts @@ -1055,12 +1055,15 @@ describe("question answer paths", () => { "Speaker only" + "Second" + "Slide previewThumbnail metadata" + - "", + "" + + "Third" + + '' + + "", }, expected: [ - "## Slide 1\nFirst slide\nOverview\nNotes:\nSpeaker only\n\n## Slide 2\nSecond", + "## Slide 1\nFirst slide\nOverview\nNotes:\nSpeaker only\n\n## Slide 2\nSecond\n\n## Slide 3\nThird\n\nNotes:\n42", ], - occurrences: { text: "\nNotes:", count: 1 }, + occurrences: { text: "\nNotes:", count: 2 }, absent: ["Slide preview", "Thumbnail metadata"], }, { From 8dcc56f65cb5f8735b9f149b2d14914842ddfa54 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Sun, 22 Nov 2026 03:25:44 +0000 Subject: [PATCH 5/5] refactor(server): gate ODP notes on hasCellText like PPTX Reuse the existing cell-value check instead of marking value-only ODP table cells during parsing, and drop test assertions the contiguous expected output already covers. Co-Authored-By: Claude Opus 5.5 --- apps/server/src/provider/documentTextWorker.ts | 9 +-------- apps/server/src/provider/userInputAttachments.test.ts | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/apps/server/src/provider/documentTextWorker.ts b/apps/server/src/provider/documentTextWorker.ts index 38812e669fc07..3dd649811f330 100644 --- a/apps/server/src/provider/documentTextWorker.ts +++ b/apps/server/src/provider/documentTextWorker.ts @@ -124,13 +124,6 @@ function xml(source: string, extension: string): XmlNode { return; } if (node.name === "Fallback" && !retainCompatibilityFallback(parent, node)) return; - if ( - extension === ".odp" && - (node.name === "table-cell" || node.name === "covered-table-cell") && - odfValue(node).trim() - ) { - node.hasText = true; - } if (HIDDEN.has(node.name) || (!node.hasText && node.name !== "noBreakHyphen")) return; parent.hasText = true; if (node.name === "Choice") parent.hasTextChoice = true; @@ -640,7 +633,7 @@ async function* document(path: string, extension: string): AsyncGenerator child !== notes), }); - if (notes?.hasText) { + if (notes && hasCellText(notes)) { yield "\nNotes:\n"; yield* paragraphs(notes); } diff --git a/apps/server/src/provider/userInputAttachments.test.ts b/apps/server/src/provider/userInputAttachments.test.ts index c8aa035bf18bd..72f7e52a3cd41 100644 --- a/apps/server/src/provider/userInputAttachments.test.ts +++ b/apps/server/src/provider/userInputAttachments.test.ts @@ -1153,8 +1153,6 @@ describe("question answer paths", () => { expected: [ "## Slide 1\nFirst slide\nOverview\nNotes:\nSpeaker only\n\n## Slide 2\nSecond\n\n## Slide 3\nThird\n\nNotes:\n42", ], - occurrences: { text: "\nNotes:", count: 2 }, - absent: ["Slide preview", "Thumbnail metadata"], }, { ext: "ods",