From 377d0fdf878893a009f263438bc5dfc36047b57c Mon Sep 17 00:00:00 2001 From: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Date: Wed, 18 Nov 2026 17:15:34 +0100 Subject: [PATCH 1/6] test(mobile): a project picked while No project opens is kept Co-authored-by: Claude Opus 5.5 --- .../threads/NewTaskRouteScreen.test.tsx | 149 ++++++++++++++++++ apps/mobile/vite.config.ts | 1 + 2 files changed, 150 insertions(+) create mode 100644 apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx new file mode 100644 index 0000000000000..490434c55b788 --- /dev/null +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx @@ -0,0 +1,149 @@ +import type { ReactNode } from "react"; +import { act } from "react"; +import { createRoot } from "react-dom/client"; +import type { EnvironmentProject } from "@t3tools/client-runtime/state/shell"; +import { EnvironmentId, ProjectId } from "@t3tools/contracts"; +import { expect, it, vi } from "vite-plus/test"; + +const environmentId = EnvironmentId.make("env-1"); + +function project(id: string, workspaceRoot: string): EnvironmentProject { + return { + environmentId, + id: ProjectId.make(id), + title: id, + workspaceRoot, + repositoryIdentity: null, + defaultModelSelection: null, + defaultThreadEnvMode: "worktree", + scripts: [], + createdAt: "2026-10-26T00:00:00Z", + updatedAt: "2026-10-26T00:00:00Z", + }; +} + +const regular = project("app", "/repo/app"); +const scratch = project("scratch", "/scratch"); + +const harness = vi.hoisted(() => ({ + setProject: vi.fn(), + openScratch: vi.fn(), + selectDetail: vi.fn(), + navigation: { + goBack: vi.fn(), + getState: () => ({ + routeNames: ["Thread", "NewTaskProject"], + index: 1, + routes: [{ name: "Thread", params: { draft: {} } }, { name: "NewTaskProject" }], + }), + getParent: () => undefined, + canGoBack: () => true, + dispatch: vi.fn(), + navigate: vi.fn(), + }, +})); + +vi.mock("react-native", () => ({ + Platform: { OS: "ios" }, + View: ({ children }: { children?: ReactNode }) =>
{children}
, + Pressable: (props: { + accessibilityLabel: string; + disabled?: boolean; + onPress: () => void; + children?: ReactNode; + }) => ( + + ), +})); +vi.mock("react-native-safe-area-context", () => ({ + useSafeAreaInsets: () => ({ top: 0, bottom: 0, left: 0, right: 0 }), +})); +vi.mock("gt-react-native", () => ({ + msg: (text: string) => text, + T: ({ children }: { children?: ReactNode }) => <>{children}, + useGT: () => (text: string) => text, + useMessages: () => (text: string) => text, +})); +vi.mock("@react-navigation/native", () => ({ + StackActions: { push: (name: string) => ({ type: "PUSH", name }) }, + useIsFocused: () => true, + useNavigation: () => harness.navigation, +})); +vi.mock("../../components/ui/NavigationRow", () => ({ NavigationRow: () => null })); +vi.mock("../../components/ui/Dialog", () => ({ alert: vi.fn() })); +vi.mock("../../components/ui/AppActivityIndicator", () => ({ AppActivityIndicator: () => null })); +vi.mock("../../components/ui/AppBar", () => ({ AppBar: () => null })); +vi.mock("../../components/ui/AppSymbol", () => ({ SymbolView: () => null })); +vi.mock("../../components/ui/Button", () => ({ Button: () => null })); +vi.mock("../../components/ui/ScreenContent", () => ({ + ScreenContent: ({ children }: { children?: ReactNode }) => <>{children}, +})); +vi.mock("../../components/ui/ScreenScrollView", () => ({ + ScreenScrollView: ({ children }: { children?: ReactNode }) => <>{children}, +})); +vi.mock("../../components/ui/AppText", () => ({ + AppText: ({ children }: { children?: ReactNode }) => {children}, +})); +vi.mock("../../components/ProjectFavicon", () => ({ ProjectFavicon: () => null })); +vi.mock("../connection/environmentStatusText", () => ({ runtimeConnectionErrorText: () => null })); +vi.mock("../../state/entities", () => ({ + useProjects: () => [regular, scratch], + useServerConfigs: () => new Map([[environmentId, { scratchWorkspaceRoot: "/scratch" }]]), +})); +vi.mock("../../state/projects", () => ({ projectEnvironment: { openScratch: {} } })); +vi.mock("../../state/use-atom-command", () => ({ useAtomCommand: () => harness.openScratch })); +vi.mock("../../state/use-composer-drafts", () => ({ retargetSavedNewTaskDraft: vi.fn() })); +vi.mock("../../state/use-remote-environment-registry", () => ({ + useRemoteConnectionStatus: () => ({ + connectedEnvironments: [{ environmentId, connectionState: "connected" }], + }), +})); +vi.mock("../../state/workspace", () => ({ + useWorkspaceState: () => ({ state: { hasReadyEnvironment: true } }), +})); +vi.mock("../sharing/IncomingShareProvider", () => ({ + useIncomingShare: () => ({ getShare: () => null, releaseShareReservation: vi.fn() }), +})); +vi.mock("../layout/workspace/useSelectWorkspaceDetail", () => ({ + useSelectWorkspaceDetail: () => harness.selectDetail, +})); +vi.mock("./new-task-flow-provider", () => ({ + useNewTaskFlow: () => ({ + projectScopes: [ + { + key: "app", + title: "app", + representative: regular, + projects: [regular], + projectRefs: [], + pinned: false, + archived: false, + }, + ], + selectedEnvironmentId: environmentId, + setProject: harness.setProject, + }), +})); + +import { NewTaskRouteScreen } from "./NewTaskRouteScreen"; + +it("keeps the project picked while No project was still opening", async () => { + (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; + const opening = Promise.withResolvers(); + harness.openScratch.mockReturnValue(opening.promise); + + const container = document.createElement("div"); + const root = createRoot(container); + using _root = { [Symbol.dispose]: () => act(() => root.unmount()) }; + act(() => root.render()); + const row = (label: string) => container.querySelector(`[aria-label="${label}"]`)!; + + act(() => row("No project").click()); + await act(async () => row("app").click()); + await act(async () => opening.resolve({ _tag: "Success", value: scratch })); + + expect(harness.setProject.mock.calls).toEqual([[regular]]); + expect(harness.navigation.goBack).toHaveBeenCalledTimes(1); +}); diff --git a/apps/mobile/vite.config.ts b/apps/mobile/vite.config.ts index 05261f9cb1848..80fca082c7c8e 100644 --- a/apps/mobile/vite.config.ts +++ b/apps/mobile/vite.config.ts @@ -8,6 +8,7 @@ const reactTests = [ "src/features/threads/useSubmitAfterNativeImages.test.tsx", "src/features/threads/git/GitBranchesSheet.test.tsx", "src/features/threads/new-task-flow-provider.test.tsx", + "src/features/threads/NewTaskRouteScreen.test.tsx", "src/features/layout/workspace/workspace-tabs-state.test.ts", "src/state/use-thread-pr.demand.test.tsx", "src/features/threads/git/GitBranchesSheet.occupancy.test.tsx", From ad30cc6791387e6c0b16b1048198a572905cea82 Mon Sep 17 00:00:00 2001 From: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Date: Wed, 18 Nov 2026 17:16:10 +0100 Subject: [PATCH 2/6] fix(mobile): a project picked while No project opens is no longer replaced Co-authored-by: Claude Opus 5.5 --- .../features/threads/NewTaskRouteScreen.tsx | 22 +++++++++++++------ 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx index f429972a176fc..d67dc0e822bad 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx @@ -235,7 +235,8 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps(null); async function selectProject(project: EnvironmentProject): Promise { if (incomingShare?.destination && !reservedDestinationProject) { @@ -292,13 +293,20 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps { - if (!canStartScratch || !scratchOption || scratchStartInFlightRef.current) return; + if (!canStartScratch || !scratchOption || pendingScratchRef.current) return; const environmentId = scratchOption.environmentId; - scratchStartInFlightRef.current = true; + const request = {}; + pendingScratchRef.current = request; const result = await openScratch({ environmentId, input: {} }); + if (pendingScratchRef.current !== request) return; if (result._tag === "Failure") { - scratchStartInFlightRef.current = false; + pendingScratchRef.current = null; if (!isAtomCommandInterrupted(result)) { const error = squashAtomCommandFailure(result); Dialog.alert( @@ -311,7 +319,7 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps void selectProject(selectionTarget)} + onPress={() => chooseProject(selectionTarget)} leading={ void selectProject(selectionTarget)} + onPress={() => chooseProject(selectionTarget)} className="flex-row items-center gap-3 bg-grouped-card px-4 py-3.5" > From 90d2584ac47b9d16162a52fccf5e426c3267a781 Mon Sep 17 00:00:00 2001 From: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Date: Thu, 19 Nov 2026 07:17:14 +0100 Subject: [PATCH 3/6] fix(mobile): cancel pending No project choices when superseded Co-authored-by: GPT 6.2 Sol --- .../threads/NewTaskRouteScreen.test.tsx | 61 ++++++++++++++++++- .../features/threads/NewTaskRouteScreen.tsx | 34 +++++++---- .../src/state/use-composer-drafts.test.ts | 8 +++ apps/mobile/src/state/use-composer-drafts.ts | 6 +- 4 files changed, 91 insertions(+), 18 deletions(-) diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx index 490434c55b788..5f47ffbde1423 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx @@ -1,5 +1,5 @@ import type { ReactNode } from "react"; -import { act } from "react"; +import { act, useEffect } from "react"; import { createRoot } from "react-dom/client"; import type { EnvironmentProject } from "@t3tools/client-runtime/state/shell"; import { EnvironmentId, ProjectId } from "@t3tools/contracts"; @@ -28,6 +28,7 @@ const scratch = project("scratch", "/scratch"); const harness = vi.hoisted(() => ({ setProject: vi.fn(), openScratch: vi.fn(), + retargetDraft: vi.fn(), selectDetail: vi.fn(), navigation: { goBack: vi.fn(), @@ -68,10 +69,17 @@ vi.mock("gt-react-native", () => ({ })); vi.mock("@react-navigation/native", () => ({ StackActions: { push: (name: string) => ({ type: "PUSH", name }) }, + useFocusEffect: (effect: () => () => void) => useEffect(effect, [effect]), useIsFocused: () => true, useNavigation: () => harness.navigation, })); -vi.mock("../../components/ui/NavigationRow", () => ({ NavigationRow: () => null })); +vi.mock("../../components/ui/NavigationRow", () => ({ + NavigationRow: (props: { title: string; disabled?: boolean; onPress: () => void }) => ( + + ), +})); vi.mock("../../components/ui/Dialog", () => ({ alert: vi.fn() })); vi.mock("../../components/ui/AppActivityIndicator", () => ({ AppActivityIndicator: () => null })); vi.mock("../../components/ui/AppBar", () => ({ AppBar: () => null })); @@ -94,7 +102,9 @@ vi.mock("../../state/entities", () => ({ })); vi.mock("../../state/projects", () => ({ projectEnvironment: { openScratch: {} } })); vi.mock("../../state/use-atom-command", () => ({ useAtomCommand: () => harness.openScratch })); -vi.mock("../../state/use-composer-drafts", () => ({ retargetSavedNewTaskDraft: vi.fn() })); +vi.mock("../../state/use-composer-drafts", () => ({ + retargetSavedNewTaskDraft: harness.retargetDraft, +})); vi.mock("../../state/use-remote-environment-registry", () => ({ useRemoteConnectionStatus: () => ({ connectedEnvironments: [{ environmentId, connectionState: "connected" }], @@ -147,3 +157,48 @@ it("keeps the project picked while No project was still opening", async () => { expect(harness.setProject.mock.calls).toEqual([[regular]]); expect(harness.navigation.goBack).toHaveBeenCalledTimes(1); }); + +it.each(["backing out and reopening", "waiting for the saved draft to load"])( + "keeps the picked project after %s while No project is pending", + async (scenario) => { + (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; + const opening = Promise.withResolvers(); + const retargeting = Promise.withResolvers(); + harness.openScratch.mockReturnValue(opening.promise); + harness.retargetDraft + .mockReset() + .mockImplementation((_draftId, target: { projectId: ProjectId }) => + target.projectId === scratch.id ? retargeting.promise : Promise.resolve(true), + ); + harness.selectDetail.mockClear(); + + const container = document.createElement("div"); + const root = createRoot(container); + using _root = { [Symbol.dispose]: () => act(() => root.unmount()) }; + const route = { params: { draftId: "existing-draft" } } as never; + const row = (label: string) => container.querySelector(`[aria-label="${label}"]`)!; + act(() => root.render()); + + act(() => row("No project").click()); + if (scenario === "backing out and reopening") { + act(() => root.render(null)); + act(() => root.render()); + } else { + await act(async () => opening.resolve({ _tag: "Success", value: scratch })); + } + await act(async () => row("app").click()); + await act(async () => { + opening.resolve({ _tag: "Success", value: scratch }); + retargeting.resolve(true); + }); + + expect(harness.selectDetail.mock.calls).toEqual([ + [ + { + name: "Thread", + params: { draft: { environmentId, projectId: regular.id, draftId: "existing-draft" } }, + }, + ], + ]); + }, +); diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx index d67dc0e822bad..716713e4293d2 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.tsx @@ -7,6 +7,7 @@ import { NavigationRow } from "../../components/ui/NavigationRow"; import { AppBar } from "../../components/ui/AppBar"; import { StackActions, + useFocusEffect, useIsFocused, useNavigation, type StaticScreenProps, @@ -19,7 +20,7 @@ import { squashAtomCommandFailure, } from "@t3tools/client-runtime/state/runtime"; import type { EnvironmentProject } from "@t3tools/client-runtime/state/shell"; -import { useEffect, useRef, useState } from "react"; +import { useCallback, useEffect, useRef, useState } from "react"; import { Platform, Pressable, View } from "react-native"; import { useSafeAreaInsets } from "react-native-safe-area-context"; import { cn } from "../../lib/cn"; @@ -235,14 +236,19 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps(null); + const pendingScratchRef = useRef(null); + const cancelPendingScratch = useCallback(() => { + pendingScratchRef.current?.abort(); + pendingScratchRef.current = null; + }, []); + useFocusEffect(useCallback(() => cancelPendingScratch, [cancelPendingScratch])); - async function selectProject(project: EnvironmentProject): Promise { + async function selectProject(project: EnvironmentProject, signal?: AbortSignal): Promise { if (incomingShare?.destination && !reservedDestinationProject) { try { await releaseShareReservation(incomingShare.id, incomingShare.destination); } catch (error) { + if (signal?.aborted) return; Dialog.alert( gt("Could not change project"), errorDisplayMessage(error, m) ?? @@ -250,6 +256,7 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps found, () => null, ); + if (signal?.aborted) return; if (retargeted === null) { Dialog.alert( gt("Could not change project"), @@ -294,17 +303,17 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps { if (!canStartScratch || !scratchOption || pendingScratchRef.current) return; const environmentId = scratchOption.environmentId; - const request = {}; + const request = new AbortController(); pendingScratchRef.current = request; const result = await openScratch({ environmentId, input: {} }); - if (pendingScratchRef.current !== request) return; + if (request.signal.aborted) return; if (result._tag === "Failure") { pendingScratchRef.current = null; if (!isAtomCommandInterrupted(result)) { @@ -317,8 +326,7 @@ export function NewTaskRouteScreen({ route }: StaticScreenProps { appAtomRegistry.set(composerDraftsAtom, {}); resetComposerDraftsLoadState(); + composerDraftFileMocks.blockRead(); + const controller = new AbortController(); + const cancelled = retargetSavedNewTaskDraft(key, to, controller.signal); + controller.abort(); + composerDraftFileMocks.releaseRead(); + await expect(cancelled).resolves.toBe(false); + expect(getComposerDraftSnapshot(key).project).toMatchObject(from); + await expect(retargetSavedNewTaskDraft(key, to)).resolves.toBe(true); expect(getComposerDraftSnapshot(key)).toMatchObject({ text: "kept through a cold start", diff --git a/apps/mobile/src/state/use-composer-drafts.ts b/apps/mobile/src/state/use-composer-drafts.ts index 57b620de5264b..f5c47c24847bb 100644 --- a/apps/mobile/src/state/use-composer-drafts.ts +++ b/apps/mobile/src/state/use-composer-drafts.ts @@ -2075,13 +2075,15 @@ export function retargetNewTaskDraft( }); } -/** Retargets a saved draft once drafts load; an absent one is not created. */ +/** Retargets a saved draft after loading. Returns false if absent or cancelled before the write. */ export async function retargetSavedNewTaskDraft( draftKey: string, project: { readonly environmentId: EnvironmentId; readonly projectId: ProjectId }, + signal?: AbortSignal, ): Promise { await waitForComposerDraftsLoaded(); - if (appAtomRegistry.get(composerDraftsAtom)[draftKey] === undefined) return false; + if (signal?.aborted || appAtomRegistry.get(composerDraftsAtom)[draftKey] === undefined) + return false; retargetNewTaskDraft(draftKey, project); return true; } From 60ab42cd876a0c8f44da04c7ae403cf3522b6253 Mon Sep 17 00:00:00 2001 From: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Date: Thu, 19 Nov 2026 07:19:12 +0100 Subject: [PATCH 4/6] test(mobile): preserve the original picker regression setup Co-authored-by: GPT 6.2 Sol --- .../threads/NewTaskRouteScreen.test.tsx | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx index 5f47ffbde1423..be1633bf0b8c6 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx @@ -1,9 +1,12 @@ import type { ReactNode } from "react"; -import { act, useEffect } from "react"; +import { act } from "react"; +import * as React from "react"; import { createRoot } from "react-dom/client"; import type { EnvironmentProject } from "@t3tools/client-runtime/state/shell"; import { EnvironmentId, ProjectId } from "@t3tools/contracts"; import { expect, it, vi } from "vite-plus/test"; +import * as navigationRow from "../../components/ui/NavigationRow"; +import { retargetSavedNewTaskDraft } from "../../state/use-composer-drafts"; const environmentId = EnvironmentId.make("env-1"); @@ -28,7 +31,6 @@ const scratch = project("scratch", "/scratch"); const harness = vi.hoisted(() => ({ setProject: vi.fn(), openScratch: vi.fn(), - retargetDraft: vi.fn(), selectDetail: vi.fn(), navigation: { goBack: vi.fn(), @@ -69,17 +71,11 @@ vi.mock("gt-react-native", () => ({ })); vi.mock("@react-navigation/native", () => ({ StackActions: { push: (name: string) => ({ type: "PUSH", name }) }, - useFocusEffect: (effect: () => () => void) => useEffect(effect, [effect]), + useFocusEffect: (effect: () => () => void) => React.useEffect(effect, [effect]), useIsFocused: () => true, useNavigation: () => harness.navigation, })); -vi.mock("../../components/ui/NavigationRow", () => ({ - NavigationRow: (props: { title: string; disabled?: boolean; onPress: () => void }) => ( - - ), -})); +vi.mock("../../components/ui/NavigationRow", () => ({ NavigationRow: () => null })); vi.mock("../../components/ui/Dialog", () => ({ alert: vi.fn() })); vi.mock("../../components/ui/AppActivityIndicator", () => ({ AppActivityIndicator: () => null })); vi.mock("../../components/ui/AppBar", () => ({ AppBar: () => null })); @@ -102,9 +98,7 @@ vi.mock("../../state/entities", () => ({ })); vi.mock("../../state/projects", () => ({ projectEnvironment: { openScratch: {} } })); vi.mock("../../state/use-atom-command", () => ({ useAtomCommand: () => harness.openScratch })); -vi.mock("../../state/use-composer-drafts", () => ({ - retargetSavedNewTaskDraft: harness.retargetDraft, -})); +vi.mock("../../state/use-composer-drafts", () => ({ retargetSavedNewTaskDraft: vi.fn() })); vi.mock("../../state/use-remote-environment-registry", () => ({ useRemoteConnectionStatus: () => ({ connectedEnvironments: [{ environmentId, connectionState: "connected" }], @@ -139,6 +133,12 @@ vi.mock("./new-task-flow-provider", () => ({ import { NewTaskRouteScreen } from "./NewTaskRouteScreen"; +vi.spyOn(navigationRow, "NavigationRow").mockImplementation(({ title, disabled, onPress }) => ( + +)); + it("keeps the project picked while No project was still opening", async () => { (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; const opening = Promise.withResolvers(); @@ -165,9 +165,9 @@ it.each(["backing out and reopening", "waiting for the saved draft to load"])( const opening = Promise.withResolvers(); const retargeting = Promise.withResolvers(); harness.openScratch.mockReturnValue(opening.promise); - harness.retargetDraft + vi.mocked(retargetSavedNewTaskDraft) .mockReset() - .mockImplementation((_draftId, target: { projectId: ProjectId }) => + .mockImplementation((_draftId, target) => target.projectId === scratch.id ? retargeting.promise : Promise.resolve(true), ); harness.selectDetail.mockClear(); From 2ad6c1a9edb77b6018cf12448f0d784c7f1f854c Mon Sep 17 00:00:00 2001 From: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Date: Thu, 19 Nov 2026 07:24:31 +0100 Subject: [PATCH 5/6] test(mobile): verify picker cancels the saved draft retarget Co-authored-by: GPT 6.2 Sol --- .../src/features/threads/NewTaskRouteScreen.test.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx index be1633bf0b8c6..fea0d64ecb99b 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx @@ -186,7 +186,16 @@ it.each(["backing out and reopening", "waiting for the saved draft to load"])( } else { await act(async () => opening.resolve({ _tag: "Success", value: scratch })); } + const scratchSignal = vi + .mocked(retargetSavedNewTaskDraft) + .mock.calls.find(([, target]) => target.projectId === scratch.id)?.[2]; + if (scenario === "waiting for the saved draft to load") { + expect(scratchSignal?.aborted).toBe(false); + } await act(async () => row("app").click()); + if (scenario === "waiting for the saved draft to load") { + expect(scratchSignal?.aborted).toBe(true); + } await act(async () => { opening.resolve({ _tag: "Success", value: scratch }); retargeting.resolve(true); From 1c012c5cc12f6567ddfc5e33b2bcf66ccc76a4f9 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Thu, 19 Nov 2026 06:46:41 +0000 Subject: [PATCH 6/6] test(mobile): simplify the No project picker regression tests Co-Authored-By: Claude Opus 5.5 --- .../threads/NewTaskRouteScreen.test.tsx | 133 ++++++++++-------- 1 file changed, 72 insertions(+), 61 deletions(-) diff --git a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx index fea0d64ecb99b..20ac36d3f7ad8 100644 --- a/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx +++ b/apps/mobile/src/features/threads/NewTaskRouteScreen.test.tsx @@ -5,7 +5,6 @@ import { createRoot } from "react-dom/client"; import type { EnvironmentProject } from "@t3tools/client-runtime/state/shell"; import { EnvironmentId, ProjectId } from "@t3tools/contracts"; import { expect, it, vi } from "vite-plus/test"; -import * as navigationRow from "../../components/ui/NavigationRow"; import { retargetSavedNewTaskDraft } from "../../state/use-composer-drafts"; const environmentId = EnvironmentId.make("env-1"); @@ -75,7 +74,13 @@ vi.mock("@react-navigation/native", () => ({ useIsFocused: () => true, useNavigation: () => harness.navigation, })); -vi.mock("../../components/ui/NavigationRow", () => ({ NavigationRow: () => null })); +vi.mock("../../components/ui/NavigationRow", () => ({ + NavigationRow: (props: { title: string; disabled?: boolean; onPress?: () => void }) => ( + + ), +})); vi.mock("../../components/ui/Dialog", () => ({ alert: vi.fn() })); vi.mock("../../components/ui/AppActivityIndicator", () => ({ AppActivityIndicator: () => null })); vi.mock("../../components/ui/AppBar", () => ({ AppBar: () => null })); @@ -133,12 +138,6 @@ vi.mock("./new-task-flow-provider", () => ({ import { NewTaskRouteScreen } from "./NewTaskRouteScreen"; -vi.spyOn(navigationRow, "NavigationRow").mockImplementation(({ title, disabled, onPress }) => ( - -)); - it("keeps the project picked while No project was still opening", async () => { (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; const opening = Promise.withResolvers(); @@ -158,56 +157,68 @@ it("keeps the project picked while No project was still opening", async () => { expect(harness.navigation.goBack).toHaveBeenCalledTimes(1); }); -it.each(["backing out and reopening", "waiting for the saved draft to load"])( - "keeps the picked project after %s while No project is pending", - async (scenario) => { - (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; - const opening = Promise.withResolvers(); - const retargeting = Promise.withResolvers(); - harness.openScratch.mockReturnValue(opening.promise); - vi.mocked(retargetSavedNewTaskDraft) - .mockReset() - .mockImplementation((_draftId, target) => - target.projectId === scratch.id ? retargeting.promise : Promise.resolve(true), - ); - harness.selectDetail.mockClear(); - - const container = document.createElement("div"); - const root = createRoot(container); - using _root = { [Symbol.dispose]: () => act(() => root.unmount()) }; - const route = { params: { draftId: "existing-draft" } } as never; - const row = (label: string) => container.querySelector(`[aria-label="${label}"]`)!; - act(() => root.render()); - - act(() => row("No project").click()); - if (scenario === "backing out and reopening") { - act(() => root.render(null)); - act(() => root.render()); - } else { - await act(async () => opening.resolve({ _tag: "Success", value: scratch })); - } - const scratchSignal = vi - .mocked(retargetSavedNewTaskDraft) - .mock.calls.find(([, target]) => target.projectId === scratch.id)?.[2]; - if (scenario === "waiting for the saved draft to load") { - expect(scratchSignal?.aborted).toBe(false); - } - await act(async () => row("app").click()); - if (scenario === "waiting for the saved draft to load") { - expect(scratchSignal?.aborted).toBe(true); - } - await act(async () => { - opening.resolve({ _tag: "Success", value: scratch }); - retargeting.resolve(true); - }); - - expect(harness.selectDetail.mock.calls).toEqual([ - [ - { - name: "Thread", - params: { draft: { environmentId, projectId: regular.id, draftId: "existing-draft" } }, - }, - ], - ]); - }, -); +function renderWithSavedDraft() { + (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; + const opening = Promise.withResolvers(); + const retargeting = Promise.withResolvers(); + harness.openScratch.mockReturnValue(opening.promise); + vi.mocked(retargetSavedNewTaskDraft) + .mockReset() + .mockImplementation((_draftId, target) => + target.projectId === scratch.id ? retargeting.promise : Promise.resolve(true), + ); + harness.selectDetail.mockClear(); + + const container = document.createElement("div"); + const root = createRoot(container); + const route = { params: { draftId: "existing-draft" } } as never; + act(() => root.render()); + return { + opening, + retargeting, + root, + route, + row: (label: string) => container.querySelector(`[aria-label="${label}"]`)!, + [Symbol.dispose]: () => act(() => root.unmount()), + }; +} + +const appDraftSelection = [ + [ + { + name: "Thread", + params: { draft: { environmentId, projectId: regular.id, draftId: "existing-draft" } }, + }, + ], +]; + +it("keeps the picked project after backing out and reopening while No project is pending", async () => { + using screen = renderWithSavedDraft(); + + act(() => screen.row("No project").click()); + act(() => screen.root.render(null)); + act(() => screen.root.render()); + await act(async () => screen.row("app").click()); + await act(async () => { + screen.opening.resolve({ _tag: "Success", value: scratch }); + screen.retargeting.resolve(true); + }); + + expect(harness.selectDetail.mock.calls).toEqual(appDraftSelection); +}); + +it("cancels the No project draft retarget when another project is picked", async () => { + using screen = renderWithSavedDraft(); + + act(() => screen.row("No project").click()); + await act(async () => screen.opening.resolve({ _tag: "Success", value: scratch })); + const scratchSignal = vi + .mocked(retargetSavedNewTaskDraft) + .mock.calls.find(([, target]) => target.projectId === scratch.id)?.[2]; + expect(scratchSignal?.aborted).toBe(false); + await act(async () => screen.row("app").click()); + expect(scratchSignal?.aborted).toBe(true); + await act(async () => screen.retargeting.resolve(true)); + + expect(harness.selectDetail.mock.calls).toEqual(appDraftSelection); +});