From c3da851eeb33399e3d17b37f3a37f3ae2e4a178e Mon Sep 17 00:00:00 2001 From: "Nick T." <73005126+tiliakoos@users.noreply.github.com> Date: Thu, 19 Nov 2026 01:40:29 -0500 Subject: [PATCH] fix(web): screen readers read a linked issue's key once in thread details The compact issue row's visible key repeated what the link's aria-label already reads, as #38400 fixed for pull request rows. --- apps/web/src/components/chat/ThreadDetailsIssueRows.tsx | 4 +++- .../components/chat/ThreadDetailsPrRow.browser.test.tsx | 7 +++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/chat/ThreadDetailsIssueRows.tsx b/apps/web/src/components/chat/ThreadDetailsIssueRows.tsx index bb3a5e2d54d3d..da3eb6e22994b 100644 --- a/apps/web/src/components/chat/ThreadDetailsIssueRows.tsx +++ b/apps/web/src/components/chat/ThreadDetailsIssueRows.tsx @@ -123,7 +123,9 @@ function LinkedIssueRow({
- {link.displayKey} + + {link.displayKey} + {trackerIcon} {comments}
diff --git a/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx b/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx index 5fb1be8665fa7..fd3d0cc702d4c 100644 --- a/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx +++ b/apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx @@ -421,6 +421,13 @@ it("names a linked issue row by its kind, number and title, not its URL", async expect(name).toMatch(/issue/i); expect(name).toContain("#123"); expect(name).toContain("Sidebar flickers on resize"); + const exposedKeys = [...screen.container.querySelectorAll("span")].filter( + (span) => + span.textContent?.trim() === "#123" && + span.closest("a") === null && + span.closest('[aria-hidden="true"]') === null, + ); + expect(exposedKeys).toHaveLength(0); const externalClick = new MouseEvent("click", { bubbles: true, cancelable: true }); await act(async () => { row.dispatchEvent(externalClick);