From 6a293eb2e9f67e4cef20107ceaffe399666f5786 Mon Sep 17 00:00:00 2001 From: Adamulek123 Date: Thu, 19 Nov 2026 17:57:19 +0100 Subject: [PATCH] perf(client-runtime): parse timestamps once when grouping issues --- packages/client-runtime/src/issueList.test.ts | 28 +++++++++++++++++++ packages/client-runtime/src/issueList.ts | 14 +++++++++- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/packages/client-runtime/src/issueList.test.ts b/packages/client-runtime/src/issueList.test.ts index 300eacc5a3408..b93dc81d0ae9f 100644 --- a/packages/client-runtime/src/issueList.test.ts +++ b/packages/client-runtime/src/issueList.test.ts @@ -197,6 +197,34 @@ describe("issueFilterScopes", () => { }); describe("groupIssues", () => { + it("sorts by the selected timestamp and keeps order for equal instants", () => { + const tracker = { + tracker: "github", + host: "github.com", + projectCount: 1, + configured: true, + detail: null, + } as IssueTrackerSummary; + const first = entry({ + key: "first", + createdAt: "2026-10-01T02:00:00+02:00", + updatedAt: "2026-10-02T00:00:00Z", + }); + const second = entry({ key: "second", createdAt: "2026-10-01T00:00:00Z" }); + const newer = entry({ key: "newer", createdAt: "2026-10-01T01:00:00Z" }); + const held = holdIssuePages( + [ + [environmentId, answer({ trackers: [tracker], entries: [first, second] })], + ["env-2" as EnvironmentId, answer({ trackers: [tracker], entries: [newer] })], + ], + new Map(), + ); + const keys = (sort: "created" | "updated") => + groupIssues(held, "", [], sort)[0]?.rows.map((row) => row.key); + expect(keys("created")).toEqual(["newer", "first", "second"]); + expect(keys("updated")).toEqual(["first", "second", "newer"]); + }); + it("lists an issue once when two environments hold the same repository", () => { const github = { tracker: "github", diff --git a/packages/client-runtime/src/issueList.ts b/packages/client-runtime/src/issueList.ts index a5f3f2d5d1709..9991eb256bf9d 100644 --- a/packages/client-runtime/src/issueList.ts +++ b/packages/client-runtime/src/issueList.ts @@ -101,6 +101,18 @@ export function issueOrder(sort: IssueListSort) { return (left: IssueListEntry, right: IssueListEntry) => date(right) - date(left); } +function sortIssueRows( + rows: EnvironmentIssueEntry[], + sort: IssueListSort, +): EnvironmentIssueEntry[] { + if (rows.length < 2) return rows; + const field = sort === "created" ? "createdAt" : "updatedAt"; + return rows + .map((row) => ({ row, timestamp: Date.parse(row[field]) })) + .sort((left, right) => right.timestamp - left.timestamp) + .map(({ row }) => row); +} + export function groupIssues( held: ReadonlyMap, query: string, @@ -158,7 +170,7 @@ export function groupIssues( group?.errors.push({ ...error, environmentId }); } } - for (const group of byTracker.values()) group.rows.sort(issueOrder(sort)); + for (const group of byTracker.values()) group.rows = sortIssueRows(group.rows, sort); return [...byTracker.values()].sort((a, b) => issueTrackerKey(a.tracker).localeCompare(issueTrackerKey(b.tracker)), );