From 4bf728715dca392474f97e0990e999d78c5335dc Mon Sep 17 00:00:00 2001 From: Neil Date: Fri, 20 Nov 2026 17:08:23 +0800 Subject: [PATCH 1/4] fix(acp-registry): detect droid, glm, and vibe flavors for local commands --- .../Adapters/AcpAdapterV2.test.ts | 15 +++ .../Adapters/AcpRegistryAdapterV2.test.ts | 122 ++++++++++++++++++ .../src/server/adapter.ts | 28 +++- 3 files changed, 159 insertions(+), 6 deletions(-) diff --git a/apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts index 4fb03956e9e13..46a8f4c888296 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts @@ -111,6 +111,10 @@ const OMP_SETTINGS = Schema.decodeSync(AcpRegistrySettings)({ commandPath: "/usr/local/bin/omp", commandArgs: ["acp"], }); +const DROID_LOCAL_SETTINGS = Schema.decodeSync(AcpRegistrySettings)({ + source: "local", + commandPath: "/opt/droid/bin/droid", +}); const OPENCODE_SETTINGS = Schema.decodeSync(AcpRegistrySettings)({ source: "local", commandPath: "/usr/local/bin/opencode", @@ -2082,6 +2086,17 @@ describe("AcpAdapterV2", () => { content: { question_1: "option_1", question_2: "other", question_2_other: "Markdown" }, }, }, + { + scenario: "extracts the paired form for a local droid command", + settings: DROID_LOCAL_SETTINGS, + schema: droidSchema, + questions: droidQuestions, + answers: { question_1: "option_1", question_2: "Markdown" }, + result: { + action: "accept", + content: { question_1: "option_1", question_2: "other", question_2_other: "Markdown" }, + }, + }, { scenario: "preserves selected labels and attachment paths in custom answers", schema: droidSchema, diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts index 35c0ec29d1148..5777cc322c6e3 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts @@ -2928,6 +2928,128 @@ describe("AcpRegistryAdapterV2", () => { }).pipe(Effect.provide(layerTest), Effect.scoped), ); + it.effect("counts per-turn usage for a local glm command", () => + Effect.gen(function* () { + const session = yield* openClaudeReplaySession( + [ + // GLM reports per-turn usage on the v1 prompt response. + ...claudeFrames.open.map((entry) => + entry.frame.method === "initialize" && entry.type === "emit_inbound" + ? { + ...entry, + frame: { + ...entry.frame, + result: { protocolVersion: 1, agentCapabilities: {}, authMethods: [] }, + }, + } + : entry, + ), + { + type: "expect_outbound", + frame: { kind: "request", method: "session/prompt", params: "" }, + }, + { + type: "emit_inbound", + frame: { + kind: "response", + method: "session/prompt", + result: { + stopReason: "end_turn", + usage: { totalTokens: 3_000, inputTokens: 2_500, outputTokens: 500 }, + }, + }, + }, + claudeFrames.closeRequest, + claudeFrames.closed, + ], + undefined, + false, + { source: "local", commandPath: "/opt/glm/bin/glm" }, + ); + yield* session.runtime.startTurn(session.turnInput(1)).pipe(Effect.forkScoped); + const events = yield* session.until((event) => event.type === "turn.terminal"); + const completed = events.findLast( + (event) => + event.type === "provider_turn.updated" && event.providerTurn.status === "completed", + ); + assert.deepEqual( + completed?.type === "provider_turn.updated" ? completed.providerTurn.turnTokenUsage : null, + { + usageScope: "main_agent", + usageStatus: "complete", + hasSubagents: false, + inputTokens: 2_500, + outputTokens: 500, + }, + ); + const terminal = events.at(-1)!; + if (terminal.type !== "turn.terminal") throw new Error("Missing terminal"); + assert.equal(terminal.status, "completed"); + }).pipe(Effect.provide(layerTest), Effect.scoped), + ); + + it.effect("surfaces Mistral's retry notice for a local vibe command", () => + Effect.gen(function* () { + const session = yield* openClaudeReplaySession( + [ + ...claudeFrames.open, + { + type: "expect_outbound", + frame: { kind: "request", method: "session/prompt", params: "" }, + }, + claudeFrames.update(CLAUDE_ROOT_SESSION, { + sessionUpdate: "user_message", + messageId: "user-1", + content: [{ type: "text", text: "test prompt" }], + }), + claudeFrames.update(CLAUDE_ROOT_SESSION, { + sessionUpdate: "state_update", + state: "running", + }), + { + type: "emit_inbound", + frame: { + kind: "notification", + method: "_session/retrying", + params: { + sessionId: CLAUDE_ROOT_SESSION, + category: "rate_limited", + detail: "Backing off for 30s", + }, + }, + }, + claudeMarker("retry noticed"), + { + type: "emit_inbound", + frame: { + kind: "response", + method: "session/prompt", + result: { stopReason: "end_turn" }, + }, + }, + claudeFrames.idle("end_turn"), + claudeFrames.closeRequest, + claudeFrames.closed, + ], + undefined, + false, + { source: "local", commandPath: "/opt/vibe/bin/vibe" }, + ); + yield* session.runtime.startTurn(session.turnInput(1)); + const events = yield* session.throughMarker("retry noticed"); + const retry = events.find( + (event) => event.type === "turn_item.updated" && event.turnItem.type === "error", + ); + if (retry?.type !== "turn_item.updated" || retry.turnItem.type !== "error") + throw new Error("Missing provider retry item"); + assert.equal(retry.turnItem.title, "Provider retry"); + assert.equal(retry.turnItem.failure.class, "usage_limit"); + assert.equal(retry.turnItem.retry.attempt, 1); + const terminal = yield* session.terminal; + assert.equal(terminal.status, "completed"); + }).pipe(Effect.provide(layerTest), Effect.scoped), + ); + it.effect("keeps stopped child tools interrupted when a late output chunk arrives", () => Effect.gen(function* () { const { update } = claudeFrames; diff --git a/packages/provider-acp-registry/src/server/adapter.ts b/packages/provider-acp-registry/src/server/adapter.ts index ce5a2b94531c4..dee1300ec3464 100644 --- a/packages/provider-acp-registry/src/server/adapter.ts +++ b/packages/provider-acp-registry/src/server/adapter.ts @@ -225,6 +225,23 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu /^claude-agent-acp(\.exe|\.cmd)?$/i.test( options.settings.commandPath.split(/[\\/]/).pop() ?? "", )); + // Local installs launch each binary directly with no registry id. + const isDroid = + registryAgentId === "factory-droid" || + (options.settings.source === "local" && + /^droid(\.exe|\.cmd)?$/i.test(options.settings.commandPath.split(/[\\/]/).pop() ?? "")); + const isGlm = + registryAgentId === "glm-acp-agent" || + (options.settings.source === "local" && + /^glm(?:-acp-agent)?(\.exe|\.cmd)?$/i.test( + options.settings.commandPath.split(/[\\/]/).pop() ?? "", + )); + const isVibe = + registryAgentId === "mistral-vibe" || + (options.settings.source === "local" && + /^vibe(?:-cli)?(\.exe|\.cmd)?$/i.test( + options.settings.commandPath.split(/[\\/]/).pop() ?? "", + )); const runtimeOptions = isClaude ? { ...options, @@ -256,8 +273,9 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu customModels: readCustomModelEntries(options.settings.customModels).map((entry) => entry.slug), compactViaAdvertisedCommand: true, ...(isAntigravityCli ? { wakeOnDetachedRequest: true, replyEndsWithUsageUpdate: true } : {}), - promptFailure: (cause) => acpRegistryPromptFailure(registryAgentId, cause), - ...(registryAgentId === "factory-droid" + promptFailure: (cause) => + acpRegistryPromptFailure(isVibe ? "mistral-vibe" : registryAgentId, cause), + ...(isDroid ? { extractElicitationForm: extractDroidElicitationForm } : isOmp ? { extractElicitationForm: extractOmpElicitationForm } @@ -265,7 +283,7 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu ? { extractElicitationForm: extractOpenCodeElicitationForm } : {}), // glm-acp-agent is the one agent whose per-turn usage a live probe has verified. - ...(registryAgentId === "glm-acp-agent" ? { reportsPerTurnPromptUsage: true } : {}), + ...(isGlm ? { reportsPerTurnPromptUsage: true } : {}), ...(watchKimiPromptOutcome === undefined ? {} : { @@ -280,9 +298,7 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu ), ), }), - ...(registryAgentId === "mistral-vibe" - ? { registerExtensions: registerMistralVibeAcpExtensions } - : {}), + ...(isVibe ? { registerExtensions: registerMistralVibeAcpExtensions } : {}), ...(isClaude ? { followAgentWorkState: true, From f5fa64c0b7d85bd801afb86e2351c16399b2b686 Mon Sep 17 00:00:00 2001 From: Neil Date: Fri, 20 Nov 2026 17:23:47 +0800 Subject: [PATCH 2/4] fix(acp-registry): also match registry-id basenames for droid and vibe --- packages/provider-acp-registry/src/server/adapter.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/provider-acp-registry/src/server/adapter.ts b/packages/provider-acp-registry/src/server/adapter.ts index dee1300ec3464..63689c5f7635e 100644 --- a/packages/provider-acp-registry/src/server/adapter.ts +++ b/packages/provider-acp-registry/src/server/adapter.ts @@ -229,7 +229,9 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu const isDroid = registryAgentId === "factory-droid" || (options.settings.source === "local" && - /^droid(\.exe|\.cmd)?$/i.test(options.settings.commandPath.split(/[\\/]/).pop() ?? "")); + /^(?:factory-)?droid(\.exe|\.cmd)?$/i.test( + options.settings.commandPath.split(/[\\/]/).pop() ?? "", + )); const isGlm = registryAgentId === "glm-acp-agent" || (options.settings.source === "local" && @@ -239,7 +241,7 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu const isVibe = registryAgentId === "mistral-vibe" || (options.settings.source === "local" && - /^vibe(?:-cli)?(\.exe|\.cmd)?$/i.test( + /^(?:mistral-)?vibe(?:-cli)?(\.exe|\.cmd)?$/i.test( options.settings.commandPath.split(/[\\/]/).pop() ?? "", )); const runtimeOptions = isClaude From 993de7c4b0a3981e91aa8c1cb07f0a0f0c907f07 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Fri, 20 Nov 2026 09:27:32 +0000 Subject: [PATCH 3/4] fix(acp-registry): match the vibe-acp binary for local Mistral Vibe Mistral Vibe ships its ACP server as vibe-acp; vibe-cli is not a name it installs. Co-Authored-By: Claude Opus 5.5 --- .../src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts | 2 +- packages/provider-acp-registry/src/server/adapter.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts index 5777cc322c6e3..0843c3fa48316 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts @@ -3033,7 +3033,7 @@ describe("AcpRegistryAdapterV2", () => { ], undefined, false, - { source: "local", commandPath: "/opt/vibe/bin/vibe" }, + { source: "local", commandPath: "/opt/vibe/bin/vibe-acp" }, ); yield* session.runtime.startTurn(session.turnInput(1)); const events = yield* session.throughMarker("retry noticed"); diff --git a/packages/provider-acp-registry/src/server/adapter.ts b/packages/provider-acp-registry/src/server/adapter.ts index dee1300ec3464..fec10257e9fcd 100644 --- a/packages/provider-acp-registry/src/server/adapter.ts +++ b/packages/provider-acp-registry/src/server/adapter.ts @@ -225,7 +225,6 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu /^claude-agent-acp(\.exe|\.cmd)?$/i.test( options.settings.commandPath.split(/[\\/]/).pop() ?? "", )); - // Local installs launch each binary directly with no registry id. const isDroid = registryAgentId === "factory-droid" || (options.settings.source === "local" && @@ -239,7 +238,7 @@ export const makeAcpRegistryAdapterV2 = Effect.fn("makeAcpRegistryAdapterV2")(fu const isVibe = registryAgentId === "mistral-vibe" || (options.settings.source === "local" && - /^vibe(?:-cli)?(\.exe|\.cmd)?$/i.test( + /^vibe(?:-acp)?(\.exe|\.cmd)?$/i.test( options.settings.commandPath.split(/[\\/]/).pop() ?? "", )); const runtimeOptions = isClaude From 109647f8fd4ac43b7b14f9badb1cac64c26f37c5 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Fri, 20 Nov 2026 09:30:26 +0000 Subject: [PATCH 4/4] test(server): read optional retry metadata in the local vibe case Co-Authored-By: Claude Opus 5.5 --- .../src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts index 0843c3fa48316..55b313a9d3adc 100644 --- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts +++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts @@ -3044,7 +3044,7 @@ describe("AcpRegistryAdapterV2", () => { throw new Error("Missing provider retry item"); assert.equal(retry.turnItem.title, "Provider retry"); assert.equal(retry.turnItem.failure.class, "usage_limit"); - assert.equal(retry.turnItem.retry.attempt, 1); + assert.equal(retry.turnItem.retry?.attempt, 1); const terminal = yield* session.terminal; assert.equal(terminal.status, "completed"); }).pipe(Effect.provide(layerTest), Effect.scoped),