diff --git a/apps/server/src/secrets/SecretRequests.test.ts b/apps/server/src/secrets/SecretRequests.test.ts index cdc6d1577cc4f..7e06ab11800e5 100644 --- a/apps/server/src/secrets/SecretRequests.test.ts +++ b/apps/server/src/secrets/SecretRequests.test.ts @@ -567,6 +567,24 @@ it.effect("a fields request keeps each value apart and delivers one file per fie }).pipe(Effect.provide(NodeServices.layer)), ); +it.effect("an older client's single value answers a one-field card", () => + Effect.gen(function* () { + const fs = yield* FileSystem.FileSystem; + const directory = yield* fs.makeTempDirectoryScoped({ prefix: "secret-files-test-" }); + yield* withService( + ({ service, dispatched }) => + Effect.gen(function* () { + yield* service.answer({ threadId, turnItemId, answer: { type: "save", secret: "tv" } }); + assert.include(dispatched[0] as object, { secretStatus: "saved" }); + const saved = yield* service.saveToFile({ threadId, turnItemId }); + const files = "files" in saved ? saved.files : {}; + assert.equal(yield* fs.readFileString(files.test_field ?? ""), "tv"); + }), + { delivery: "file", directory, fields: [{ name: "test_field", label: "Test value" }] }, + ); + }).pipe(Effect.provide(NodeServices.layer)), +); + it.effect("two racing answers to a fields card never mix their values", () => Effect.gen(function* () { const fs = yield* FileSystem.FileSystem; diff --git a/apps/server/src/secrets/SecretRequests.ts b/apps/server/src/secrets/SecretRequests.ts index e233bdd8cea4f..34f9ea35e2b17 100644 --- a/apps/server/src/secrets/SecretRequests.ts +++ b/apps/server/src/secrets/SecretRequests.ts @@ -57,6 +57,10 @@ function answerValues( ): ReadonlyArray | undefined { if (item.fields === undefined) return "secret" in answer ? [[undefined, answer.secret]] : undefined; + // Clients older than `fields` render a one-field card as their single input. + const [only, ...rest] = item.fields; + if ("secret" in answer) + return only !== undefined && rest.length === 0 ? [[only.name, answer.secret]] : undefined; if (!("values" in answer)) return undefined; const { values } = answer; if (Object.keys(values).length !== item.fields.length) return undefined;